Issue metadata
Sign in to add a comment
|
Tapping on white space next to tab switcher will not trigger omnibox |
||||||||||||||||||||||
Issue descriptionApp Version: 61.0.3163.11 Beta iOS Version: 9.3.5, 10.3.1, 11.0.0 Device: iPhone Steps to reproduce: 1. Launch chrome 2. Tap on white space above google and next to tab switcher Observed results: The omnibox is not displayed Expected results: The omnibox should be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M60 Stable Bug reproducible on the current beta channel build (App Version, iOS Version):Yes on M61 Beta Link to video/image: M61 Beta behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8RlZDVDcwTzBuZXc/view?usp=sharing M60 Stable behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8M2w4U0xlaXJ2d0E/view?usp=sharing
,
Jul 27 2017
gambard@ can you take a look?
,
Jul 28 2017
I can repro on M62.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0178eb9ac4a52b019e87a724b67a13d2b524c9cb commit 0178eb9ac4a52b019e87a724b67a13d2b524c9cb Author: gambard <gambard@chromium.org> Date: Wed Aug 02 06:42:35 2017 Set dispatcher in NTPToolbarController The dispatcher wasn't set anymore due to some refactoring. This CL sets it back. Bug: 749488 Change-Id: I94a7d738721720dc3e2814f94d9658cd152debaa Reviewed-on: https://chromium-review.googlesource.com/593567 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491286} [modify] https://crrev.com/0178eb9ac4a52b019e87a724b67a13d2b524c9cb/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
,
Aug 2 2017
,
Aug 3 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad19e76f673d6dd55af3e7720ae5dabd0179926a commit ad19e76f673d6dd55af3e7720ae5dabd0179926a Author: gambard <gambard@chromium.org> Date: Thu Aug 03 07:09:29 2017 Set dispatcher in NTPToolbarController The dispatcher wasn't set anymore due to some refactoring. This CL sets it back. TBR=gambard@chromium.org (cherry picked from commit 0178eb9ac4a52b019e87a724b67a13d2b524c9cb) Bug: 749488 Change-Id: I94a7d738721720dc3e2814f94d9658cd152debaa Reviewed-on: https://chromium-review.googlesource.com/593567 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491286} Reviewed-on: https://chromium-review.googlesource.com/599548 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#267} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ad19e76f673d6dd55af3e7720ae5dabd0179926a/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
,
Aug 8 2017
Verified in 62.0.3179.0 canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 Looks good
,
Aug 9 2017
Verified in: Application Version: 61.0.3163.40 beta Devices: iPhone 6 Plus, iPhone 7 Plus, iPhone 5 iOS Version: 11.0 Beta 5, 10.3.3, 9.3.5 Issue is fixed. Fake omnibox is activated tapping on empty space around tab switcher. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 27 2017Status: Assigned (was: Untriaged)