New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749448 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 739973
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Pdf page restores in left corner after opening system print dialog.

Reported by abom...@etouch.net, Jul 27 2017

Issue description

Chrome Version:62.0.3168.0 (Official Build)da2455bea333a5a4bfe61ba1fcfe9e325dc368e1-refs/heads/master@{#489803}  (32/64-bit)
OS: Mac Touchbar(10.12.1)

What steps will reproduce the problem?
1.Launch Chrome, navigate to http://che.org.il/wp-content/uploads/2016/12/pdf-sample.pdf or any pdf 
2.Give print command and click on “Print using system dialogue”.
2.Observe.

Actual Result: Pdf page restores in left corner on opening system print dialog.
Expected Result: Pdf page should remain in it's original size and should not restore in left corner.

This is Regression issue, broken in M-62 and below is narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/648712d3a1b20fe472d0b86f700e2ac1f247291f..44efa9da586562b75369140869aa83c2087db940?pretty=fuller&n=10000

Suspecting: r486754 

Manual Bisect Info:
Good Build: 62.0.3154.0
Bad Build: 62.0.3155.0

Note: Issue is not reproducible on Win, Linux and Mac PRO (10.11.6,10.12.3)

 
Actual.mov
1.3 MB Download
Expected.mov
1.1 MB Download
Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Thank You!
Cc: -nyerramilli@chromium.org -rbasuvula@chromium.org -msrchandra@chromium.org jdoerrie@chromium.org asvitk...@chromium.org rbpotter@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
As stated in the description, that CL is just adding tests. The only changes are in the chrome/test/data/webui directory, which is not even included in a chrome build (built only for tests), so it should not be possible for that CL to have caused the issue.

cc-ing both authors from the other CLs in that bisect, since neither jumps out as suspicious. If anyone has a Mac Touchbar it may be worth bisecting again to verify.
Cc: shrike@chromium.org
Labels: -hasbisect -M-62 Needs-Bisect Needs-Feedback M-61
There are a number of problems with this bug report:

1. There is no 62.0.3155.0 - 3155 is within M61.
2. The suspected cl landed in 61.0.3158.0, not 3155
3. I cannot reproduce this problem in 61.0.3155.0 or 61.0.3158.0, although I do see a brief flash of flush-left, clipped content. It's as if Chrome's print machinery resizes the web contents after the user chooses Print using system dialog, and in my case resizes the contents back but for the bug reporter does not size it back.

Marking this RBS M-61 for now, but the reporter should produce a new regression range with correct version numbers.


abombde@ Please re-bisect and update the behavior in latest chrome versions.

Comment 6 by abom...@etouch.net, Aug 3 2017

Labels: -Needs-Feedback -Needs-Bisect
With respect to comment #4 and #5:

Above issue is reproducible on Latest Chrome Version:62.0.3174.0 (official build only) using Mac Touchbar(10.12.1) but getting all Bad chromium builds.

Attached screencast of Official Chrome good build version:61.0.3154.0 and Chromium bad build:61.0.3148.0(484001)

Correction in Manual regression range:
Good build:61.0.3154.0
Bad build:61.0.3155.0

ChangeLog:
https://chromium.googlesource.com/chromium/src/+log/61.0.3154.0..61.0.3155.0?pretty=fuller&n=10000

Kindly help me to reassign the above issue.
Actual_54(Official chrome).mov
2.1 MB Download
Actual_48(chromium).mov
3.3 MB Download

Comment 7 by abom...@etouch.net, Aug 3 2017

With respect to comment #4 and #5:

Above issue is reproducible on Latest Chrome Version:62.0.3174.0 (official build only) using Mac Touchbar(10.12.1) but getting all Bad chromium builds.

Attached screencast of Official Chrome good build version:61.0.3154.0 and Chromium bad build:61.0.3148.0(484001)

Correction in Manual regression range:
Good build:61.0.3154.0
Bad build:61.0.3155.0

ChangeLog:
https://chromium.googlesource.com/chromium/src/+log/61.0.3154.0..61.0.3155.0?pretty=fuller&n=10000

Kindly help me to reassign the above issue.
Actual_54(Official chrome).mov
2.1 MB Download
Actual_48(chromium).mov
3.3 MB Download
Owner: thestig@chromium.org
Suspecting 

Print Preview: Return or crash on failures

Ensure we always return after rejecting JS callback or CHECK if the
condition should always be met.

BUG= 717296 

Review-Url: https://codereview.chromium.org/2980603002

I am unable to reproduce, but I'm suspecting abombde@etouch.net is encountering some exceptional condition that causes the print preview code to bail out where it did not before the change.

Assigning to thestig@, as rbpotter@ is OOO.
Labels: Needs-Feedback
To the bug reporter - do you see any error messages printed out when this happens?

There are 3 changes in the CL linked above. The first does nothing (change was just to make the behavior more clear), because PrivetPrintingEnabled() returning false implies that ENABLE_SERVICE_DISCOVERY is off so nothing else executes. The second would crash the browser, which isn't occurring. The third is an early return, but an error message should print out first and when the return was missing we dereferenced a null pointer, so builds just before this one should also have the error message + a crash.

Also, does this reproduce if you print with the system dialog directly via ctrl + shift + P? On Windows I noticed that the PDF animation (PDF moves to top left corner and then back to center) also occurs when I open the system dialog that way, so wondering if this bug shows up for you in that case as well.
Labels: -Needs-Feedback
With respect to comment #9:

Above issue is still reproducible on Latest Canary version:62.0.3178.0 (Official Build) cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239}

Note:
1. No error message is seen while given System print Command.
2. Yes, It is reproducible but before giving System print command using shortcut(Command+Option+P) make sure Print preview (command+P) window is open.
3. Issue is not seen on Windows, Mac Pro desktop(10.11.6,10.12.3) and Linux OS.
Actual_shortcutsystemprint.mov
3.4 MB Download
I can't repro locally, but one possibility is this is  bug 739973 , except for the bug reporter, the flickering from the resize gets stuck.
[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Thank you.

[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62.

Comment 14 by abom...@etouch.net, Aug 17 2017

Above issue seems to be fixed on Latest Canary Version:62.0.3188.0 (Official Build)using Mac Touchbar(10.12.1)

Kindly review the screencast.
Actual_88.mov
1.4 MB Download
Mergedinto: 739973
Status: Duplicate (was: Untriaged)

Sign in to add a comment