New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749438 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression
re

Blocked on:
issue 751919

Blocking:
issue 713854



Sign in to add a comment

BBC news site fails to render

Reported by p...@myitcv.org.uk, Jul 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.13 Safari/537.36

Steps to reproduce the problem:
1. Visit http://www.bbc.co.uk/news
2. Observe the network activity downloads a number of files etc
3. The page finishes loading, but all you see is a blank white screen
4. If however you right click to "Inspect" any part of the white screen, you can see there is a DOM being rendered. Indeed if you left click on part of the screen you will notice that links etc are clickable, they are just "invisible" (i.e. everything is white)

What is the expected behavior?
The page renders properly

What went wrong?
Despite the fact the DOM appears to have been created, nothing was rendered

Screenshot attached

Did this work before? Yes Previous version in dev channel

Chrome version: 61.0.3163.13  Channel: dev
OS Version: OS X 10.12.6
Flash Version:
 
Screen Shot 2017-07-27 at 09.00.47.png
323 KB View Download

Comment 1 by p...@myitcv.org.uk, Jul 27 2017

Same issue with Travis CI website: https://travis-ci.org/
Cc: pbomm...@chromium.org
Components: -UI Blink
Unable to reproduce the issue with Chrome 61.0.3163.13 on Windows 7,10, Mac(10.12.6) and Linux.
Labels: Needs-Feedback M-61
paul@ if possible can you please provide machine and about://gpu details(Save the page as html and attach)

Comment 4 by p...@myitcv.org.uk, Jul 28 2017

about://gpu details attached

MacBook Pro (Retina, 15-inch, Late 2013)
2.6 GHz Intel Core i7
16 GB 1600 MHz DDR3
NVIDIA GeForce GT 750M 2048 MB
Intel Iris Pro 1536 MB

Also attached another screenshot which shows the BBC news page again, but I've scrolled down to show that some artefacts are partially rendered. i.e. the page is "rendered" sufficiently that I can scroll up and down, but apart from these artefacts the entire page is white.

Also if I open a new tab and then navigate to the BBC news page (typing in url) I can see that the top part of the page is _briefly_ rendered before disappearing again, leaving a white "page".

Happy to provide any more details, repros etc as required.
gpu.html
51.1 KB View Download
Screen Shot 2017-07-28 at 07.36.14.png
46.9 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "pbommana@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by rbyers@chromium.org, Jul 28 2017

Components: -Blink Blink>Paint

Comment 7 by rbyers@chromium.org, Jul 28 2017

Components: Internals>GPU
Probably more likely to be a GPU-issue given the difficulty of reproduction.

Comment 8 by enne@chromium.org, Jul 28 2017

Owner: vmi...@chromium.org
Status: Assigned (was: Unconfirmed)
vmiura says he can repro, so assigning to him for a bisect.

Comment 9 by vmi...@chromium.org, Jul 28 2017

Labels: -Pri-2 ReleaseBlock-Stable Pri-1
I can reproduce the bbc.co.uk/news issue on 62.0.3168.0 Canary.  I'll bisect.
Cc: zmo@chromium.org senorblanco@chromium.org ericrk@chromium.org
Components: Internals>Compositing>Rasterization
I've been unable to reproduce this reliably, so unable to bisect.

pbommana@ was able to reproduce after trying for 5 hours, and I'm currently debugging that system.

The only thing I've been able to tell that's unusual is if you open instruments and turn on the "FPS Meter" in the "Rendering" tools, the GPU Raster state is "MSAA (content)".  Missing content is linked to this.  When reloading the tab, the content briefly displays and GPU Raster state is "On" before switching to "MSAA (content)" and going blank.

This is on a MBP with Dual GPU, but at the time of the issue only the integrated Intel GPU is in use.  MSAA mode should be blacklisted on Intel GPUs.

vmiura@, thank you for the update. I have been reported similar issues on OS X 10.13 and seems like we made some progress here.

https://bugs.chromium.org/p/chromium/issues/detail?id=744944
https://bugs.chromium.org/p/chromium/issues/detail?id=739930

I am the one who reproduced this scenario, however not a big deal though :)
Cc: kbr@chromium.org ccameron@chromium.org
kbr@ and I found --msaa_is_slow=0 forces the issue.  So there are two issues here

1) It looks like the MSAA raster mode is broken on Intel.
2) When there is a switch from Discrete to Integrated GPU, the msaa_is_slow capability workaround as seen by the Renderer seems to not update, which causes us to use MSAA even when it should be blacklisted.

I bisected to this range

https://chromium.googlesource.com/chromium/src/+log/05c0673d05e9338eafd256a55f9ee1b6f1281c68..f1ad8db58cca6785ab803afcd57c6415e62e47ec

Suspected changes is "cc: fix for MSAA veto." https://chromium.googlesource.com/chromium/src/+/4b04a623b3af961b6284755050add2395e1d46f6.

However that was just a fix which expanded the cases in which we turn on MSAA after RecordDrawOp landed, so it is necessary to bisect further back to see when MSAA stopped working on Intel.

senorblanco@ is there a way to force MSAA raster mode even when content has no complex paths?
Unfortunately MSAA veto was broken at r464809 and fixed at r471929.  Somewhere in this range MSAA raster on Intel got broken, so we need to bisect that range with the MSAA veto forced on.
Yes the repro credit has to be given to manoranjanr@, it was him who reproduced the issue.
Blocking: 713854
Apologies for the mix-up before manoranjanr@.

Digging further with ericrk@, it looks like the regression is caused by the 'avoid_stencil_buffers' workaround originally landed at r470712, and then expanded at r487997.

We currently think the expansion at r487997 could cause the 'avoid_stencil_buffers' and 'msaa_is_slow' workarounds to disagree, causing the bug.  The expansion was reverted at 46f405d.

It's not clear to me if the original issue is still reproducible after that revert, but we're going to make changes to ensure avoid_stencil_buffers & msaa_is_slow agree, then re-land r487997.
Labels: -ReleaseBlock-Stable ReleaseBlock-Dev
This is an RB-Dev, not an RB-Stable.  I can't use Sheets or our crash tooling right now, can repro on demand.

Here's my about://gpu per request:

Graphics Feature Status
Canvas: Hardware accelerated
CheckerImaging: Disabled
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Hardware accelerated
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
adjust_src_dst_region_for_blitframebuffer
avoid_stencil_buffers
decode_encode_srgb_for_generatemipmap
disable_framebuffer_cmaa
disable_multimonitor_multisampling
get_frag_data_info_bug
needs_offscreen_buffer_workaround
pack_parameters_workaround_with_pack_buffer
regenerate_struct_names
remove_invariant_and_centroid_for_essl3
scalarize_vec_and_mat_constructor_args
set_zero_level_before_generating_mipmap
unfold_short_circuit_as_ternary_operation
unpack_alignment_workaround_with_unpack_buffer
unpack_overlapping_rows_separately_unpack_buffer
use_intermediary_for_copy_texture_image
use_unused_standard_shared_blocks
Problems Detected
Work around a bug in offscreen buffers on NVIDIA GPUs on Macs: 89557
Applied Workarounds: needs_offscreen_buffer_workaround
Multisampling is buggy on OSX when multiple monitors are connected: 237931
Applied Workarounds: disable_multimonitor_multisampling
Unfold short circuit on Mac OS X: 307751
Applied Workarounds: unfold_short_circuit_as_ternary_operation
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
Mac drivers handle struct scopes incorrectly: 403957
Applied Workarounds: regenerate_struct_names
glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499
Applied Workarounds: set_zero_level_before_generating_mipmap
Pack parameters work incorrectly with pack buffer bound: 563714
Applied Workarounds: pack_parameters_workaround_with_pack_buffer
Alignment works incorrectly with unpack buffer bound: 563714
Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer
copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777
Applied Workarounds: use_intermediary_for_copy_texture_image
Unpacking overlapping rows from unpack buffers is unstable on NVIDIA GL driver: 596774
Applied Workarounds: unpack_overlapping_rows_separately_unpack_buffer
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
glGetFragData{Location|Index} works incorrectly on Max: 638340
Applied Workarounds: get_frag_data_info_bug
Decode and encode before generateMipmap for srgb format textures on macosx: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Insert statements to reference all members in unused std140/shared blocks on Mac: 618464
Applied Workarounds: use_unused_standard_shared_blocks
adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740
Applied Workarounds: adjust_src_dst_region_for_blitframebuffer
Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129
Applied Workarounds: remove_invariant_and_centroid_for_essl3
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
Certain Apple devices leak stencil buffers: 713854
Applied Workarounds: avoid_stencil_buffers
Checker-imaging has been disabled via finch trial or the command line.
Disabled Features: checker_imaging
Version Information
Data exported	8/2/2017, 9:49:02 AM
Chrome version	Chrome/61.0.3163.25
Operating system	Mac OS X 10.12.6
Software rendering list version	13.10
Driver bug list version	10.20
ANGLE commit id	0d2ecb4ea992
2D graphics backend	Skia/61 20ea7747f0db83718af1affd8bb72881f85ab0f7-
Command Line	/Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --enable-experimental-web-platform-features --enable-password-generation --enable-webfonts-intervention-v2=disabled --enable-features=enable-manual-password-generation,enable-password-force-saving --flag-switches-end
Driver Information
Initialization time	34
In-process GPU	false
Passthrough Command Decoder	false
Supports overlays	false
Sandboxed	true
GPU0	VENDOR = 0x10de, DEVICE= 0x0fe9 *ACTIVE*
GPU1	VENDOR = 0x8086, DEVICE= 0x0d26
Optimus	true
Optimus	true
AMD switchable	false
Driver vendor	
Driver version	10.17.5 355.10.05.45f01
Driver date	
Pixel shader version	4.10
Vertex shader version	4.10
Max. MSAA samples	8
Machine model name	MacBookPro
Machine model version	11.3
GL_VENDOR	NVIDIA Corporation
GL_RENDERER	NVIDIA GeForce GT 750M OpenGL Engine
GL_VERSION	4.1 NVIDIA-10.17.5 355.10.05.45f01
GL_EXTENSIONS	GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
Disabled Extensions	GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor	
Window system binding version	
Window system binding extensions	
Direct rendering	Yes
Reset notification strategy	0x0000
GPU process crash count	0
Compositor Information
Tile Update Mode	Zero-copy
Partial Raster	Enabled
GpuMemoryBuffers Status
ATC	Software only
ATCIA	Software only
DXT1	Software only
DXT5	Software only
ETC1	Software only
R_8	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
R_16	Software only
RG_88	Software only
BGR_565	Software only
RGBA_4444	Software only
RGBX_8888	Software only
RGBA_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRX_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRA_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RGBA_F16	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
YVU_420	Software only
YUV_420_BIPLANAR	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
UYVY_422	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
Labels: re
r487997 needs to be reverted on the branch.
Cc: amineer@chromium.org
Thank you  vmiura@. Please revert cl listed #17 from 3163 branch ASAP. Hoping it will be a safe revert. We're planning to cut Beta RC for release tomorrow soon. Thank you.
Cc: -amineer@chromium.org
I don't need to see all the updates here.
After consulting with govind@, rather than revert r487997 on branch 3163, we'll merge https://chromium-review.googlesource.com/c/597321 after it lands in stable.

The fix in 597321 is simpler to reason that it will fix all bad combinations of the 'avoid_stencil_buffers' and 'msaa_is_slow' workarounds.
Correction to comment #20: "merge ... after it lands in trunk".
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d676a966d41ac183b4b87ae494c36f1744b048f2

commit d676a966d41ac183b4b87ae494c36f1744b048f2
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Aug 02 18:25:28 2017

Disable MSAA for slow paths if avoid_stencil_buffers workaround is set.

avoid_stencil_buffers blocks MSAA support in Skia.  If the compositor requests
MSAA surfaces, rendering will fail.

R=ericrk@chromium.org
BUG= 749438 , 713854 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I887888845a2c1ee18dbccff6e96aa6cd1eac3df2
Reviewed-on: https://chromium-review.googlesource.com/597321
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491446}
[modify] https://crrev.com/d676a966d41ac183b4b87ae494c36f1744b048f2/cc/test/test_web_graphics_context_3d.h
[modify] https://crrev.com/d676a966d41ac183b4b87ae494c36f1744b048f2/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/d676a966d41ac183b4b87ae494c36f1744b048f2/cc/trees/layer_tree_host_impl_unittest.cc

Notes on how to reproduce this issue reliably on Dev:

You must have a MBP 2013~2015 with dual GPU, with OS X < 10.13.  The Mac must be running on the discrete GPU when Chrome starts.  To do this, start another Chrome instance (e.g. Canary) and navigate to WebGL page, e.g. https://www.khronos.org/registry/webgl/sdk/demos/google/san-angeles/.

Then start Chrome Dev, and navigate to one of the affected sites like http://www.bbc.co.uk/news
Labels: Merge-Request-61
Request to merge to branch 3163.
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 branch #3163 per comment #20 and per chat with vimura@.
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 2 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fc2252e12036209627c848f18352acb0932f6a0

commit 4fc2252e12036209627c848f18352acb0932f6a0
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Aug 02 18:41:52 2017

Disable MSAA for slow paths if avoid_stencil_buffers workaround is set.

avoid_stencil_buffers blocks MSAA support in Skia.  If the compositor requests
MSAA surfaces, rendering will fail.

R=ericrk@chromium.org
TBR=vmiura@chromium.org
BUG= 749438 , 713854 

(cherry picked from commit d676a966d41ac183b4b87ae494c36f1744b048f2)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I887888845a2c1ee18dbccff6e96aa6cd1eac3df2
Reviewed-on: https://chromium-review.googlesource.com/597321
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491446}
Reviewed-on: https://chromium-review.googlesource.com/598630
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#242}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4fc2252e12036209627c848f18352acb0932f6a0/cc/test/test_web_graphics_context_3d.h
[modify] https://crrev.com/4fc2252e12036209627c848f18352acb0932f6a0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4fc2252e12036209627c848f18352acb0932f6a0/cc/trees/layer_tree_host_impl_unittest.cc

Status: Fixed (was: Assigned)
Verified fixed on 61.0.3163.29 Beta release candidate.
Blockedon: 751919
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a22805ce7eb9cd90f4eb790f70a7e5490971a28

commit 6a22805ce7eb9cd90f4eb790f70a7e5490971a28
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Aug 03 04:44:18 2017

On dual-GPU macs, blacklist MSAA for both GPUs if either is Intel

Because Skia blacklists MSAA on Intel GPUs independently from Chrome, we
can end up in situations on dual-GPU Macs where CC thinks that
MSAA is available while Skia has it blacklisted. In order to avoid
these situations, we will blacklist MSAA for both GPUs (on the
Chrome side) if we want to blacklist either.

Bug:  749438 ,  751919 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I537ef3286f1a83330c58ae8e43e7133752575509
Reviewed-on: https://chromium-review.googlesource.com/599224
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491646}
[modify] https://crrev.com/6a22805ce7eb9cd90f4eb790f70a7e5490971a28/gpu/config/gpu_driver_bug_list.json

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c6f1b992336e99b235d5908e8d77c3101cd9f22

commit 5c6f1b992336e99b235d5908e8d77c3101cd9f22
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Aug 03 04:58:51 2017

On dual-GPU macs, blacklist MSAA for both GPUs if either is Intel

Because Skia blacklists MSAA on Intel GPUs independently from Chrome, we
can end up in situations on dual-GPU Macs where CC thinks that
MSAA is available while Skia has it blacklisted. In order to avoid
these situations, we will blacklist MSAA for both GPUs (on the
Chrome side) if we want to blacklist either.

TBR=ericrk@chromium.org

(cherry picked from commit 6a22805ce7eb9cd90f4eb790f70a7e5490971a28)

Bug:  749438 ,  751919 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I537ef3286f1a83330c58ae8e43e7133752575509
Reviewed-on: https://chromium-review.googlesource.com/599224
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491646}
Reviewed-on: https://chromium-review.googlesource.com/599076
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#265}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5c6f1b992336e99b235d5908e8d77c3101cd9f22/gpu/config/gpu_driver_bug_list.json

Sign in to add a comment