New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749424 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Search button on Touch Bar flickers during page loading

Reported by tomalo.s...@gmail.com, Jul 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36

Steps to reproduce the problem:
1. Use a new MacBook with Touch Bar 
2. Open Chrome
3. Open a website

What is the expected behavior?
No flickering.

What went wrong?
The search button is flickering until the page is loaded.

Did this work before? No 

Chrome version: 60.0.3112.78  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Thanks for the Touch Bar support! :)
 

Comment 1 by meh...@chromium.org, Jul 27 2017

Cc: spqc...@chromium.org
Components: -UI UI>Browser>Touchbar
Labels: Needs-Triage-M60

Comment 3 by hdodda@chromium.org, Jul 28 2017

Cc: hdodda@chromium.org
Labels: TE-NeedsTriageFromMTV
@MTVTeam-- Could someone from MTV team look into this , as inhouse-team doesn't have the Touch MacBook.

Thanks!
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
I can't repro it, but I saw some user feedback online.

I'm pretty sure the cause is the touch bar being invalidated in each page load.
I'll see if there's an alternative
Cc: spqc...@chromium.org
 Issue 749262  has been merged into this issue.
tomalo.stuttgart@gmail.com - can you provide the URL of a site that reproduces the problem? Also, can you provide a movie that shows the flickering (e.g. using your phone to record it)?

Video of flickering on THIS page:
https://drive.google.com/open?id=0B56TFlHGg9mVTWgwajY3Mk94Tnc
Tried to attach it, but got the request too large error.
So, what is really strange, is that for a couple of days everything seemed to work fine, but here it is again. WTF?
Thanks for the video! It's a strange error, and it's especially strange that the search button is the only one affected. I'm experimenting with several different things and hopefully will be able to come up with something soon.
Have the bug also. (https://twitter.com/jnybgr/status/895636912245026817)

It seems like the flickering only happens when a network request is active, I suspect at least. Either manual reload / navigation or when something is loading on the page via AJAX makes it flicker. 
Thanks for the info, it's helpful for the investigation! The issue is that whenever the navigation status is changed, the stop/reload item gets updated to reflect that, which ends up invalidating the entire touch bar. 

I also noticed that in your tweet, you mentioned that you can't turn it off and it's bothering you. Until a solution is landed, you can remove the search button from the touch bar by going to View > Customize Touch Bar. Hope this helps!

Oh yeah, thank you! That works for the moment.  I'm actually going to delete my tweet then. 
It seems that re-arrange the position of touchbar elements in chrome is a temporarilly workaround. I placed the "new tab" button on the left hand of search button (removed search button before and reset it to default position) and till now it works for me.
Update. Flickering is back :(
Status: Started (was: Assigned)
Quick question, if you remove all of the other elements and just leave the search button there, is the flickering still there? I want to check if it has anything to do with the layout (since the search button has different layout constraints)

I'm unable to reproduce this issue on my machines so this information will be helpful. Thanks!
Labels: ReleaseBlock-Beta M-61

Comment 16 by sdy@chromium.org, Aug 14 2017

I compressed the video for posterity.
V_20170806_195109_vHDR_Auto.compressed.mp4
4.2 MB View Download
Cc: pbomm...@chromium.org
Labels: -ReleaseBlock-Beta -Pri-2 ReleaseBlock-Stable Pri-1
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccfaf09a251e8a7c752638b07ae9dd1a37156889

commit ccfaf09a251e8a7c752638b07ae9dd1a37156889
Author: spqchan <spqchan@chromium.org>
Date: Tue Aug 15 01:29:28 2017

[Mac] Remove Excessive Touch Bar Invalidates

The touch bar is updated with every page load, so that
the stop/reload button would have the proper state.

However, this causes the search button to blink frequently
in some hardware. To fix this issue, remove the excessive
invalidates and update the stop/reload item independently.

Bug:  749424 
Change-Id: I02c5dd3ea8ddf978ecab6a3e5297df8d578939c2
Reviewed-on: https://chromium-review.googlesource.com/612694
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494292}
[modify] https://crrev.com/ccfaf09a251e8a7c752638b07ae9dd1a37156889/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/ccfaf09a251e8a7c752638b07ae9dd1a37156889/chrome/browser/ui/cocoa/browser_window_touch_bar.mm

[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62.

Comment 21 by ajha@chromium.org, Aug 16 2017

I was unable to reproduce the issue on the latest beta(61.0.3163.39- which as per this issue should show the buggy behavior) using MacBook pro 10.12.6 Touchbar. Attached is the configuration this was tested with.

Requesting someone who were seeing this issue for help in verification on canary. You can download the canary from here: https://www.google.com/chrome/browser/canary.html
749424.png
968 KB View Download
Cc: ajha@chromium.org
+ajha@, could you pls verify this bug on Canary?

Comment 23 by ajha@chromium.org, Aug 21 2017

This issue doesn't seem to repro on the available Mac touchbar laptop on the build with and without fix. Hence unable to verify this.


[Bulk Edit]
URGENT - PTAL.
M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. 

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62. Thank you!

Note: We will only have 2 beta releases before Stable promotion. Plan is to cut M61 Stable RC on 08/31/17.

Labels: Merge-Request-61
Yes it's critical since it might fix an annoying bug with the Touch Bar. I tested it throughly, the risk is low
Project Member

Comment 27 by sheriffbot@chromium.org, Aug 21 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #26. Please merge ASAP. Thank you.
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 21 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eaf644e09226e96a4b5a85cfaad6c787ebd8e3e

commit 0eaf644e09226e96a4b5a85cfaad6c787ebd8e3e
Author: spqchan <spqchan@chromium.org>
Date: Mon Aug 21 21:03:27 2017

[Mac] Remove Excessive Touch Bar Invalidates

The touch bar is updated with every page load, so that
the stop/reload button would have the proper state.

However, this causes the search button to blink frequently
in some hardware. To fix this issue, remove the excessive
invalidates and update the stop/reload item independently.

(cherry picked from commit ccfaf09a251e8a7c752638b07ae9dd1a37156889)

Bug:  749424 
Change-Id: I02c5dd3ea8ddf978ecab6a3e5297df8d578939c2
Reviewed-on: https://chromium-review.googlesource.com/612694
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494292}
Reviewed-on: https://chromium-review.googlesource.com/624374
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#713}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/0eaf644e09226e96a4b5a85cfaad6c787ebd8e3e/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/0eaf644e09226e96a4b5a85cfaad6c787ebd8e3e/chrome/browser/ui/cocoa/browser_window_touch_bar.mm

Status: Fixed (was: Started)

Comment 31 by lgrey@chromium.org, Aug 22 2017

 Issue 757775  has been merged into this issue.
Labels: Hotlist-ConOps Hotlist-ConOps-Channel-Stable Hotlist-ConOps-Source-Feedback
Hi All 

I am reaching out to update that the latest Chrome beta has the fix and a request if one of you can help us verify this is fixed on latest Chrome beta version i.e., 61.0.3163.59.

Thank you in advance.

Sign in to add a comment