New issue
Advanced search Search tips

Issue 749415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

chrome dev tools won't load a cpuprofile successfully

Reported by pmue...@gmail.com, Jul 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36

Steps to reproduce the problem:
1. d/l the attached self.cpuprofile file
2. open CDT 
3. select JavaScript profiler
4. click load button, find file, click open

What is the expected behavior?
profile shown

What went wrong?
profile not shown

The UI doesn't change other than showing the profile as "loaded" in the left hand pane.  The right hand pane still displays the start/load buttons dialog.

Other profiles I generated previously seem to work fine.  This one I generated via the CDT protocol to a Node 8.1.4 process.

Did this work before? N/A 

Chrome version: 60.0.3112.78  Channel: stable
OS Version: OS X 10.12.5
Flash Version: 

Gonna try some other versions of node (v6) see if this happens there as well.
 
self.cpuprofile
85.0 KB Download

Comment 1 by pmue...@gmail.com, Jul 27 2017

Seems to have the same problem with profiling a Node 6.11.1 process.

Comment 2 by pmue...@gmail.com, Jul 27 2017

Ah, I got it.  The output of the CDT protocol provides the profile data in a result with a top-level `profile` property, with the body of the profile as the value of that property.  Stripping that layer off, was able to load fine.

I guess the confusing thing is that the profile tab did load the file, but then seemed like it was hung or something - it should probably indicate the file format was not valid.
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15daa0bbb8423b9b681d42598a8c27729386271

commit d15daa0bbb8423b9b681d42598a8c27729386271
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Aug 02 02:06:52 2017

DevTools: Show error message on corrupt CPU profile.

Bug:  749415 
Change-Id: I2c22ee57d2461c56124cf890f062cb50fec5d962
Reviewed-on: https://chromium-review.googlesource.com/591781
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491217}
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-large-tree-search.html
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times.html
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/ProfileHeader.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/ProfileType.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/d15daa0bbb8423b9b681d42598a8c27729386271/third_party/WebKit/Source/devtools/front_end/ui/confirmDialog.css

Comment 5 by alph@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment