Issue metadata
Sign in to add a comment
|
Regression: USB overlay gets chopped on permission.site after toggling into fullscreen mode.
Reported by
db...@etouch.net,
Jul 27 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3167.0 Revision 5ad9ff6c130597b324fe94e4decc5a9c64b07218-refs/heads/master@{#489499} OS: Mac(10.11.6, 10.12.1, 10.12) What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site/ (2) Click on 'Fullscreen' option then click on 'USB' option and observe overlay. Actual: USB overlay gets chopped after toggling into fullscreen mode. Expected: USB overlay should seen properly. This is a regression issue, broken in 'M-60', will soon update the other info: Good Build: 60.0.3091.0 Bad Build: 60.0.3093.0 Note: Issue is not seen on Windows and Linux OS.
,
Jul 28 2017
Draft at https://chromium-review.googlesource.com/c/590498/ . Targeting M-62. I would argue against fixing this in M-60 or M-61 at this point - the fix there would probably be different, possibly avoiding a call to KeepBubbleAnchored in ChooserBubbleUi::CreateAndShow when the browser is fullscreen should do it.
,
Jul 28 2017
Passing to tapted@ since we want a fix earlier and the cocoa path shouldn't be using ChooserBubbleUi::CreateAndShow. https://chromium-review.googlesource.com/c/590498/ would work eventually but there are concerns about VoiceOver in TableView used by the toolkit-views version of the ChooserBubble.
,
Jul 31 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/debb20bc74b633b996516e2b5859da40e2e82440 commit debb20bc74b633b996516e2b5859da40e2e82440 Author: Trent Apted <tapted@chromium.org> Date: Tue Aug 01 02:53:33 2017 Fix positioning of the Cocoa device chooser. This regressed in r469822, which corrected the way a class of bubbles detect whether the browser is fullscreen. Unfortunately, this particular bubble does not anchor properly on Mac when fullscreen was detected. The bubble should always anchor top-left (leading) so that it doesn't obscure the fullscreen bubble. Bug: 749410 , 745291 Test: At https://permission.site, click Fullscreen, then USB. The dialog should appear on-screen. Change-Id: Ieeca54305f0884cd9fe6ec3e7b1611332df08499 Reviewed-on: https://chromium-review.googlesource.com/593368 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490841} [modify] https://crrev.com/debb20bc74b633b996516e2b5859da40e2e82440/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm
,
Aug 2 2017
Just to update: Above issue is fixed on latest Canary version: 62.0.3174.0 (Official Build) on Mac OS Thanks you.
,
Aug 3 2017
Requesting merge to m61 for r490841 (this affects m60 as well, but usage should still be low there)
,
Aug 4 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ecf0129d044a4e1137afbbb9c3fab6294edbd2 commit 73ecf0129d044a4e1137afbbb9c3fab6294edbd2 Author: Trent Apted <tapted@chromium.org> Date: Fri Aug 04 02:50:03 2017 [merge-m60] Fix positioning of the Cocoa device chooser. This regressed in r469822, which corrected the way a class of bubbles detect whether the browser is fullscreen. Unfortunately, this particular bubble does not anchor properly on Mac when fullscreen was detected. The bubble should always anchor top-left (leading) so that it doesn't obscure the fullscreen bubble. Bug: 749410 , 745291 Test: At https://permission.site, click Fullscreen, then USB. The dialog should appear on-screen. TBR=tapted@chromium.org (cherry picked from commit debb20bc74b633b996516e2b5859da40e2e82440) Change-Id: Ieeca54305f0884cd9fe6ec3e7b1611332df08499 Reviewed-on: https://chromium-review.googlesource.com/593368 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490841} Reviewed-on: https://chromium-review.googlesource.com/601629 Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#305} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/73ecf0129d044a4e1137afbbb9c3fab6294edbd2/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm
,
Aug 4 2017
,
Aug 9 2017
Rechecked this issue on MAC 10.12.6 using chrome version 61.0.3163.39, merge is working as intended. Overlay is displayed fine. Screen shot attached. Adding TE-verified labels. Thanks.! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Jul 27 2017Labels: hasbisect
Owner: varkha@chromium.org
Status: Assigned (was: Unconfirmed)