New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749393 link

Starred by 2 users
Status: Fixed
Owner:
tapted@chromium.org
Closed: Jul 2017
Cc:
█ ajwong@chromium.org
wychen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

nocompile_driver.py fails when there are spaces in include paths

Project Member Reported by tapted@chromium.org, Jul 27 2017 
Chrome Version       : 61.0.3135.4
OS Version: OS X 10.12.5

What steps will reproduce the problem?
1. Get an xcode .xip which puts xcode in "/Applications/Xcode-beta 2.app/" :|

2. gn args with
  mac_sdk_path = "/Applications/Xcode-beta 2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk"

3. build chrome

What is the expected result?

compiles


What happens instead of that?

doesn't

[1/2184] ACTION //base:base_nocompile_tests_run_nocompile(//build/toolchain/mac:clang_x64)
FAILED: gen/base/callback_list_unittest_nc.cc
python ../../tools/nocompile_driver.py 4 ../../base/callback_list_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../\ --sysroot\ ../../../../../../../../Applications/Xcode-beta\ 2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk gen/base/callback_list_unittest_nc.cc
clang: fatal error: no such file or directory: '2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk'

(and 6 others like this)

fix -> https://chromium-review.googlesource.com/587693

Comment 1 by wychen@chromium.org, Jul 27 2017 

Oops. Didn't think of that. Thanks for reporting and the fix!
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71169bb955009f327c971361c69f278598d82a47

commit 71169bb955009f327c971361c69f278598d82a47
Author: Trent Apted <tapted@chromium.org>
Date: Fri Jul 28 00:12:10 2017

Fix nocompile_driver.py when there are spaces in CFLAGS

To fix, retain the array-ness of the arguments rather
than concatenating strings.

Bug:  749393 
Change-Id: Icceacf14e30117da1617134e4ef6a364f9808275
Reviewed-on: https://chromium-review.googlesource.com/587693
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490147}
[modify] https://crrev.com/71169bb955009f327c971361c69f278598d82a47/build/nocompile.gni
[modify] https://crrev.com/71169bb955009f327c971361c69f278598d82a47/tools/nocompile_driver.py

Comment 3 by tapted@chromium.org, Jul 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment