New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749381 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 418901
issue 651762



Sign in to add a comment

sizes="calc(1px" should be valid

Project Member Reported by tkent@chromium.org, Jul 27 2017

Issue description

Chrome Version: 62 canary
OS: All?

What steps will reproduce the problem?
(1) Open the following URL, and wait for a while
http://w3c-test.org/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
(2) Check test results with "?f48" and "?f49"

What is the expected result?
These tests should pass.

What happens instead?
These tests fail.

Please use labels and text to provide additional information.
According to https://github.com/w3c/web-platform-tests/issues/3066, "calc(1px" should be parsed successfully.

Firefox and Edge work correctly.



 

Comment 1 by tkent@chromium.org, Jul 27 2017

Maybe a bug in css/parser/SizesCalcParser.cpp?

Status: Available (was: Untriaged)
Labels: Update-Quarterly

Comment 4 by r...@opera.com, Aug 3 2017

Owner: r...@opera.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dbf8120062e8edddc1779a3b314f2f4957610e7

commit 8dbf8120062e8edddc1779a3b314f2f4957610e7
Author: Rune Lillesveen <rune@opera.com>
Date: Sat Aug 05 10:04:37 2017

Support unclosed parentheses at end of sizes attribute.

Instead of returning false, match unclosed left-parentheses and
function tokens. Fixes eight cases in the WPT.

Bug:  749381 
Change-Id: I7b3f061ee026be1da9ab377488f83007a2a0689d
Reviewed-on: https://chromium-review.googlesource.com/599851
Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#492235}
[modify] https://crrev.com/8dbf8120062e8edddc1779a3b314f2f4957610e7/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt
[modify] https://crrev.com/8dbf8120062e8edddc1779a3b314f2f4957610e7/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

Comment 6 by r...@opera.com, Aug 6 2017

Status: Fixed (was: Started)

Sign in to add a comment