New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749380 link

Starred by 1 user
Status: Fixed
Owner:
█ tanvir.r...@samsung.com
Last visit 16 days ago
Closed: Aug 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Introduce SelectionModifier::ComputeVisibleExtent()

Project Member Reported by yosin@chromium.org, Jul 27 2017 
There are lots of
 CreateVisiblePosition(selection_.Extent(), selection_.Affinity())
in SelectionModifier.cpp, we should introduce ComputeVisibleExtent()
to reduce source code

Comment 1 by tanvir.r...@samsung.com, Jul 28 2017 

@yosin, I will take this. Thanks
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5d1c88d1850abfde51d9083a3c25f313107b51

commit 0c5d1c88d1850abfde51d9083a3c25f313107b51
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Wed Aug 02 03:18:01 2017

Introduce ComputeVisibleExtent() in SelectionModifier

Currently we have  many calls to function
CreateVisiblePosition(selection_.Extent(), selection_.Affinity())
in SelectionModifier. So to reduce the source code
introduced ComputeVisibleExtent() in SelectionModifier.cpp

BUG= 749380 

Change-Id: I31521e1d4956817131719b30f3dede21fe0221ba
Reviewed-on: https://chromium-review.googlesource.com/591727
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491247}
[modify] https://crrev.com/0c5d1c88d1850abfde51d9083a3c25f313107b51/third_party/WebKit/Source/core/editing/SelectionModifier.cpp

Comment 3 by tanvir.r...@samsung.com, Aug 8 2017

Owner: tanvir.r...@samsung.com
Status: Fixed (was: Available)
►

Sign in to add a comment