We should rename SetSelectionData to SetSelectionOptions. Because SetSelectionData is temporary name to avoid collision with enum FrameSelection::SetSeletionOptions.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79e78cb91c393df55efe5e3e0be58a986b05c46c commit 79e78cb91c393df55efe5e3e0be58a986b05c46c Author: Shanmuga Pandi M <shanmuga.m@samsung.com> Date: Thu Aug 17 06:45:04 2017 Rename SetSelectionData to SetSelectionOptions Earlier SetSelectionData is used as temporary to avoid collision with enum FrameSelection::SetSelectionOptions. Bug: 749379 Change-Id: Ib69e118be05c065b81d04337bb127265844dcfee Reviewed-on: https://chromium-review.googlesource.com/603574 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#495094} [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/dom/Range.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/DOMSelection.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/Editor.h [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/InputMethodController.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/SelectionController.cpp [delete] https://crrev.com/59d1f58c4397b2c470852da0cca779194f2bd79a/third_party/WebKit/Source/core/editing/SetSelectionData.cpp [add] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/SetSelectionOptions.cpp [rename] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/SetSelectionOptions.h [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp [modify] https://crrev.com/79e78cb91c393df55efe5e3e0be58a986b05c46c/third_party/WebKit/Source/core/html/TextControlElement.cpp
Comment 1 by shanmug...@samsung.com
, Aug 7 2017Status: Assigned (was: Available)