New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

BrowsingDataBridgeTest deleting tests are flaky

Project Member Reported by aelias@chromium.org, Jul 27 2017

Issue description

Comment 1 by aelias@chromium.org, Jul 28 2017

Reverting culprit CL in https://chromium-review.googlesource.com/c/590770/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 29 2017

Status: Fixed (was: Assigned)
Marking fixed for now, I assume they can be deflaked before relanding.
Cc: aelias@chromium.org
Owner: dullweber@chromium.org
Status: Started (was: Fixed)
Thanks for reverting the flaky test. 

I created a CL to reland the test and added some code to remove action that are not related to ClearBrowsingData. This should avoid flakes from random features getting triggered during the test.
https://chromium-review.googlesource.com/c/596974/1..3

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0cf30f11cc109548a57313a17d69423465d88bb

commit f0cf30f11cc109548a57313a17d69423465d88bb
Author: Christian Dullweber <dullweber@chromium.org>
Date: Tue Aug 08 09:56:17 2017

Reland "Expose Add/RemoveActionCallback to java"

Revert http://crrev.com/c/590770 to reland the 
BrowsingDataBridgeTest. 

To prevent flakes from random actions getting triggered
during BrowsingDataBridge::clearBrowsingData, actions that 
are unrelated to ClearBrowsingdata are filtered.

Bug:  749373 
Change-Id: Ib1d51e170d0e810db914da8eb914cb1227274bf2
Reviewed-on: https://chromium-review.googlesource.com/596974
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492580}
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/base/BUILD.gn
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/base/android/java/src/org/chromium/base/metrics/RecordUserAction.java
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/base/android/record_user_action.cc
[add] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/base/test/android/javatests/src/org/chromium/base/test/util/UserActionTester.java
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/chrome/android/java_sources.gni
[modify] https://crrev.com/f0cf30f11cc109548a57313a17d69423465d88bb/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataBridgeTest.java

Sign in to add a comment