X button should only clear query |
|||||||
Issue descriptionClicking/touching the x button should clear the text and keep the searchbox active. This should trigger a change from FULLSCREEN_SEARCH to FS_ALL_APPS and HALF to PEEKING. Also, the x button should have an A11y announcement Backspace clearing the last character should act the same as X button.
,
Jul 27 2017
Sure. The description isn't quite right. Clicking/touching the x button should clear the text and keep the searchbox active. This should trigger a change from FULLSCREEN_SEARCH to FS_ALL_APPS and HALF to PEEKING. Also, the x button should have an A11y announcement (if it doesn't already). LMK if you are going to try to get a string into 61 for this button and I'll put it with my string CL.
,
Jul 27 2017
Thanks for confirmation. Currently, when x button is selected, it notifies an accessibility event (https://cs.chromium.org/chromium/src/ui/app_list/views/search_box_view.cc?q=search_box_view.cc&dr&l=121). It seems not to be x button specific event.
,
Jul 27 2017
When X button is selected chrome vox just says "Button" which is not a very informative announcement.
,
Jul 27 2017
Perhaps we should annound 'Erase button' or similar thing. I saw you are working on 749685, I think these two bugs have no conflicts.
,
Jul 27 2017
I'm adding the string which should be used for this button in vox in bug 749685. We can create a new bug for the A11y notification and block that one instead?
,
Jul 27 2017
We already have enough bugs, let me just modify the description for this bug and make it blocked on bug 749685
,
Jul 27 2017
,
Jul 27 2017
,
Jul 27 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02ca96925ccb743e83ad34bee8595e4a6eec8443 commit 02ca96925ccb743e83ad34bee8595e4a6eec8443 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Aug 02 01:54:34 2017 cros: X button should only clear query Changes: 1. Clicking/touching the x button should clear the text and keep the searchbox active. 2. Backspace clearing the last character should act the same as X button. 3. Add unit tests for this behavior change. BUG= 749361 TEST= SearchBoxViewFullscreenTest.CloseButtonInvisibleByDefault SearchBoxViewFullscreenTest.CloseButtonVisibleAfterTyping SearchBoxViewFullscreenTest.SearchBoxEmptyAfterCloseButtonClicked SearchBoxViewFullscreenTest.SearchBoxActiveAfterCloseButtonClicked Change-Id: I6ad303bd222996c1aad343c17c08fb17f5667318 Reviewed-on: https://chromium-review.googlesource.com/595256 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491203} [modify] https://crrev.com/02ca96925ccb743e83ad34bee8595e4a6eec8443/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/02ca96925ccb743e83ad34bee8595e4a6eec8443/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/02ca96925ccb743e83ad34bee8595e4a6eec8443/ui/app_list/views/contents_view.cc [modify] https://crrev.com/02ca96925ccb743e83ad34bee8595e4a6eec8443/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/02ca96925ccb743e83ad34bee8595e4a6eec8443/ui/app_list/views/search_box_view_unittest.cc
,
Aug 3 2017
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af30573bc34b54d0b2adbf7d14dba1403757caf3 commit af30573bc34b54d0b2adbf7d14dba1403757caf3 Author: Maajid <maajid@chromium.org> Date: Thu Aug 03 22:33:59 2017 cros: X button should only clear query Changes: 1. Clicking/touching the x button should clear the text and keep the searchbox active. 2. Backspace clearing the last character should act the same as X button. 3. Add unit tests for this behavior change. BUG= 749361 TEST= SearchBoxViewFullscreenTest.CloseButtonInvisibleByDefault SearchBoxViewFullscreenTest.CloseButtonVisibleAfterTyping SearchBoxViewFullscreenTest.SearchBoxEmptyAfterCloseButtonClicked SearchBoxViewFullscreenTest.SearchBoxActiveAfterCloseButtonClicked TBR=weidongg@chromium.org (cherry picked from commit 02ca96925ccb743e83ad34bee8595e4a6eec8443) Change-Id: I6ad303bd222996c1aad343c17c08fb17f5667318 Reviewed-on: https://chromium-review.googlesource.com/595256 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491203} Reviewed-on: https://chromium-review.googlesource.com/600821 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#296} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/af30573bc34b54d0b2adbf7d14dba1403757caf3/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/af30573bc34b54d0b2adbf7d14dba1403757caf3/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/af30573bc34b54d0b2adbf7d14dba1403757caf3/ui/app_list/views/contents_view.cc [modify] https://crrev.com/af30573bc34b54d0b2adbf7d14dba1403757caf3/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/af30573bc34b54d0b2adbf7d14dba1403757caf3/ui/app_list/views/search_box_view_unittest.cc
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by weidongg@chromium.org
, Jul 27 2017