General tracking bug for Onion Soup effort for Presentation API.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1 commit 4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1 Author: Derek Cheng <imcheng@chromium.org> Date: Tue Oct 10 01:05:54 2017 [Presentation API] Remove PresentationConnectionProxy. This patch moves the logic of PresentationConnectionProxy into Blink PresentationConnection. To do this, we create subclasses of PresentatonConnection for controllers/receivers to override certain behaviors (such as Terminate), and introduce temporary WebPresentation* APIs so that the mojo connections can be initialized from PresentationDispatcher. Note that this patch is a prequisite for moving Close/Terminate from PresentationService Mojo API into PresentationConnection. Bug: 749327 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: If3a92558bf57b2e550e5ef141244864f4fa49e4f Reviewed-on: https://chromium-review.googlesource.com/597089 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Anton Vayvod <avayvod@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#507560} [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/chrome/browser/media/router/browser_presentation_connection_proxy.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/chrome/browser/media/router/test_helper.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/BUILD.gn [delete] https://crrev.com/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a/content/renderer/presentation/presentation_connection_proxy.cc [delete] https://crrev.com/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a/content/renderer/presentation/presentation_connection_proxy.h [delete] https://crrev.com/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a/content/renderer/presentation/presentation_connection_proxy_unittest.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/presentation/presentation_dispatcher.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/presentation/presentation_dispatcher_unittest.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/presentation/test_presentation_connection.cc [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/renderer/presentation/test_presentation_connection.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/content/test/BUILD.gn [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-postmessage.html [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/DEPS [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/MockWebPresentationClient.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnection.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationController.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationController.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/remoteplayback/DEPS [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h [delete] https://crrev.com/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionProxy.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/public/platform/modules/presentation/WebPresentationReceiver.h [modify] https://crrev.com/4de47c5566bd3b289f75e2f3cd1069cc7f9f8da1/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
Targeting M65 based on recent conversation.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ffbec53206b897830b41c3472350db28d65a8e commit f8ffbec53206b897830b41c3472350db28d65a8e Author: Derek Cheng <imcheng@chromium.org> Date: Wed Dec 06 19:43:04 2017 [PresentationAPI] Onion soup part 2. Move screen availability logic PresentationDispatcher into Blink code. A new class, blink::PresentationAvailabilityState, is introduced to keep track of the availability and listening states of PresentationAvailability objects. PresentationAvailabilityState is owned by blink::PresentationController and shares its PresentationService mojo ptr to communicate with the browser. Also rename PresentationServiceClient Mojo interface to PresentationController (in parallel with PresentationReceiver). With the rename, we also move its implementation from PresentationDispatcher into blink::PresentationController. This allows us to remove WebPresentationController and WebPresentationAvailabilityObserver. This patch also fixes a bug (which also leads to layout test flakiness) where Mojo message pipes for PresentationService/PresentationController are not removed on navigation. This is fixed by resetting the bindings and mojo ptrs in PresentationServiceImpl::Reset. We also reset the PresentationService mojo ptr in PresentationDispatcher::DidCommitProvisionalLoad as a temp fix while PresentationDispatcher still remains. Bug: 749327 , 761561 Change-Id: I8834f130fdc70879119ee81eeaf5b5965fec9098 Reviewed-on: https://chromium-review.googlesource.com/724724 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#522169} [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/renderer/presentation/presentation_dispatcher.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/content/renderer/presentation/presentation_dispatcher_unittest.cc [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/BUILD.gn [add] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/MockPresentationService.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/MockWebPresentationClient.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/Presentation.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.h [add] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityObserver.h [add] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityState.cpp [add] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityState.h [add] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityStateTest.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationConnection.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationController.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationController.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/e1d5593fe225687c9749759e01b0b389dac3a3a7/third_party/WebKit/Source/platform/exported/WebPresentationAvailabilityObserver.cpp [delete] https://crrev.com/e1d5593fe225687c9749759e01b0b389dac3a3a7/third_party/WebKit/Source/platform/exported/WebPresentationController.cpp [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/public/BUILD.gn [delete] https://crrev.com/e1d5593fe225687c9749759e01b0b389dac3a3a7/third_party/WebKit/public/platform/modules/presentation/WebPresentationAvailabilityObserver.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h [delete] https://crrev.com/e1d5593fe225687c9749759e01b0b389dac3a3a7/third_party/WebKit/public/platform/modules/presentation/WebPresentationController.h [modify] https://crrev.com/f8ffbec53206b897830b41c3472350db28d65a8e/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7cdb70dfce09be55d0f54d52df38b133a658ed9 commit f7cdb70dfce09be55d0f54d52df38b133a658ed9 Author: Derek Cheng <imcheng@chromium.org> Date: Wed Jan 31 18:52:26 2018 [PresentationAPI] Onion soup part 3. This patch removes Start/ReconnectPresentation from content/renderer presentation_dispatcher. Also removed a few WebPresentation* classes that are no longer used as a result. Bug: 749327 Change-Id: I0cddaa9822cd7924cf3afd195b71bb1a64db3cc8 Reviewed-on: https://chromium-review.googlesource.com/887927 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533341} [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/content/renderer/presentation/presentation_dispatcher.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/content/renderer/presentation/presentation_dispatcher_unittest.cc [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/content/renderer/presentation/test_presentation_connection.cc [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/content/renderer/presentation/test_presentation_connection.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/content/test/BUILD.gn [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/MockWebPresentationClient.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityState.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityStateTest.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationConnection.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationController.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationError.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationError.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/remoteplayback/BUILD.gn [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackConnectionCallbacks.cpp [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackConnectionCallbacks.h [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/Source/platform/exported/WebPresentationConnectionCallbacks.cpp [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/f7cdb70dfce09be55d0f54d52df38b133a658ed9/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionCallbacks.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/public/platform/modules/presentation/WebPresentationError.h [delete] https://crrev.com/b7591fb63d6d4cd7f30792256ac31e18c636e49c/third_party/WebKit/public/platform/modules/presentation/WebPresentationInfo.h
Derek - is there any work left here?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb973caf3a9d6a48647f7059f3a2500e2095bd1 commit 3eb973caf3a9d6a48647f7059f3a2500e2095bd1 Author: Derek Cheng <imcheng@chromium.org> Date: Mon Apr 23 19:10:17 2018 [Presentation API] Final onion soup. This patch removes PresentationDispatcher and related WebPresentation* interfaces. PresentationReceiver now eagerly connects to PresentationService, instead of waiting on document load signal, which isn't available in Blink and is not necessary. PresentationReceiver itself remains eagerly created, which causes some existing assumptions to be broken on the browser side, but should be fixable with further browser-side refactoring (added TODO). Also reverts the BindingSet in PresentationServiceImpl back to a single Binding since PresentationDispatcher no longer exists. Bug: 749327 Change-Id: Ic8296471491088da283450a05a620005b2668ba4 Reviewed-on: https://chromium-review.googlesource.com/961525 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#552782} [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/content/renderer/BUILD.gn [delete] https://crrev.com/366a4d4fea7f89eda89c9621547fe07b7a7ac597/content/renderer/presentation/OWNERS [delete] https://crrev.com/366a4d4fea7f89eda89c9621547fe07b7a7ac597/content/renderer/presentation/presentation_dispatcher.cc [delete] https://crrev.com/366a4d4fea7f89eda89c9621547fe07b7a7ac597/content/renderer/presentation/presentation_dispatcher.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/content/renderer/render_frame_impl.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/content/renderer/render_frame_impl.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/public/BUILD.gn [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/public/web/web_frame_client.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/BUILD.gn [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/modules_initializer.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_availability.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_connection.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_connection.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_controller.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_controller.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_receiver.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_receiver.h [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/presentation/presentation_receiver_test.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/modules/remoteplayback/remote_playback_test.cc [modify] https://crrev.com/3eb973caf3a9d6a48647f7059f3a2500e2095bd1/third_party/blink/renderer/platform/BUILD.gn
Assuming the final patch sticks (Fingers crossed), I think we can close this one out.
Comment 1 by imch...@chromium.org
, Jul 26 2017Status: Started (was: Untriaged)