New issue
Advanced search Search tips

Issue 749317 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK failing after using system print dialog

Project Member Reported by rbpotter@chromium.org, Jul 26 2017

Issue description

Chrome Version: 60.0.3112.0, 62.0.3167.0 (debug builds)
OS: Win10 (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Open print preview on any webpage
(2) Click "Print with system dialog"
(3) Once system dialog appears, cancel
(4) At some point, close Chrome

What is the expected result?
Clean close

What happens instead?
Hit DCHECK in profile_destroyer.cc line 56

Check failed: hosts.empty() || profile->IsOffTheRecord() || content::RenderProcessHost::run_renderer_in_process(). Profile still has one hosts.
 
Owner: rbpotter@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8af63508c00ae56acbb3bc63c0d291b7bd0fb74

commit b8af63508c00ae56acbb3bc63c0d291b7bd0fb74
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Aug 09 18:29:06 2017

Print Preview: Clean up preview on system dialog cancel (Windows only)

Printing from the system dialog link on Windows causes the preview to
hide. The print preview is stored in the background printing manager
until the print job is reported complete. If this does not occur, the
print preview will never be removed and a DCHECK will be triggered
when the browser is closed. Inform the print view manager when the
system dialog is cancelled so that things can be cleaned up correctly.

Bug:  749317 
Change-Id: I993e713f5da0a16b2d20147dd3377db28090ff1e
Reviewed-on: https://chromium-review.googlesource.com/591991
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493059}
[modify] https://crrev.com/b8af63508c00ae56acbb3bc63c0d291b7bd0fb74/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/b8af63508c00ae56acbb3bc63c0d291b7bd0fb74/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/b8af63508c00ae56acbb3bc63c0d291b7bd0fb74/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/b8af63508c00ae56acbb3bc63c0d291b7bd0fb74/chrome/browser/printing/printing_message_filter.h

Status: Fixed (was: Started)

Sign in to add a comment