New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749304 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Bail out of updating data points if an error is encountered in flake swarming tasks and retry

Project Member Reported by lijeffrey@chromium.org, Jul 26 2017

Issue description

TypeError: unsupported operand type(s) for *: 'float' and 'NoneType'
at Merge (/base/data/home/apps/s~findit-for-me/waterfall-backend:10909-fba6c55.402923779948242132/model/flake/master_flake_analysis.py:134)
at AppendOrMergeDataPoint (/base/data/home/apps/s~findit-for-me/waterfall-backend:10909-fba6c55.402923779948242132/model/flake/master_flake_analysis.py:354)
at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:10909-fba6c55.402923779948242132/waterfall/flake/update_flake_analysis_data_points_pipeline.py:114)
at _run_internal (/base/data/home/apps/s~findit-for-me/waterfall-backend:10909-fba6c55.402923779948242132/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py:1113)
at evaluate (/base/data/home/apps/s~findit-for-me/waterfall-backend:10909-fba6c55.402923779948242132/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py:2158)

The root cause is a flake swarming task ended in error, causing a data point with None as iterations to be saved. When trying to merge a new data point, None was multipled by the passrate leading to this error.

We should not save data points for tasks that ended in error.

Tasks that end in error should be retried.
 
Status: WontFix (was: Assigned)
The original CL was reverted

Sign in to add a comment