cros-go.eclass: src_install should verify that all dependencies CROS_GO_PACKAGES are installed |
||||||
Issue descriptioncros-go_src_install installs the Go packages listed in CROS_GO_PACKAGES to the system-wide GOPATH (/usr/lib/gopath). It does not verify that any dependencies of those packages are also installed. It can cause confusion when a package "a" is in CROS_GO_PACKAGES, but its dependency "b" is not. src_install succeeds without detecting this. When another package (from a different ebuild) imports "a", this missing dependency is detected and results in a compile error. See https://chromium-review.googlesource.com/#/c/577959 for example.
,
Jul 31 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks!
,
Feb 15 2018
Reopening due to https://bugs.chromium.org/p/chromium/issues/detail?id=811542 Will disable the dependency checking as a workaround shortly.
,
Feb 16 2018
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9eb388ebf3e16a1e7c318877acdf9f3def4aff29 commit 9eb388ebf3e16a1e7c318877acdf9f3def4aff29 Author: Allen Li <ayatane@chromium.org> Date: Wed Feb 21 04:31:33 2018 cros-go: Disable dependency checking to work around bug BUG= chromium:749300 BUG= chromium:811542 TEST=None Change-Id: I2c3aa51acdda2f8eac11e0b768927008b5ab8e09 Reviewed-on: https://chromium-review.googlesource.com/924601 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> [modify] https://crrev.com/9eb388ebf3e16a1e7c318877acdf9f3def4aff29/eclass/cros-go.eclass
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9e1773bfe328a505b61f3cb5bc297d4d3b2e759d commit 9e1773bfe328a505b61f3cb5bc297d4d3b2e759d Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Thu Jul 05 01:24:27 2018 cros-go.eclass: check for missing dependencies of installed packages. Moved dependency checking to pkg_postinst stage. BUG= chromium:749300 BUG= chromium:811542 TEST='sudo emerge dev-go/grpc-credentials-oauth' works. TEST=Emerged dev-go/* (50 ebuilds). Change-Id: Idd9182c40da5dedb9741c081dc2c7c58171e13a9 Reviewed-on: https://chromium-review.googlesource.com/1124668 Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org> Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> [modify] https://crrev.com/9e1773bfe328a505b61f3cb5bc297d4d3b2e759d/eclass/cros-go.eclass
,
Jul 6
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 29 2017