New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749296 link

Starred by 2 users
Status: Verified
Owner:
dbeam@chromium.org
Closed: Jul 2017
Cc:
mkarkada@chromium.org
█ dschuyler@chromium.org
dhadd...@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove obsolete chrome://md-settings host name

Project Member Reported by dpa...@chromium.org, Jul 26 2017 
chrome://md-settings was useful to be able to display both old and new settings side by side.

Since old settings are no longer runnable, and since chrome://settings points to the MD Settings page, there is no need for the chrome://md-settings host name.

Let's remove it.

Comment 1 by dbeam@chromium.org, Jul 26 2017

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a

commit e8db841a94bfea7e6ffd5d1f1579ec101ebf974a
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jul 28 00:33:52 2017

Remove chrome://md-settings host in favor of just chrome://settings

chrome://md-settings was the URL developers used to test locally and in
browser tests and stuff.  It was never really encouraged to be used by
users.

Bug:  749296 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3f8b330756f92accbc1ecf2f2cd9bdaf2469ac92
Reviewed-on: https://chromium-review.googlesource.com/588079
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490164}
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/resources/settings/printing_page/cloud_printers.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/ui/webui/settings/md_settings_ui.h
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
[delete] https://crrev.com/2ae783af6398cb95a5bd45c2f70754f5c9bbf85c/chrome/browser/ui/webui/settings/md_settings_ui_unittest.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/common/url_constants.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/common/url_constants.h
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/BUILD.gn
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/polymer_browser_test_base.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/animation_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/search_settings_test.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/settings_idle_load_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/settings_page_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/components/safe_browsing/common/safe_browsing_prefs.h
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/extensions/browser/api/networking_private/networking_private_chromeos_unittest.cc
[modify] https://crrev.com/e8db841a94bfea7e6ffd5d1f1579ec101ebf974a/extensions/common/api/_api_features.json

Comment 3 by dbeam@chromium.org, Jul 28 2017

Status: Fixed (was: Started)

Comment 4 by mkarkada@chromium.org, Aug 9 2017

Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: WontFix (was: Fixed)
This option is no more available.
Checked on Chrome OS 9824.0.0, 62.0.3176.0 dev build.

Comment 5 by dbeam@chromium.org, Aug 10 2017

Status: Verified (was: WontFix)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0390e2d1bac9aae3c433a4bf5a93ebef20488579

commit 0390e2d1bac9aae3c433a4bf5a93ebef20488579
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Sep 19 01:06:40 2017

Remove lingering use of deprecated md-settings hostname from tests

R=dpapad@chromium.org
BUG= 749296 , 761258 

Change-Id: I214b60157dc8eb7bcda1d214b8433f003aad8bb6
Reviewed-on: https://chromium-review.googlesource.com/669683
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502745}
[modify] https://crrev.com/0390e2d1bac9aae3c433a4bf5a93ebef20488579/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js
[modify] https://crrev.com/0390e2d1bac9aae3c433a4bf5a93ebef20488579/chrome/test/data/webui/settings/cr_settings_browsertest.js
►

Sign in to add a comment