Night Light custom schedule slider ignores 24-hour time setting |
|||||||
Issue descriptionThe Night Light custom schedule slider is displaying 12-hour times and labels even though my system is configured to display 24-hour times.
,
Jul 26 2017
let us look into updating the logic to reflect your system's time format. thanks for catching that!
,
Jul 27 2017
Thanks for filing this! I think I was just following the mocks.
,
Jul 27 2017
,
Jul 28 2017
Demo:
,
Jul 28 2017
nice! thanks much Ahmed ;)
,
Jul 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9273eec5071b984031165255abe832e1d5f58753 commit 9273eec5071b984031165255abe832e1d5f58753 Author: Ahmed Fakhry <afakhry@google.com> Date: Sat Jul 29 03:44:27 2017 [Night Light][MD-settings]: Night Light slider should respect 24-hour setting Make the Night Light slider respect the 24-hour time format setting and format times shown in knobs label bubbles and legends accordingly. screenshot: https://screenshot.googleplex.com/09rZyfHxdzx.png BUG= 749288 TEST=manually, closure compiler. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb99b0b32029f7c047700ad82258583017439a16 Reviewed-on: https://chromium-review.googlesource.com/590177 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#490609} [modify] https://crrev.com/9273eec5071b984031165255abe832e1d5f58753/chrome/browser/resources/settings/device_page/night_light_slider.html [modify] https://crrev.com/9273eec5071b984031165255abe832e1d5f58753/chrome/browser/resources/settings/device_page/night_light_slider.js [modify] https://crrev.com/9273eec5071b984031165255abe832e1d5f58753/chrome/test/data/webui/settings/device_page_tests.js
,
Jul 31 2017
,
Jul 31 2017
Approving merge to M61 Chrome OS.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/382bdac3d5bcadfff9714e1ab79a4d0b841a657f commit 382bdac3d5bcadfff9714e1ab79a4d0b841a657f Author: Ahmed Fakhry <afakhry@google.com> Date: Mon Jul 31 23:27:29 2017 [Merge to M61][Night Light][MD-settings]: Night Light slider should respect 24-hour setting Make the Night Light slider respect the 24-hour time format setting and format times shown in knobs label bubbles and legends accordingly. screenshot: https://screenshot.googleplex.com/09rZyfHxdzx.png TBR=stevenjb@chromium.org BUG= 749288 TEST=manually, closure compiler. (cherry picked from commit 9273eec5071b984031165255abe832e1d5f58753) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb99b0b32029f7c047700ad82258583017439a16 Reviewed-on: https://chromium-review.googlesource.com/590177 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490609} Reviewed-on: https://chromium-review.googlesource.com/595152 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#199} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/382bdac3d5bcadfff9714e1ab79a4d0b841a657f/chrome/browser/resources/settings/device_page/night_light_slider.html [modify] https://crrev.com/382bdac3d5bcadfff9714e1ab79a4d0b841a657f/chrome/browser/resources/settings/device_page/night_light_slider.js [modify] https://crrev.com/382bdac3d5bcadfff9714e1ab79a4d0b841a657f/chrome/test/data/webui/settings/device_page_tests.js
,
Jul 31 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by derat@chromium.org
, Jul 26 2017