New issue
Advanced search Search tips

Issue 749275 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature
Proj-Servicification

Blocked on:
issue 740740

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Make FileReader no longer create blob URLs, but instead read blobs directly

Project Member Reported by mek@chromium.org, Jul 26 2017

Issue description

With mojo blobs FileReader can just read the blob directly without having to create a blob URL for it first, so we should update FileReader to actually work that way.
 

Comment 1 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 3 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/704dd51b37b79941c6bdafb243e66a40691ad707

commit 704dd51b37b79941c6bdafb243e66a40691ad707
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Nov 28 10:47:01 2017

Make FileReader use mojo Blob interface.

This significantly speeds up the FileReader API because we no longer
have all the overhead of creating a blob URL and going through the whole
network stack.

Bug:  749275 
Change-Id: Ie45d782d60caafc7f94ea6cb21cf5969b9a07101
Reviewed-on: https://chromium-review.googlesource.com/587710
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519644}
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/storage/browser/blob/mojo_blob_reader.cc
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/PerformanceTests/TestData/simple-blob-measure-async.html
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/third_party/WebKit/Source/platform/blob/BlobData.h
[modify] https://crrev.com/704dd51b37b79941c6bdafb243e66a40691ad707/tools/perf/benchmarks/blink_perf_unittest.py

Comment 5 by mek@chromium.org, Jan 10 2018

Status: Fixed (was: Started)

Sign in to add a comment