Want to take this on as part of your Android cleanup work? "Before Yipeng finished his internship, he managed to remove all calls to RegisterNativesImpl() from the chrome/ directory. However, there are still 145 of them remaining in other directories. If you love deleting chromium code, please claim a directory (or multiple). Tracker: https://docs.google.com/spreadsheets/d/1j1U41m58GJ7rcV5HI7ZzowGDqRbSokUNqjIHsfmCm2k/edit#gid=0 Example commit: https://chromium-review.googlesource.com/c/575818/"
media/ list: https://cs.chromium.org/search/?q=RegisterNativesImpl+-file:jni_generator+file:%5C.c+file:%5Esrc/media&type=cs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be30b6a5d90806a0215e623ecd2d850d93208459 commit be30b6a5d90806a0215e623ecd2d850d93208459 Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Aug 25 13:27:58 2017 Delete RegisterNativesImpl() from //media They are all no-ops. Bug: 749264 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3a0a2824afa82f2a5be721b661972ce4f620ef8d Reviewed-on: https://chromium-review.googlesource.com/633749 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#497389} [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_manager_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_record_input.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_record_input.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_track_output_stream.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/audio/android/audio_track_output_stream.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/BUILD.gn [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_drm_bridge.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_drm_bridge.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_drm_storage_bridge.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_drm_storage_bridge.h [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/base/android/media_jni_registrar.cc [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/base/android/media_jni_registrar.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_player_bridge.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_player_bridge.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_player_listener.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_player_listener.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_server_crash_listener.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/base/android/media_server_crash_listener.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/blink/run_all_unittests.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/content/android/BUILD.gn [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/capture/content/android/screen_capture_jni_registrar.cc [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/capture/content/android/screen_capture_jni_registrar.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/content/android/screen_capture_machine_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/content/android/screen_capture_machine_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/video/android/BUILD.gn [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/capture/video/android/capture_jni_registrar.cc [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/capture/video/android/capture_jni_registrar.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/video/android/video_capture_device_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/video/android/video_capture_device_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/capture/video/video_capture_device_unittest.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/gpu/android/media_codec_video_decoder_unittest.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/gpu/android_video_decode_accelerator_unittest.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/BUILD.gn [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/midi_input_port_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/midi_input_port_android.h [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/midi/midi_jni_registrar.cc [delete] https://crrev.com/a678f0724e1b28964f71f489572e63f33b16efc7/media/midi/midi_jni_registrar.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/midi_manager_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/midi_manager_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/usb_midi_device_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/usb_midi_device_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/usb_midi_device_factory_android.cc [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/midi/usb_midi_device_factory_android.h [modify] https://crrev.com/be30b6a5d90806a0215e623ecd2d850d93208459/media/test/run_all_unittests.cc
Comment 1 by dalecur...@chromium.org
, Jul 26 2017