DevTools: mac-style capture area screenshot |
|||||
Issue descriptionCurrently planned as a part of inspect mode.
,
Jul 31 2017
dgozman@: Could you please provide the steps to verify the CL in C#1. Thank you!
,
Jul 31 2017
1. Open DevTools. 2. Use Ctrl+Shift+C or click the top-left button in DevTools "Select an element in the page to inspect it". 3. Hovering over the page, press Ctrl, hold left mouse button down, drag it to see a rectangular area highlighted and release mouse button (all this while holding Ctrl key). 4. DevTools should capture a screenshot of the selected rectangular area (it goes to downloads bar). 5. Check that screenshot matches the selected area.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5198fef411244b45a0aa552de1e70b3ae92b4954 commit 5198fef411244b45a0aa552de1e70b3ae92b4954 Author: Dmitry Gozman <dgozman@chromium.org> Date: Sat Aug 26 03:31:13 2017 [DevTools] Account for extra emulation scale when taking a screenshot Bug: 749252 Change-Id: I9ca9821c705dd5dec3aadc1bb5994166910e8957 Reviewed-on: https://chromium-review.googlesource.com/636752 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497648} [modify] https://crrev.com/5198fef411244b45a0aa552de1e70b3ae92b4954/content/browser/devtools/protocol/page_handler.cc
,
Aug 28 2017
Verified the fix as per the steps in C#3 on the latest canary(62.0.3198.0) on Windows-10, Mac OS 10.12.6 and Linux Ubuntu 14.04. This is working as intended, hence adding the verified label.
,
Aug 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 29 2017