New issue
Advanced search Search tips

Issue 749252 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

DevTools: mac-style capture area screenshot

Project Member Reported by dgozman@chromium.org, Jul 26 2017

Issue description

Currently planned as a part of inspect mode.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043ee6730130876aaab97aa8386afefb26ce3ac8

commit 043ee6730130876aaab97aa8386afefb26ce3ac8
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Jul 29 03:42:33 2017

[DevTools] Control+drag to capture area screenshot in Inspect Mode

This user action issues Overlay.screenshotRequested notification.
We can split this away from inspect mode, but that needs more UI surface.

Bug:  749252 
Change-Id: I518c31d943179650fb8517a4c9d1bd7b677e0dbc
Reviewed-on: https://chromium-review.googlesource.com/587396
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490608}
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.h
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js
[modify] https://crrev.com/043ee6730130876aaab97aa8386afefb26ce3ac8/third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js

Comment 2 by ajha@chromium.org, Jul 31 2017

Cc: ajha@chromium.org
Labels: Needs-Feedback
dgozman@: Could you please provide the steps to verify the CL in C#1.

Thank you!
Status: Fixed (was: Assigned)
1. Open DevTools.
2. Use Ctrl+Shift+C or click the top-left button in DevTools "Select an element in the page to inspect it".
3. Hovering over the page, press Ctrl, hold left mouse button down, drag it to see a rectangular area highlighted and release mouse button (all this while holding Ctrl key).
4. DevTools should capture a screenshot of the selected rectangular area (it goes to downloads bar).
5. Check that screenshot matches the selected area.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5198fef411244b45a0aa552de1e70b3ae92b4954

commit 5198fef411244b45a0aa552de1e70b3ae92b4954
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Aug 26 03:31:13 2017

[DevTools] Account for extra emulation scale when taking a screenshot

Bug:  749252 
Change-Id: I9ca9821c705dd5dec3aadc1bb5994166910e8957
Reviewed-on: https://chromium-review.googlesource.com/636752
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497648}
[modify] https://crrev.com/5198fef411244b45a0aa552de1e70b3ae92b4954/content/browser/devtools/protocol/page_handler.cc

Comment 5 by ajha@chromium.org, Aug 28 2017

Labels: -Needs-Feedback TE-Verified-62.0.3198.0 TE-Verified-M62
Verified the fix as per the steps in C#3 on the latest canary(62.0.3198.0) on Windows-10, Mac OS 10.12.6 and Linux Ubuntu 14.04. This is working as intended, hence adding the verified label.
749252.png
276 KB View Download

Comment 6 by kayce@google.com, Aug 28 2017

Labels: DevTools-Release-Notes-62

Sign in to add a comment