New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749251 link

Starred by 1 user
Status: Assigned
Owner:
hhli@chromium.org
Cc:
█ eostroukhov@chromium.org
adithyas@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Layout test resources-panel-websql.html flaky on WebKit Mac10.11

Project Member Reported by zakerinasab@chromium.org, Jul 26 2017 
Layout test http/tests/inspector/application-panel/resources-panel-websql.html is flaky on WebKit Mac 10.11:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/21959

Diff:

--- /b/rr/tmpnHskA2/w/layout-test-results/http/tests/inspector/application-panel/resources-panel-websql-expected.txt
+++ /b/rr/tmpnHskA2/w/layout-test-results/http/tests/inspector/application-panel/resources-panel-websql-actual.txt
@@ -38,6 +38,7 @@
   Session Storage
     http://127.0.0.1:8000
   IndexedDB
+    Database1 - http://127.0.0.1:8000
   Web SQL
     inspector-test-db (selected)
   Cookies
@@ -65,6 +66,8 @@
   Session Storage
     http://127.0.0.1:8000
   IndexedDB
+    Database1 - http://127.0.0.1:8000
+      Store1
   Web SQL
     inspector-test-db (selected)
       table1
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46557add15cad35637dc7565f0d8ba8d9d676114

commit 46557add15cad35637dc7565f0d8ba8d9d676114
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Jul 26 20:39:53 2017

Suppress resources-panel-websql.html failures on Mac 10.11

Layout test http/tests/inspector/application-panel/resources-panel-websql.html is flaky on WebKit Mac 10.11:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/21959

This change suppresses this test for now.

BUG=749251
TBR=eostroukhov@chromium.org
NOTRY=true

Change-Id: I3a8a57d3b6748a22c4ed48ea4ecd674d5247b891
Reviewed-on: https://chromium-review.googlesource.com/587424
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489744}
[modify] https://crrev.com/46557add15cad35637dc7565f0d8ba8d9d676114/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by adithyas@chromium.org, Jul 31 2017

Cc: adithyas@chromium.org
 Issue 750752  has been merged into this issue.

Comment 3 by adithyas@chromium.org, Jul 31 2017 

Looks like this test is flaky on Mac 10.9 as well, I'll update the test expectations to reflect that.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c8943d7614bec3e70874e4d8744087d0f5b20af

commit 0c8943d7614bec3e70874e4d8744087d0f5b20af
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Mon Jul 31 20:07:54 2017

Disable resources-panel-websql.html on Mac 10.9

Bug: 749251
Change-Id: I2286685ba8ae969070424d142c780851a74eeea5
Tbr: eostroukhov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/594647
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490792}
[modify] https://crrev.com/0c8943d7614bec3e70874e4d8744087d0f5b20af/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by loonyb...@chromium.org, Aug 2 2017 

Also flaky on WebKit Mac 10.10
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10

I should just disable the tests on Mac for now
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c647a330c868a8dec8914914c98cdd75dbd2a69a

commit c647a330c868a8dec8914914c98cdd75dbd2a69a
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Aug 02 19:58:45 2017

Mark resources-panel-websql.html flaky on Mac

Bug: 749251
Change-Id: I5d7ce0b08e979f861b3e560872de58ff6972bcc5
Reviewed-on: https://chromium-review.googlesource.com/598537
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <lunalu@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <lunalu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491476}
[modify] https://crrev.com/c647a330c868a8dec8914914c98cdd75dbd2a69a/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by eostroukhov@chromium.org, Aug 23 2017

Cc: eostroukhov@chromium.org
 Issue 754798  has been merged into this issue.

Comment 8 by eostroukhov@chromium.org, Dec 1 2017

Labels: Pri-3
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79610575221b0b51c90751cc8c08a9d3f03de234

commit 79610575221b0b51c90751cc8c08a9d3f03de234
Author: Will Chen <chenwilliam@chromium.org>
Date: Wed Jan 03 01:39:50 2018

DevTools: mark as not flaky resources-panel-websql.js

No longer flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fapplication-panel%2Fresources-panel-websql.js

Speculatively, because of this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/792534

TBR=eostroukhov@chromium.org

Bug: 749251
Change-Id: I91e376ad73dae38fc8ae5e960f6eddbb85a1c84f
Reviewed-on: https://chromium-review.googlesource.com/848024
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526573}
[modify] https://crrev.com/79610575221b0b51c90751cc8c08a9d3f03de234/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by dgozman@chromium.org, Oct 12

Owner: hhli@chromium.org
►

Sign in to add a comment