New issue
Advanced search Search tips

Issue 749244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 749264

Blocking:
issue 683256



Sign in to add a comment

Delete all calls to RegisterNativesImpl()

Project Member Reported by agrieve@chromium.org, Jul 26 2017

Issue description

This is a follow up to  bug 683256 . There is now a lot of dead code for functions that call RegisterNativesImpl(). We should delete them all and stop generating the empty function.

 
Blockedon: 749264
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ad58be82c97af26cada46f4a646c3360c0ad908

commit 9ad58be82c97af26cada46f4a646c3360c0ad908
Author: Nate Fischer <ntfschr@chromium.org>
Date: Thu Jul 27 23:45:07 2017

Android: remove JNI registration from safe_browsing_db

This cleans up unnecessary JNI registration from
components/safe_browsing_db/. This code is no longer needed due to a
change in how JNI registration works.

Bug:  749244 
Test: manual - run chrome_apk & chrome_modern_apk & verify no crash when browsing and creating interstitials
Change-Id: If2dcb57aec2357ca6a0ebb1f8b426021cfcd8a11
Reviewed-on: https://chromium-review.googlesource.com/588367
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490125}
[modify] https://crrev.com/9ad58be82c97af26cada46f4a646c3360c0ad908/components/safe_browsing_db/BUILD.gn
[delete] https://crrev.com/1b48505c7181eea03f3b9ad0a8d6ced5c6998661/components/safe_browsing_db/android/jni_registrar.cc
[delete] https://crrev.com/1b48505c7181eea03f3b9ad0a8d6ced5c6998661/components/safe_browsing_db/android/jni_registrar.h
[modify] https://crrev.com/9ad58be82c97af26cada46f4a646c3360c0ad908/components/safe_browsing_db/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/9ad58be82c97af26cada46f4a646c3360c0ad908/components/safe_browsing_db/android/safe_browsing_api_handler_bridge.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2285f057eab1853f115cccc367fac75ffd963148

commit 2285f057eab1853f115cccc367fac75ffd963148
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Fri Jul 28 07:50:18 2017

Remove all RegisterNativesImpl() in android_webview/

Bug:  749244 
Change-Id: Ie459e247d0d779b09357d9a7b26eed5b8d157fb0
Reviewed-on: https://chromium-review.googlesource.com/588084
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490313}
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/BUILD.gn
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/android_protocol_handler.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/android_protocol_handler.h
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/android_webview_jni_registrar.cc
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/android_webview_jni_registrar.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents_client_bridge.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents_client_bridge.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents_client_bridge_unittest.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_debug.cc
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/aw_debug.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_devtools_server.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_devtools_server.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_form_database.cc
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/aw_form_database.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_gl_functor.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_gl_functor.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_http_auth_handler.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_http_auth_handler.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_metrics_service_client.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_pdf_exporter.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_pdf_exporter.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_picture.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_picture.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_quota_manager_bridge.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_settings.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/aw_web_contents_delegate.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/cookie_manager.cc
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/cookie_manager.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/permission/aw_permission_request.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/permission/aw_permission_request.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/popup_touch_handle_drawable.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/popup_touch_handle_drawable.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/browser/token_binding_manager_bridge.cc
[delete] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/token_binding_manager_bridge.h
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/lib/webview_jni_onload.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/lib/webview_tests.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/test/embedded_test_server/BUILD.gn
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/test/embedded_test_server/aw_embedded_test_server.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/test/embedded_test_server/aw_test_entry_point.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/test/embedded_test_server/aw_test_jni_onload.cc
[modify] https://crrev.com/2285f057eab1853f115cccc367fac75ffd963148/android_webview/test/embedded_test_server/aw_test_jni_onload.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7dc0cc0596942d26b34d42474be07dbef8fc5b

commit 1f7dc0cc0596942d26b34d42474be07dbef8fc5b
Author: Bo Liu <boliu@chromium.org>
Date: Fri Jul 28 18:58:57 2017

android: Remove manual jni registration in content

All generated RegisterNativesImpl functions are no-op already. Remove
all manual jni registration code in content that calls these generated
RegisterNativesImpl calls.

TBR=blundell@chromium.org

Bug:  749244 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I245e89fdb91fe706d1f601b6fa65e9dbe2f289d8
Reviewed-on: https://chromium-review.googlesource.com/587668
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490479}
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/chrome/app/android/chrome_jni_onload.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/chromecast/app/android/cast_jni_loader.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/components/test/android/browsertests_apk/components_browser_tests_jni_onload.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/components/test/components_test_suite.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/BUILD.gn
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/app/android/app_jni_registrar.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/app/android/app_jni_registrar.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/android/content_child_process_service_delegate.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/app/android/content_child_process_service_delegate.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/android/content_jni_onload.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/android/content_main.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/app/android/content_main.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/app/android/library_loader_hooks.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/BUILD.gn
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/accessibility/web_contents_accessibility_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/app_web_message_port.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/app_web_message_port.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/background_sync_network_observer_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/background_sync_network_observer_android.h
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/android/browser_jni_registrar.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/android/browser_jni_registrar.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/browser_startup_controller.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/browser_startup_controller.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_feature_list.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_feature_list.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_video_view.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_video_view.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_view_core.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_view_core.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_view_render_view.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_view_render_view.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/content_view_statics.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/android/content_view_statics.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/date_time_chooser_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/date_time_chooser_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/dialog_overlay_impl.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/dialog_overlay_impl.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/gpu_process_callback.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/android/gpu_process_callback.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/interstitial_page_delegate_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/interstitial_page_delegate_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/load_url_params.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/android/load_url_params.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/selection_popup_controller.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/selection_popup_controller.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/smart_selection_client.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/smart_selection_client.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/text_suggestion_host_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/text_suggestion_host_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/tracing_controller_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/tracing_controller_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/web_contents_observer_proxy.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/android/web_contents_observer_proxy.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/child_process_launcher_helper_android.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/browser/child_process_launcher_helper_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/frame_host/navigation_controller_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/frame_host/navigation_controller_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/frame_host/render_frame_host_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/frame_host/render_frame_host_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/media/session/audio_focus_delegate_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/media/session/audio_focus_delegate_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/media/session/media_session_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/media/session/media_session_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/memory/memory_monitor_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/memory/memory_monitor_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/speech/speech_recognizer_impl_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/common/BUILD.gn
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/common/android/common_jni_registrar.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/common/android/common_jni_registrar.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/common/android/resource_request_body_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/common/android/resource_request_body_android.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/public/app/content_jni_onload.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/public/test/test_utils.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/public/test/test_utils.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/BUILD.gn
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/BUILD.gn
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/browsertests_apk/content_browser_tests_jni_onload.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/linker_test_apk/chromium_linker_test_android.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.h
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/shell/android/shell_jni_registrar.cc
[delete] https://crrev.com/3b4b6cd6ad9f43aa205ebe4e7bc15305d24e6c3d/content/shell/android/shell_jni_registrar.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/shell_library_loader.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/shell_manager.cc
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/android/shell_manager.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/browser/shell.h
[modify] https://crrev.com/1f7dc0cc0596942d26b34d42474be07dbef8fc5b/content/shell/browser/shell_android.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddb146adb21cb07227e33092e0794baa580d27f2

commit ddb146adb21cb07227e33092e0794baa580d27f2
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Fri Jul 28 23:41:28 2017

aw: Remove aw_contents_statics.h

Missed this one in last CL, only deleted it in BUILD.gn

Removing more unnecessary headers.

Bug:  749244 
Change-Id: I2c222f319f5cc1ba5f741e011fb1907ccd3c844b
Reviewed-on: https://chromium-review.googlesource.com/592241
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490543}
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/browser/aw_contents_client_bridge_unittest.cc
[delete] https://crrev.com/c0c30140bec66ce4e8e8b878433caa81377efe18/android_webview/browser/aw_contents_statics.h
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/browser/aw_picture.cc
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/browser/aw_picture.h
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/browser/popup_touch_handle_drawable.h
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/lib/webview_jni_onload.cc
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/lib/webview_jni_onload.h
[modify] https://crrev.com/ddb146adb21cb07227e33092e0794baa580d27f2/android_webview/lib/webview_tests.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec9026caf93b74c036829451a3d94fca4d7c97ec

commit ec9026caf93b74c036829451a3d94fca4d7c97ec
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Sat Jul 29 01:09:34 2017

Remove RegisterNativesImpl() in printing/

Bug:  749244 
Change-Id: Ib73e91b8e1831b45cc07fb79368a15d1c80c7599
Reviewed-on: https://chromium-review.googlesource.com/588112
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490566}
[modify] https://crrev.com/ec9026caf93b74c036829451a3d94fca4d7c97ec/printing/printing_context_android.cc
[modify] https://crrev.com/ec9026caf93b74c036829451a3d94fca4d7c97ec/printing/printing_context_android.h

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07615e043765cb23179fc81137a3800ff4eb89e1

commit 07615e043765cb23179fc81137a3800ff4eb89e1
Author: Bo Liu <boliu@chromium.org>
Date: Wed Aug 02 14:01:24 2017

android: Remove manual jni registration in ui/

All generated RegisterNativesImpl functions are no-op already. Remove
all manual jni registration code in ui that calls these generated
RegisterNativesImpl calls.

TBR=garykac@chromium.org,zmo@chromium.org

Bug:  749244 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iebbb9d91e5cc78d62b323113c5ccecd59a7311a8
Reviewed-on: https://chromium-review.googlesource.com/592333
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491362}
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/android_webview/browser/aw_form_database_service_unittest.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/gpu/command_buffer/tests/gl_tests_main.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/media/test/run_all_unittests.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/remoting/client/jni/remoting_jni_onload.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/BUILD.gn
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/display_android_manager.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/event_forwarder.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/event_forwarder.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/resources/resource_factory.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/android/resources/resource_factory.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/resources/resource_manager_impl.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/resources/resource_manager_impl.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/run_all_unittests.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/screen_android.h
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/android/ui_android_jni_registrar.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/android/ui_android_jni_registrar.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/window_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/android/window_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/BUILD.gn
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/base/android/ui_base_jni_registrar.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/base/android/ui_base_jni_registrar.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/clipboard/clipboard_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/clipboard/clipboard_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/l10n/l10n_util_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/l10n/l10n_util_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/base/test/run_all_unittests.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/events/devices/input_device_observer_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/events/devices/input_device_observer_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gfx/BUILD.gn
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/gfx/android/gfx_jni_registrar.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/gfx/android/gfx_jni_registrar.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gfx/android/view_configuration.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gfx/android/view_configuration.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gfx/test/run_all_unittests.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gl/BUILD.gn
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/gl/android/gl_jni_registrar.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/gl/android/gl_jni_registrar.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gl/android/surface_texture_listener.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/gl/android/surface_texture_listener.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/platform_window/android/platform_ime_controller_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/platform_window/android/platform_ime_controller_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/platform_window/android/platform_window_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/platform_window/android/platform_window_android.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/shell_dialogs/BUILD.gn
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/shell_dialogs/android/shell_dialogs_jni_registrar.cc
[delete] https://crrev.com/6817f5b0fef61ba29614205affa1dfa2e22860f6/ui/shell_dialogs/android/shell_dialogs_jni_registrar.h
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/shell_dialogs/select_file_dialog_android.cc
[modify] https://crrev.com/07615e043765cb23179fc81137a3800ff4eb89e1/ui/shell_dialogs/select_file_dialog_android.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7bc4594819ae4550d60a8376d6aaac09c2cad01

commit c7bc4594819ae4550d60a8376d6aaac09c2cad01
Author: Yaron Friedman <yfriedman@chromium.org>
Date: Fri Aug 04 19:09:49 2017

Remove manual JNI Registrations from device/

BUG= 749244 

Change-Id: I28ee62262a5ff7f1d1a5c00e350005ca99ddf43b
Reviewed-on: https://chromium-review.googlesource.com/590412
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492094}
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/BUILD.gn
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/bluetooth/android/bluetooth_jni_registrar.cc
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/bluetooth/android/bluetooth_jni_registrar.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_adapter_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_adapter_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_device_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_device_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_descriptor_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_service_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/bluetooth_remote_gatt_service_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/bluetooth/test/bluetooth_test_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/gamepad/BUILD.gn
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/gamepad/android/gamepad_jni_registrar.cc
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/gamepad/android/gamepad_jni_registrar.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/gamepad/gamepad_platform_data_fetcher_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/gamepad/gamepad_platform_data_fetcher_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/geolocation/BUILD.gn
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/geolocation/android/geolocation_jni_registrar.cc
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/geolocation/android/geolocation_jni_registrar.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/geolocation/location_api_adapter_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/geolocation/location_api_adapter_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/sensors/BUILD.gn
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/sensors/android/device_sensor_jni_registrar.cc
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/sensors/android/device_sensor_jni_registrar.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/sensors/sensor_manager_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/sensors/sensor_manager_android.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/sensors/sensor_manager_android_unittest.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/test/run_all_unittests.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/usb/BUILD.gn
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/usb/android/usb_jni_registrar.cc
[delete] https://crrev.com/46ad97266bb8921b888babb045e48ac347d8653d/device/usb/android/usb_jni_registrar.h
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/usb/usb_service_android.cc
[modify] https://crrev.com/c7bc4594819ae4550d60a8376d6aaac09c2cad01/device/usb/usb_service_android.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3818f4da92f57db7212f9e9dc38b470cf47b605b

commit 3818f4da92f57db7212f9e9dc38b470cf47b605b
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Tue Aug 15 20:49:18 2017

aw: Cleanup after removal of RegisterNativesImpl()

Since we removed RegisterNativesImpl() calls in aw, code
under /test/embedded_test_server/ changed a lot:

aw_test_jni_onload.{cc,h} contains only one function calling
base::android::OnJNIOnLoadInit(), so delete these files and
call OnJNIOnLoadInit() from aw_test_entry_point.cc.

aw_embedded_test_server.h is unnecessary now, so remove it.

Dependencies of net/test/android/net_test_jni_onload.{cc,h}
are obsoleted, remove them from BUILD.gn.

Bug:  749244 
Change-Id: I6bca95557a8874865404af29aac8b633afca9a85
Reviewed-on: https://chromium-review.googlesource.com/614862
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494533}
[modify] https://crrev.com/3818f4da92f57db7212f9e9dc38b470cf47b605b/android_webview/test/embedded_test_server/BUILD.gn
[modify] https://crrev.com/3818f4da92f57db7212f9e9dc38b470cf47b605b/android_webview/test/embedded_test_server/aw_embedded_test_server.cc
[delete] https://crrev.com/8d5e7fb9a6ffbf80184091a23ed9e8450e514a56/android_webview/test/embedded_test_server/aw_embedded_test_server.h
[modify] https://crrev.com/3818f4da92f57db7212f9e9dc38b470cf47b605b/android_webview/test/embedded_test_server/aw_test_entry_point.cc
[delete] https://crrev.com/8d5e7fb9a6ffbf80184091a23ed9e8450e514a56/android_webview/test/embedded_test_server/aw_test_jni_onload.cc
[delete] https://crrev.com/8d5e7fb9a6ffbf80184091a23ed9e8450e514a56/android_webview/test/embedded_test_server/aw_test_jni_onload.h

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d84b83c9d78cd396275b4319f0d1682421ab975

commit 8d84b83c9d78cd396275b4319f0d1682421ab975
Author: Yaron Friedman <yfriedman@chromium.org>
Date: Tue Aug 22 17:30:19 2017

Remove unnecessary manual registrations from components/

It's dead code - done automatically now.
BUG= 749244 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Id248a7be11015ed5af85a886e83045dc8f0eae35
Reviewed-on: https://chromium-review.googlesource.com/615441
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496348}
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/chrome/android/BUILD.gn
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/chrome/browser/android/chrome_sync_shell_main_delegate.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/chrome/browser/android/chrome_sync_shell_main_delegate.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/chrome/browser/android/chrome_sync_shell_main_delegate_initializer.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/about_ui/credit_utils.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/autofill/android/autofill_provider_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/autofill/android/form_data_android.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/autofill/android/form_data_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/BUILD.gn
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_bidirectional_stream_adapter.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_bidirectional_stream_adapter.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_upload_data_stream_adapter.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_upload_data_stream_adapter.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_url_request_adapter.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/cronet_url_request_context_adapter.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/cronet_test_jni.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/cronet_test_util.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/cronet_test_util.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/cronet_url_request_context_config_test.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/experimental_options_test.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/experimental_options_test.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/mock_cert_verifier.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/mock_cert_verifier.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/mock_url_request_job_factory.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/mock_url_request_job_factory.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/native_test_server.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/native_test_server.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/quic_test_server.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/quic_test_server.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/sdch_test_util.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/cronet/android/test/sdch_test_util.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/test_upload_data_stream_handler.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/cronet/android/test/test_upload_data_stream_handler.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/dom_distiller/content/browser/BUILD.gn
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/dom_distiller/content/browser/android/content_jni_registrar.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/dom_distiller/content/browser/android/content_jni_registrar.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/dom_distiller/content/browser/distillable_page_utils_android.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/dom_distiller/content/browser/distillable_page_utils_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/feature_engagement/internal/android/tracker_impl_android.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/feature_engagement/internal/android/tracker_impl_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/spellcheck/browser/BUILD.gn
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/spellcheck/browser/spellchecker_session_bridge_android.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/spellcheck/browser/spellchecker_session_bridge_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/sync/BUILD.gn
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/sync/android/model_type_helper.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/sync/android/model_type_helper.h
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/sync/android/sync_jni_registrar.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/sync/android/sync_jni_registrar.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/sync/test/fake_server/android/fake_server_helper_android.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/sync/test/fake_server/android/fake_server_helper_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/variations/BUILD.gn
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/variations/android/component_jni_registrar.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/variations/android/component_jni_registrar.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/variations/android/variations_associated_data_android.cc
[delete] https://crrev.com/330f5e14d2b1e3ac27cd3f11272f20e13b013474/components/variations/android/variations_associated_data_android.h
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/web_restrictions/browser/web_restrictions_client.cc
[modify] https://crrev.com/8d84b83c9d78cd396275b4319f0d1682421ab975/components/web_restrictions/browser/web_restrictions_client.h

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 24 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9b701640fcb02f19f1ddb17fd8f19490c9be57

commit cc9b701640fcb02f19f1ddb17fd8f19490c9be57
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Aug 24 18:28:50 2017

Delete RegisterNatives() calls from //mojo

They are all no-ops now.

TBR=agrieve@chromium.org

Bug:  749244 
Change-Id: I4792c9b964d64bcdd93c957986e65c9b0bc64122
Reviewed-on: https://chromium-review.googlesource.com/633176
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497128}
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/BUILD.gn
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/javatests/init_library.cc
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/javatests/mojo_test_rule.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/javatests/mojo_test_rule.h
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/javatests/validation_test_util.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/javatests/validation_test_util.h
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/system/base_run_loop.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/system/base_run_loop.h
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/system/core_impl.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/system/core_impl.h
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/system/mojo_jni_registrar.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/system/mojo_jni_registrar.h
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/mojo/android/system/watcher_impl.cc
[delete] https://crrev.com/ba096e2f4e770bfe52e0af69a5f67c159633cec8/mojo/android/system/watcher_impl.h
[modify] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/services/service_manager/public/cpp/test/common_initialization.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ee38daf05ba86ae66a51a954a9a54173e49574

commit 21ee38daf05ba86ae66a51a954a9a54173e49574
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Aug 24 18:30:23 2017

Delete RegisterNatives() calls in //remoting

These are all no-ops.

Bug:  749244 
Change-Id: I115d46769bd0be7ed19ad1375e3afb56c5d8e1a7
Reviewed-on: https://chromium-review.googlesource.com/633036
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497129}
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/BUILD.gn
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_client.cc
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_client.h
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_gl_display_handler.cc
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_gl_display_handler.h
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_runtime_delegate.cc
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/jni_runtime_delegate.h
[modify] https://crrev.com/21ee38daf05ba86ae66a51a954a9a54173e49574/remoting/client/jni/remoting_jni_onload.cc
[delete] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/remoting/client/jni/remoting_jni_registrar.cc
[delete] https://crrev.com/cc9b701640fcb02f19f1ddb17fd8f19490c9be57/remoting/client/jni/remoting_jni_registrar.h

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3

commit b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Aug 25 14:47:38 2017

Delete RegisterNatives() from //net

They are all no-ops

Bug:  749244 
Change-Id: Iaa6eddd7ee0f5a0e4c9fd075e533f5058070f476
Reviewed-on: https://chromium-review.googlesource.com/633216
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497405}
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/BUILD.gn
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/dummy_spnego_authenticator.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/dummy_spnego_authenticator.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/http_auth_negotiate_android.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/http_auth_negotiate_android.h
[delete] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/net/android/net_jni_registrar.cc
[delete] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/net/android/net_jni_registrar.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/network_change_notifier_android.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/network_change_notifier_android.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/network_change_notifier_delegate_android.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/android/network_change_notifier_delegate_android.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/cert/x509_util_android.cc
[delete] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/net/cert/x509_util_android.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/proxy/proxy_config_service_android.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/proxy/proxy_config_service_android.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/android/net_test_entry_point.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/android/net_test_jni_onload.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/android/net_test_jni_onload.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/embedded_test_server/android/embedded_test_server_android.cc
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/embedded_test_server/android/embedded_test_server_android.h
[modify] https://crrev.com/b66fc6ae87bfd5dca7156700a9ec5a73ffb148c3/net/test/run_all_unittests.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f00ad05a615e5eed13babcfd4e63397a821df4b

commit 0f00ad05a615e5eed13babcfd4e63397a821df4b
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Aug 28 19:17:56 2017

Delete RegisterNatives() calls in //chromecast

They are dead code.

Bug:  749244 
Change-Id: I6fd66505346adf4f20c5218e72f114231becc15e
Reviewed-on: https://chromium-review.googlesource.com/634148
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497830}
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/android/BUILD.gn
[delete] https://crrev.com/3223a418ce49b0e5c74d980654179c7df160a6be/chromecast/android/cast_jni_registrar.cc
[delete] https://crrev.com/3223a418ce49b0e5c74d980654179c7df160a6be/chromecast/android/cast_jni_registrar.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/base/android/system_time_change_notifier_android.cc
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/base/android/system_time_change_notifier_android.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/base/chromecast_config_android.cc
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/base/chromecast_config_android.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/browser/BUILD.gn
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/browser/android/cast_metrics_helper_android.cc
[delete] https://crrev.com/3223a418ce49b0e5c74d980654179c7df160a6be/chromecast/browser/android/cast_metrics_helper_android.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/browser/android/cast_web_contents_activity.cc
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/browser/android/cast_web_contents_activity.h
[delete] https://crrev.com/3223a418ce49b0e5c74d980654179c7df160a6be/chromecast/browser/android/jni_registrar.cc
[delete] https://crrev.com/3223a418ce49b0e5c74d980654179c7df160a6be/chromecast/browser/android/jni_registrar.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.cc
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.h
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/0f00ad05a615e5eed13babcfd4e63397a821df4b/chromecast/media/cma/backend/android/volume_control_android.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6886f919d0fb88e8551696bd07832d1f160e5751

commit 6886f919d0fb88e8551696bd07832d1f160e5751
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Aug 29 00:26:42 2017

Revert "Delete RegisterNatives() calls in //chromecast"

This reverts commit 0f00ad05a615e5eed13babcfd4e63397a821df4b.

Reason for revert: Unintended deletes in volume_control_android.cc

Original change's description:
> Delete RegisterNatives() calls in //chromecast
> 
> They are dead code.
> 
> Bug:  749244 
> Change-Id: I6fd66505346adf4f20c5218e72f114231becc15e
> Reviewed-on: https://chromium-review.googlesource.com/634148
> Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497830}

TBR=agrieve@chromium.org,sanfin@chromium.org,alokp@chromium.org

Change-Id: I610521bc75118829c39a24eb44aca748f13f9843
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  749244 
Reviewed-on: https://chromium-review.googlesource.com/639810
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497955}
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/android/BUILD.gn
[add] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/android/cast_jni_registrar.cc
[add] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/android/cast_jni_registrar.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/base/android/system_time_change_notifier_android.cc
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/base/android/system_time_change_notifier_android.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/base/chromecast_config_android.cc
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/base/chromecast_config_android.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/BUILD.gn
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/cast_metrics_helper_android.cc
[add] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/cast_metrics_helper_android.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/cast_web_contents_activity.cc
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/cast_web_contents_activity.h
[add] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/jni_registrar.cc
[add] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/browser/android/jni_registrar.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.cc
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.h
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/6886f919d0fb88e8551696bd07832d1f160e5751/chromecast/media/cma/backend/android/volume_control_android.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc

commit e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Aug 29 02:55:04 2017

Reland Delete RegisterNatives() calls in //chromecast

This reverts commit 6886f919d0fb88e8551696bd07832d1f160e5751.

Reason for revert: Relanding without randomly deleted code.

TBR=agrieve@chromium.org,sanfin@chromium.org,alokp@chromium.org

Bug:  749244 
Change-Id: I5db2b6d52a888ad0128690ad63dc2be396f7babb
Reviewed-on: https://chromium-review.googlesource.com/639271
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497999}
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/android/BUILD.gn
[delete] https://crrev.com/4c8becebe3a60197fc66be4b5501b0a792a51a5f/chromecast/android/cast_jni_registrar.cc
[delete] https://crrev.com/4c8becebe3a60197fc66be4b5501b0a792a51a5f/chromecast/android/cast_jni_registrar.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/base/android/system_time_change_notifier_android.cc
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/base/android/system_time_change_notifier_android.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/base/chromecast_config_android.cc
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/base/chromecast_config_android.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/browser/BUILD.gn
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/browser/android/cast_metrics_helper_android.cc
[delete] https://crrev.com/4c8becebe3a60197fc66be4b5501b0a792a51a5f/chromecast/browser/android/cast_metrics_helper_android.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/browser/android/cast_web_contents_activity.cc
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/browser/android/cast_web_contents_activity.h
[delete] https://crrev.com/4c8becebe3a60197fc66be4b5501b0a792a51a5f/chromecast/browser/android/jni_registrar.cc
[delete] https://crrev.com/4c8becebe3a60197fc66be4b5501b0a792a51a5f/chromecast/browser/android/jni_registrar.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.cc
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/media/cma/backend/android/audio_sink_android_audiotrack_impl.h
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/e2ead3253c6ef6d6d62eb6a20c29bca256a7ffdc/chromecast/media/cma/backend/android/volume_control_android.h

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffae5ea51ee5646778aa9fbd862110ff36762d77

commit ffae5ea51ee5646778aa9fbd862110ff36762d77
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Aug 30 02:14:10 2017

android: Stop generating RegisterNativesImpl() stubs

Bug:  749244 
Change-Id: If3c8dba31f34e820a73e9954da79a6dde36d8eab
Reviewed-on: https://chromium-review.googlesource.com/641612
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498341}
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/SampleForTests_jni.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/jni_generator.py
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testCalledByNatives.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testConstantsFromJavaP.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testFromJavaP.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testFromJavaPGenerics.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testInnerClassNatives.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testInnerClassNativesMultiple.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testMultipleJNIAdditionalImport.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testNativeExportsOnlyOption.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testNatives.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testNativesLong.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/base/android/jni_generator/testSingleJNIAdditionalImport.golden
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/content/browser/android/popup_zoomer.cc
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/content/browser/android/popup_zoomer.h
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/net/BUILD.gn
[modify] https://crrev.com/ffae5ea51ee5646778aa9fbd862110ff36762d77/net/android/gurl_utils.cc
[delete] https://crrev.com/d513cec6a99f61cdf486c2bd5dc121bc8d221a14/net/android/gurl_utils.h

Status: Fixed (was: Available)

Sign in to add a comment