New issue
Advanced search Search tips

Issue 749222 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

install-build-deps.sh missing dependency for xdpyinfo

Reported by jwo...@igalia.com, Jul 26 2017

Issue description

Looks like we should add x11-utils to the list of required ubuntu packages.

After I did this:

* create a chroot environment for trusty
* install git
* clone depot_tools
* fetch --nohooks chromium
* sudo ./build/install-build-deps.sh
* gclient runhooks
* gn gen out/Default
* ninja -C out/Default blink_tests

Then I got this:

```
(chromium)jwolfe@jwolfe-desktop:~/chromium/src$ python third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
Using port 'linux-trusty'
Test configuration: <trusty, x86_64, debug>
View the test results at file:///home/jwolfe/chromium/src/out/Default/layout-test-results/results.html
Using random order with seed: 1501089613
Baseline search path: linux -> win -> generic
Using Debug build
Pixel tests enabled
Regular timeout: 18000, slow test timeout: 90000
Command line: /home/jwolfe/chromium/src/out/Default/content_shell --run-layout-test --ignore-certificate-errors-spki-list=Nxvaj3+bY3oVrTc+Jp7m3E3sB1n3lXtnMDCyBsqEXiY= --enable-crash-reporter --crash-dumps-dir=/home/jwolfe/chromium/src/out/Default/crash-dumps -

Found 68490 tests; running 59617, skipping 8873.   
Checking build ...
OSError raised: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 67, in main
    return run(port, options, args, stderr, stdout).exit_code
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 597, in run
    run_details = _run_tests(port, options, args, printer)
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 588, in _run_tests
    return manager.run(args)
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 141, in run
    exit_code = self._set_up_run(tests_to_run)
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 349, in _set_up_run
    self._port.setup_test_run()
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py", line 112, in setup_test_run
    self._start_xvfb()
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py", line 153, in _start_xvfb
    display = self._find_display()
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py", line 208, in _find_display
    ['xdpyinfo', '-display', display], return_exit_code=True)
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 309, in run_command
    close_fds=self._should_close_fds())
  File "/home/jwolfe/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 377, in popen
    return subprocess.Popen(string_args, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
```
 
Labels: TE-NeedsTriageHelp

Comment 2 by jwo...@igalia.com, Aug 2 2017

I did not get this in a VirtualBox installation of Ubuntu 14.04, so this seems to be an issue specific to a chroot installation. I suppose that the out-of-the-box Ubuntu 14.04 pre-installed packages includes x11-utils, but whatever the pre-installed packages are that come with a chroot don't include x11-utils.

I suppose it's debatable whether stuff that's supposed to already be installed should be listed as a dependency. Theoretically, it would improve the experience of people attempting to use a chroot like I was.

It might also be worth noting that I haven't yet actually gotten things to work in a chroot. This issue was one of a series of obstacles that I have not yet seen the end of.
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d79de41d48ab8813d3793d8df5c6bafe4d77b6ab

commit d79de41d48ab8813d3793d8df5c6bafe4d77b6ab
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 08 00:23:23 2017

Add x11-utils to install-build-deps.sh

xdpyinfo from the package x11-utils is necessary for run-webkit-tests.

BUG= 749222 
R=dpranke@chromium.org

Change-Id: I4ee4d880895e56c947741debdaa2095f03efc91e
Reviewed-on: https://chromium-review.googlesource.com/601354
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492466}
[modify] https://crrev.com/d79de41d48ab8813d3793d8df5c6bafe4d77b6ab/build/install-build-deps.sh

Status: Fixed (was: Started)
Thanks OP for reporting this issue.  PLMK if there are other dependencies that need to be added

Sign in to add a comment