New issue
Advanced search Search tips

Issue 749218 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

LayerTreeHostScrollTestImplSideInvalidation.RunMultiThread_DelegatingRenderer times out

Project Member Reported by pdr@chromium.org, Jul 26 2017

Issue description

At tip-of-tree I am getting timeouts when running LayerTreeHostScrollTestImplSideInvalidation.RunMultiThread_DelegatingRenderer on Windows:

[11:57:14]:/c/src/chromium/src $ ./out/Debug/cc_unittests.exe --gtest_filter=LayerTreeHostScrollTestImplSideInvalidation.RunMultiThread_DelegatingRenderer
 

Comment 1 by pdr@chromium.org, Jul 26 2017

Owner: khushals...@chromium.org
Khushal, could this be https://chromium.googlesource.com/chromium/src/+/8360fc950e05eda2a24da3cea3fbc3e199e20fd8 ?
Hmmm, could be. Let me see if I can get a repro on linux.

Comment 3 by pdr@chromium.org, Jul 26 2017

Looks like this is flaky on linux too: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cc_unittests&tests=LayerTreeHostScrollTestImplSideInvalidation

This also exonerates your patch because it was flaky before your patch.
The change above made it so we could activate a main frame update before a previous impl-side pending tree is draw to avoid blocking the pipeline. The scroll test was depending on the previous pipelining.

https://chromium-review.googlesource.com/c/587871/ should fix this.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e40f323bc67b22cd168b14b019bd5dc1b48c973

commit 5e40f323bc67b22cd168b14b019bd5dc1b48c973
Author: Khushal <khushalsagar@chromium.org>
Date: Sat Jul 29 00:00:03 2017

cc: Unflake LayerTreeHostScrollTestImplSideInvalidation.

Don't use num of draws to end test. The test assumed to see 4 draws
to correspond with 4 pending trees. Since the active tree resulting
from an impl-side pending tree can be merged with a new pending tree,
the number of draws may not always be equal to the number of pending
trees.

Bug:  749218 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib000838f07b0b00537d037402122539ccb449985
Reviewed-on: https://chromium-review.googlesource.com/587871
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490547}
[modify] https://crrev.com/5e40f323bc67b22cd168b14b019bd5dc1b48c973/cc/trees/layer_tree_host_unittest_scroll.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment