All the fields should be present in the "billingAddress" of the payment response. |
||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Enable WebPayments flag: chrome://flags/#web-payments (2) Go to https://paymentrequest.show/demo/ and press the buy button. (3) Confirm the payment and observe the result. What is the expected result? All the address fields, including the ones with no value, should be present in the "billingAddress" of the payment response. What happens instead? The fields with no value (e.g., dependentLocality, languageCode, and sortingCode) are missing from the response: { "methodName": "basic-card", "details": { "billingAddress": { "addressLine": [ "123 Main Street" ], "city": "Springfield", "country": "US", "phone": "+15146387789", "postalCode": "55123", "recipient": "Homer Simpson", "region": "IL" }, "cardNumber": "4111111111111111", "cardSecurityCode": "123", "cardholderName": "Moe", "expiryMonth": "12", "expiryYear": "2020" } } Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be6aec45460332d3df2bd441120b0eca591a3bf1 commit be6aec45460332d3df2bd441120b0eca591a3bf1 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Thu Jul 27 15:22:25 2017 [Payment Request] Fixes the bug where empty fields were not set in response Bug: 749209 Change-Id: Ida456ea498c80239eacba68b6192a93a68c48c83 Reviewed-on: https://chromium-review.googlesource.com/587430 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#489930} [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/components/payments/core/basic_card_response.cc [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/components/payments/core/payment_address.cc [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/components/payments/core/payment_request_data_util_unittest.cc [modify] https://crrev.com/be6aec45460332d3df2bd441120b0eca591a3bf1/ios/web/payments/payment_request_unittest.cc
,
Jul 28 2017
,
Jul 28 2017
,
Jul 28 2017
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30 2017
Pls merge you change to M61 branch 3163 before 3:00 PM PT on Monday so we can take it in for next week last M61 Dev release. Thank you.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7510a793e8a22563ded25cf7c54f42bea304ca74 commit 7510a793e8a22563ded25cf7c54f42bea304ca74 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Mon Jul 31 12:53:27 2017 [Payment Request] Fixes the bug where empty fields were not set in response TBR=mahmadi@chromium.org (cherry picked from commit be6aec45460332d3df2bd441120b0eca591a3bf1) Bug: 749209 Change-Id: Ida456ea498c80239eacba68b6192a93a68c48c83 Reviewed-on: https://chromium-review.googlesource.com/587430 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489930} Reviewed-on: https://chromium-review.googlesource.com/593848 Reviewed-by: mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#146} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/components/payments/core/basic_card_response.cc [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/components/payments/core/payment_address.cc [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/components/payments/core/payment_request_data_util_unittest.cc [modify] https://crrev.com/7510a793e8a22563ded25cf7c54f42bea304ca74/ios/web/payments/payment_request_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mahmadi@chromium.org
, Jul 26 2017