Layout test expectations edit button doesn't let you open the same modal twice in a row |
||
Issue descriptionSteps to reproduce: - Go to: https://sheriff-o-matic.appspot.com/test-expectations - Click one of the the "Edit" buttons on the right hand side. - Click "Cancel" in the modal. - Click the same Edit button you clicked before again. - Result: Nothing happens - Expected result: the modal should appear again (maybe a good starter bug?)
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/15ad3cc4b4211f72d4c30f6ea61b6c0735d221c5 commit 15ad3cc4b4211f72d4c30f6ea61b6c0735d221c5 Author: Joanna Wang <jojwang@google.com> Date: Wed Jul 26 23:13:34 2017 Fix edit dialog box bug. staging url: https://10934-ede8876-tainted-jojwang-dot-sheriff-o-matic-staging.appspot.com/test-expectations Bug:749199 Change-Id: I8a46760846827be4d2f15870400eeabecd1bcc5e Reviewed-on: https://chromium-review.googlesource.com/588001 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Commit-Queue: Joanna Wang <jojwang@google.com> [modify] https://crrev.com/15ad3cc4b4211f72d4c30f6ea61b6c0735d221c5/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.js [modify] https://crrev.com/15ad3cc4b4211f72d4c30f6ea61b6c0735d221c5/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.html
,
Jul 26 2017
should go out in next release |
||
►
Sign in to add a comment |
||
Comment 1 by seanmccullough@chromium.org
, Jul 26 2017