ClangToT bots failing with pragma pack warning |
||||||
Issue descriptionThe pragma pack warning landed again upstream: --- Author: arphaman Date: Wed Jul 26 05:20:57 2017 New Revision: 309106 URL: http://llvm.org/viewvc/llvm-project?rev=309106&view=rev Log: Recommit r308327 2nd time: Add a warning for missing '#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files The first recommit (r308441) caused a "non-default #pragma pack value might change the alignment of struct or union members in the included file" warning in LLVM itself. This recommit tweaks the added warning to avoid warnings for #includes that don't have any records that are affected by the non-default alignment. This tweak avoids the previously emitted warning in LLVM. Original message: This commit adds a new -Wpragma-pack warning. It warns in the following cases: - When a translation unit is missing terminating #pragma pack (pop) directives. - When entering an included file if the current alignment value as determined by '#pragma pack' directives is different from the default alignment value. - When leaving an included file that changed the state of the current alignment value. rdar://10184173 Differential Revision: https://reviews.llvm.org/D35484 --- And the build is sad, e.g. from https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/8734 FAILED: obj/gpu/command_buffer/client/gles2_cmd_helper_sources/gles2_cmd_helper.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/gpu/command_buffer/client/gles2_cmd_helper_sources/gles2_cmd_helper.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"309109\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGPU_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/libwebp/src -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++11 -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../gpu/command_buffer/client/gles2_cmd_helper.cc -o obj/gpu/command_buffer/client/gles2_cmd_helper_sources/gles2_cmd_helper.o In file included from ../../gpu/command_buffer/client/gles2_cmd_helper.cc:5: In file included from ../../gpu/command_buffer/client/gles2_cmd_helper.h:12: ../../gpu/command_buffer/common/gles2_cmd_format.h:311:10: error: non-default #pragma pack value changes the alignment of struct or union members in the included file [-Werror,-Wpragma-pack] #include "gpu/command_buffer/common/gles2_cmd_format_autogen.h" ^ ../../gpu/command_buffer/common/gles2_cmd_format.h:55:9: note: previous '#pragma pack' directive that modifies alignment is here #pragma pack(push, 4) ^
,
Jul 26 2017
We could #pragma it off in that case. Does it find anything useful elsewhere? If not, we could ask for true positive rate on the commit. I thought pragma pack across headers was kind of common and in fact the recommended way to do packing in some old Windows SDK (pckpsh.h / pckpop.h or some such). Maybe this shouldn't be in -Wall.
,
Jul 26 2017
,
Jul 28 2017
A narrower version of the warning landed in r309386, and we still get some warnings: From https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTWin_dll_%2F7773%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout FAILED: obj/third_party/usrsctp/usrsctp/sctp_callout.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes @obj/third_party/usrsctp/usrsctp/sctp_callout.obj.rsp /c ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c /Foobj/third_party/usrsctp/usrsctp/sctp_callout.obj /Fd"obj/third_party/usrsctp/usrsctp_c.pdb" In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c:48: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_pcb.h:56: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_structs.h:42: C:\b\c\builder\ClangToTWin_dll_\src\third_party\usrsctp\usrsctplib\usrsctplib\netinet\sctp_header.h(53,9): error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack] #pragma pack (push, 1) ^ In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c:47: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_sysctl.h:41: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_os.h:72: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_os_userspace.h:1062: C:\b\c\builder\ClangToTWin_dll_\src\third_party\usrsctp\usrsctplib\usrsctplib\netinet\sctp.h(51,9): error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack] #pragma pack (push, 1) ^ In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c:47: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_sysctl.h:41: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_os.h:72: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_os_userspace.h:490: C:\b\c\builder\ClangToTWin_dll_\src\third_party\usrsctp\usrsctplib\usrsctplib\user_ip_icmp.h(57,9): error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack] #pragma pack (push, 1) ^ 3 errors generated.
,
Jul 28 2017
Hm, might that be an actual bug? It looks like the file tries to "pop" here: https://cs.chromium.org/chromium/src/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_header.h?q=file:sctp_header.&sq=package:chromium&l=606 Is #pragma pack () supposed to pop? Is that a bug in the warning? Or is that an actual bug in the code?
,
Jul 28 2017
> Is > > #pragma pack () > > supposed to pop? MSDN says it resets it to the default. From https://msdn.microsoft.com/en-us/library/2e70t5y1.aspx "Calling pack with no arguments sets n to the value set in the compiler option /Zp. If the compiler option is not set, the default value is 8." I don't know if that's the same as pop in practice..
,
Jul 28 2017
No, #pragma pack() doesn't pop.
#pragma pack(push, 1)
#pragma pack(push, 2)
#pragma pack()
struct s {
int x;
};
#pragma pack(pop)
#include <stdio.h>
int main() {
printf("%zd\n", alignof(s));
return 0;
}
prints 4, i.e. #pragma pack() just reset to the default, instead of popping to 1.
,
Jul 28 2017
I think that should still suppress the warning. I think that's a missing feature in the warning's implementation.
,
Jul 28 2017
The code is broken if it's included in a context with another pack already pushed on the stack though. But perhaps that's unlikely :-/ To me it would be sensible to warn if a #pragma pack(push, x) is ever followed by #pragma pack(). Because what's the sense of pushing if you're going to reset it later?
,
Jul 28 2017
Hm, that's a good point. I guess the warning found a bug then and we should fix the code.
,
Jul 28 2017
I'm preparing a patch to suppress the warning for usrsctp and will also send a patch upstream. Hopefully it's just this lib.
,
Jul 28 2017
Suppressing: https://chromium-review.googlesource.com/c/592086/
,
Jul 28 2017
,
Jul 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11b831ec6b6dca1c9e951094f6601efd957398e3 commit 11b831ec6b6dca1c9e951094f6601efd957398e3 Author: Hans Wennborg <hans@chromium.org> Date: Sat Jul 29 04:02:03 2017 usrsctp: Suppress new -Wpragma-pack clang warning Suppress the warning while we fix upstream. BUG= 749197 Change-Id: Id8c38757f9e9383819a8dc8a5f04e859a0e812af Reviewed-on: https://chromium-review.googlesource.com/592086 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490616} [modify] https://crrev.com/11b831ec6b6dca1c9e951094f6601efd957398e3/third_party/usrsctp/BUILD.gn
,
Jul 31 2017
The patch from #13 landed upstream. pthatcher, deadbeef: Is there a process for rolling third_party/usrsctp, or can I just try grabbing the latest? Is there a script to help with this?
,
Jul 31 2017
There isn't any process I know of beyond the "rolling deps" section of the DEPS file. There aren't any special "stable" branches of usrsctp, so grabbing the latest is all we can really do. In the past I've also asked Michael Tüxen (usrsctp developer) when would be a "safe" time to update; though that was while there was a lot of refactoring going on to support I-DATA chunks. If there are no huge changes recently, we're probably safe.
,
Jul 31 2017
Thanks! There don't see to be any large changes, so trying to roll: https://chromium-review.googlesource.com/c/594656/
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1fdd91d0f787b93338544a686543f1aedce659d commit c1fdd91d0f787b93338544a686543f1aedce659d Author: Hans Wennborg <hans@chromium.org> Date: Tue Aug 01 16:36:20 2017 Roll src/third_party/usrsctp/usrsctplib/ 2f6478eb8..76bea922c (48 commits) Picks up 76bea922c, a fix for a new Clang warning. https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/2f6478eb8d40..76bea922c32b $ git log 2f6478eb8..76bea922c --date=short --no-merges --format='%ad %ae %s' 2017-07-28 hans Use '#pragma pack (pop)' instead of '#pragma pack ()' 2017-07-26 tuexen Check return value of if_indextoname(). 2017-07-25 tuexen Remove duplicate statement. 2017-07-24 tuexen Add --enable-programs to configure script. 2017-07-20 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-18 weinrank update compiler settings for sanitizers 2017-07-18 weinrank adding sanitizer support - first try 2017-07-16 weinrank tsctp: fix compiler warning 2017-07-16 weinrank revert unreachable code changes 2017-07-16 weinrank Revert "Unreachable code when in "__Userspace__"" 2017-07-16 weinrank Compiler flags: don't check for unreachable code 2017-07-16 weinrank tsctp: Windows compile fix 2017-07-16 weinrank Fix compiler warnings for more strict compiler flags 2017-07-16 weinrank Fix shadowed variable complain 2017-07-16 weinrank Unreachable code when in "__Userspace__" 2017-07-16 weinrank CFLAGS: don't set Werror by default 2017-07-16 weinrank More strict compiler flags 2017-07-15 tuexen Sycn with sctp-idata. 2017-07-15 weinrank CMake beautification 2017-07-15 weinrank CMake cleanup 2017-07-14 weinrank CMAKE refactoring 2017-07-13 weinrank correct include_directories path 2017-07-12 weinrank CMAKE refactoring 2017-07-11 weinrank ignore build directory 2017-07-04 tuexen Sync with sctp-idata. 2017-06-25 tuexen Remove unused code on Windows (which would not work). 2017-06-25 tuexen This should dead code. Try on buildbot. 2017-06-25 tuexen More signed/unsigned issues. 2017-06-25 tuexen Address some signed/unsigned issues. 2017-06-25 tuexen Improve build scripts. 2017-06-25 tuexen Silence a warning when using older versions of clang. 2017-06-25 tuexen Silence a warning showing up on clang 4. 2017-06-25 tuexen I missed this in the last commit... 2017-06-25 tuexen Remove datachan_serv.c. 2017-06-25 tuexen Address signess issues. 2017-06-25 tuexen Address windows type mismatches. 2017-06-25 tuexen Fix a bug reported in https://github.com/sctplab/usrsctp/pull/150/files 2017-06-25 tuexen Use lowercase names for include files. 2017-06-23 tuexen Sync with El Capitan sources. 2017-06-23 tuexen Sync with sctp-idata. 2017-06-23 tuexen Sync FBSDID. 2017-06-23 tuexen Fix FreeBSD compilation. 2017-06-23 tuexen Add -Wno-address-of-packed-member to build system. 2017-06-23 tuexen Sync with FreeBSD sources. 2017-05-15 anselm.scholl Fix truncation with snprintf in buffer: Created with: roll-dep src/third_party/usrsctp/usrsctplib BUG= 749197 Change-Id: I2b05f13a523679beaa2fb8dc75bbf0ea190c7129 Reviewed-on: https://chromium-review.googlesource.com/594656 Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#491010} [modify] https://crrev.com/c1fdd91d0f787b93338544a686543f1aedce659d/DEPS [modify] https://crrev.com/c1fdd91d0f787b93338544a686543f1aedce659d/third_party/usrsctp/BUILD.gn [modify] https://crrev.com/c1fdd91d0f787b93338544a686543f1aedce659d/third_party/usrsctp/README.chromium
,
Aug 1 2017
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0419e2caf7616d2fcc7b8c88319c5182f9932242 commit 0419e2caf7616d2fcc7b8c88319c5182f9932242 Author: Nico Weber <thakis@chromium.org> Date: Thu Aug 03 01:00:47 2017 Revert "Roll src/third_party/usrsctp/usrsctplib/ 2f6478eb8..76bea922c (48 commits)" This reverts commit c1fdd91d0f787b93338544a686543f1aedce659d. Reason for revert: Warning still fires in at least one file: FAILED: obj/third_party/usrsctp/usrsctp/sctp_callout.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes @obj/third_party/usrsctp/usrsctp/sctp_callout.obj.rsp /c ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c /Foobj/third_party/usrsctp/usrsctp/sctp_callout.obj /Fd"obj/third_party/usrsctp/usrsctp_c.pdb" In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c:48: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_pcb.h:56: In file included from ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_structs.h:42: ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_header.h(53,9): error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack] #pragma pack (push, 1) ^ ../../third_party/usrsctp/usrsctplib/usrsctplib\netinet/sctp_header.h(606,9): note: did you intend to use '#pragma pack (pop)' instead of '#pragma pack()'? #pragma pack () ^ pop Original change's description: > Roll src/third_party/usrsctp/usrsctplib/ 2f6478eb8..76bea922c (48 commits) > > Picks up 76bea922c, a fix for a new Clang warning. > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/2f6478eb8d40..76bea922c32b > > $ git log 2f6478eb8..76bea922c --date=short --no-merges --format='%ad %ae %s' > 2017-07-28 hans Use '#pragma pack (pop)' instead of '#pragma pack ()' > 2017-07-26 tuexen Check return value of if_indextoname(). > 2017-07-25 tuexen Remove duplicate statement. > 2017-07-24 tuexen Add --enable-programs to configure script. > 2017-07-20 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-19 tuexen Sync with sctp-idata. > 2017-07-18 weinrank update compiler settings for sanitizers > 2017-07-18 weinrank adding sanitizer support - first try > 2017-07-16 weinrank tsctp: fix compiler warning > 2017-07-16 weinrank revert unreachable code changes > 2017-07-16 weinrank Revert "Unreachable code when in "__Userspace__"" > 2017-07-16 weinrank Compiler flags: don't check for unreachable code > 2017-07-16 weinrank tsctp: Windows compile fix > 2017-07-16 weinrank Fix compiler warnings for more strict compiler flags > 2017-07-16 weinrank Fix shadowed variable complain > 2017-07-16 weinrank Unreachable code when in "__Userspace__" > 2017-07-16 weinrank CFLAGS: don't set Werror by default > 2017-07-16 weinrank More strict compiler flags > 2017-07-15 tuexen Sycn with sctp-idata. > 2017-07-15 weinrank CMake beautification > 2017-07-15 weinrank CMake cleanup > 2017-07-14 weinrank CMAKE refactoring > 2017-07-13 weinrank correct include_directories path > 2017-07-12 weinrank CMAKE refactoring > 2017-07-11 weinrank ignore build directory > 2017-07-04 tuexen Sync with sctp-idata. > 2017-06-25 tuexen Remove unused code on Windows (which would not work). > 2017-06-25 tuexen This should dead code. Try on buildbot. > 2017-06-25 tuexen More signed/unsigned issues. > 2017-06-25 tuexen Address some signed/unsigned issues. > 2017-06-25 tuexen Improve build scripts. > 2017-06-25 tuexen Silence a warning when using older versions of clang. > 2017-06-25 tuexen Silence a warning showing up on clang 4. > 2017-06-25 tuexen I missed this in the last commit... > 2017-06-25 tuexen Remove datachan_serv.c. > 2017-06-25 tuexen Address signess issues. > 2017-06-25 tuexen Address windows type mismatches. > 2017-06-25 tuexen Fix a bug reported in https://github.com/sctplab/usrsctp/pull/150/files > 2017-06-25 tuexen Use lowercase names for include files. > 2017-06-23 tuexen Sync with El Capitan sources. > 2017-06-23 tuexen Sync with sctp-idata. > 2017-06-23 tuexen Sync FBSDID. > 2017-06-23 tuexen Fix FreeBSD compilation. > 2017-06-23 tuexen Add -Wno-address-of-packed-member to build system. > 2017-06-23 tuexen Sync with FreeBSD sources. > 2017-05-15 anselm.scholl Fix truncation with snprintf in buffer: > > Created with: > roll-dep src/third_party/usrsctp/usrsctplib > > BUG= 749197 > > Change-Id: I2b05f13a523679beaa2fb8dc75bbf0ea190c7129 > Reviewed-on: https://chromium-review.googlesource.com/594656 > Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491010} TBR=hans@chromium.org,deadbeef@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749197 Change-Id: Idfef3d4c6217297113d0700a9317a89b4b90bac8 Reviewed-on: https://chromium-review.googlesource.com/598711 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#491582} [modify] https://crrev.com/0419e2caf7616d2fcc7b8c88319c5182f9932242/DEPS [modify] https://crrev.com/0419e2caf7616d2fcc7b8c88319c5182f9932242/third_party/usrsctp/BUILD.gn [modify] https://crrev.com/0419e2caf7616d2fcc7b8c88319c5182f9932242/third_party/usrsctp/README.chromium
,
Aug 3 2017
Sorry, it seems I missed some. Will try to get to this today.
,
Aug 3 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b5aa967f47d7c575feaeafe2527e9051112f60c commit 0b5aa967f47d7c575feaeafe2527e9051112f60c Author: Hans Wennborg <hans@chromium.org> Date: Fri Aug 04 01:49:46 2017 Roll src/third_party/usrsctp/usrsctplib/ 2f6478eb8..f4819e1b1 (49 commits) https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/2f6478eb8d40..f4819e1b177f Picks up 76bea922c and f4819e1b1 to fix a new Clang warning. $ git log 2f6478eb8..f4819e1b1 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 hans Fix one remaining #pragma pack() 2017-07-28 hans Use '#pragma pack (pop)' instead of '#pragma pack ()' 2017-07-26 tuexen Check return value of if_indextoname(). 2017-07-25 tuexen Remove duplicate statement. 2017-07-24 tuexen Add --enable-programs to configure script. 2017-07-20 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-19 tuexen Sync with sctp-idata. 2017-07-18 weinrank update compiler settings for sanitizers 2017-07-18 weinrank adding sanitizer support - first try 2017-07-16 weinrank tsctp: fix compiler warning 2017-07-16 weinrank revert unreachable code changes 2017-07-16 weinrank Revert "Unreachable code when in "__Userspace__"" 2017-07-16 weinrank Compiler flags: don't check for unreachable code 2017-07-16 weinrank tsctp: Windows compile fix 2017-07-16 weinrank Fix compiler warnings for more strict compiler flags 2017-07-16 weinrank Fix shadowed variable complain 2017-07-16 weinrank Unreachable code when in "__Userspace__" 2017-07-16 weinrank CFLAGS: don't set Werror by default 2017-07-16 weinrank More strict compiler flags 2017-07-15 tuexen Sycn with sctp-idata. 2017-07-15 weinrank CMake beautification 2017-07-15 weinrank CMake cleanup 2017-07-14 weinrank CMAKE refactoring 2017-07-13 weinrank correct include_directories path 2017-07-12 weinrank CMAKE refactoring 2017-07-11 weinrank ignore build directory 2017-07-04 tuexen Sync with sctp-idata. 2017-06-25 tuexen Remove unused code on Windows (which would not work). 2017-06-25 tuexen This should dead code. Try on buildbot. 2017-06-25 tuexen More signed/unsigned issues. 2017-06-25 tuexen Address some signed/unsigned issues. 2017-06-25 tuexen Improve build scripts. 2017-06-25 tuexen Silence a warning when using older versions of clang. 2017-06-25 tuexen Silence a warning showing up on clang 4. 2017-06-25 tuexen I missed this in the last commit... 2017-06-25 tuexen Remove datachan_serv.c. 2017-06-25 tuexen Address signess issues. 2017-06-25 tuexen Address windows type mismatches. 2017-06-25 tuexen Fix a bug reported in https://github.com/sctplab/usrsctp/pull/150/files 2017-06-25 tuexen Use lowercase names for include files. 2017-06-23 tuexen Sync with El Capitan sources. 2017-06-23 tuexen Sync with sctp-idata. 2017-06-23 tuexen Sync FBSDID. 2017-06-23 tuexen Fix FreeBSD compilation. 2017-06-23 tuexen Add -Wno-address-of-packed-member to build system. 2017-06-23 tuexen Sync with FreeBSD sources. 2017-05-15 anselm.scholl Fix truncation with snprintf in buffer: Created with: roll-dep src/third_party/usrsctp/usrsctplib BUG= 749197 Change-Id: If6d161e71dc1596d82f3c81c82ad896bec0a4732 Reviewed-on: https://chromium-review.googlesource.com/601051 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491912} [modify] https://crrev.com/0b5aa967f47d7c575feaeafe2527e9051112f60c/DEPS [modify] https://crrev.com/0b5aa967f47d7c575feaeafe2527e9051112f60c/third_party/usrsctp/BUILD.gn [modify] https://crrev.com/0b5aa967f47d7c575feaeafe2527e9051112f60c/third_party/usrsctp/README.chromium
,
Aug 4 2017
Seems to have worked this time: https://luci-milo.appspot.com/buildbot/chromium.fyi/ClangToTWin(dll)/7801 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by h...@chromium.org
, Jul 26 2017