Issue metadata
Sign in to add a comment
|
base::Histogram::ValidateHistogramContents crash on Windows & Mac |
||||||||||||||||||||||
Issue descriptionbase::Histogram::ValidateHistogramContents crash on Windows. Split this off from crbug.com/744734 because the underlying issue is separate from the Android crashes and the CL https://chromium-review.googlesource.com/583292 I landed addressed the Windows crashes. Want to use this bug to merge that CL to M61.
,
Jul 26 2017
,
Jul 27 2017
+govind: friendly ping for merge I'd like to merge this to M61 to stop these crashes on that branch.
,
Jul 27 2017
Before we approve merge to M61 branch 3163, could you please confirm change is well baked/verified in Canary, having enough automation tests coverage and will be a safe merge to M61?
,
Jul 27 2017
Yes. Windows & Mac canaries no longer show ValidateHistogramContents() as top crasher. However, it's still #2 crasher in current Windows dev (M61) release: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2761.0.3163.13%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27dev%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D Hence why I want to get it merged to pick up the fix. The code does get exercised by tests, although unfortunately there's no test coverage for the specific issue being fixed (since it relies on corrupted/partial data in persistent histograms files).
,
Jul 27 2017
Approving merge to M61 branch 3163 based on comment #5. Please merge ASAP. Thank you.
,
Jul 27 2017
,
Jul 27 2017
,
Jul 27 2017
Per comment #8, this is already merged to M61.
,
Jul 28 2017
The crashes with magic signature 'base::Histogram::ValidateHistogramContents' are seen on the latest Windows Asan builds. Link to the list of the Windows crashes: ========================================= https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3AHistogram%3A%3AValidateHistogramContents%27%20AND%20product.name%3D%27Chrome%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports:5,productversion:1000 asvitkine@: Could you please take a look at these crashes from Windows Asan builds and help in further investigation. Thanks in advance!
,
Jul 28 2017
The remaining crashes on SyzyASAN builds are a duplicate of crbug.com/588946 since they all have kaspersky loaded. The instrumentation just made it crash in a different place: https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3AHistogram%3A%3AValidateHistogramContents%27%20AND%20product.name%3D%27Chrome%27%20AND%20product.Version%3D%2762.0.3168.1%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports:5,+3rdparty So closing this since the non-Kaspersky ones are fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by asvitk...@chromium.org
, Jul 26 2017