unit_tests BookmarkBarControllerTest.TestClearOnDealloc fails on 10.13 |
|||
Issue descriptionChrome Version: 5f9df04869c13d09182e36ad8f1c7192e0389214 OS: macOS 10.13 High Sierra What steps will reproduce the problem? (1) Run unit_tests on 10.13 (2) BookmarkBarControllerTest.TestClearOnDealloc fails BookmarkBarControllerTest.TestClearOnDealloc (run #1): [ RUN ] BookmarkBarControllerTest.TestClearOnDealloc ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1446: Failure Value of: [button delegate] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1447: Failure Value of: [button target] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1448: Failure Value of: [button action] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1446: Failure Value of: [button delegate] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1447: Failure Value of: [button target] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1448: Failure Value of: [button action] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1446: Failure Value of: [button delegate] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1447: Failure Value of: [button target] Actual: true Expected: false ../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1448: Failure Value of: [button action] Actual: true Expected: false [ FAILED ] BookmarkBarControllerTest.TestClearOnDealloc (91 ms) There may be some changes to autorelease pools on 10.13 (see issue 749176 and issue 748518 ). What is the expected result? Test passes What happens instead? Test fails Please use labels and text to provide additional information. Job: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/6 Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F6%2F%2B%2Frecipes%2Fsteps%2Funit_tests%2F0%2Flogs%2FBookmarkBarControllerTest.TestClearOnDealloc%2F0 For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 29 2018
Mac CQ will be upgraded to 10.13 over the coming 3-4 weeks. Please see issue 805475 for more details. Please resolve 10.13 blockers asap.
,
Feb 2 2018
@lgrey the mac CQ migration is starting, please do let us know if you'll be able to address this over the next week?
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaef95eb843a160ace9e802ebf6b45ac1d509292 commit eaef95eb843a160ace9e802ebf6b45ac1d509292 Author: Leonard Grey <lgrey@chromium.org> Date: Mon Feb 05 18:45:01 2018 [Mac] Fix BookmarkBarControllerTest.TestClearOnDealloc Bug: 749179 Change-Id: Idbe0206a509379f68b2b215be710a24b2da450be Reviewed-on: https://chromium-review.googlesource.com/902022 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#534437} [modify] https://crrev.com/eaef95eb843a160ace9e802ebf6b45ac1d509292/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
,
Feb 13 2018
Fixed: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/1097 |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Aug 23 2017