New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749176 link

Starred by 1 user
Status: Duplicate
Merged: issue 749179
Owner:
tapted@chromium.org
Closed: Aug 2017
Cc:
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 749196
Blocking:
issue 748242



Sign in to add a comment

BookmarkBarControllerTest.TestClearOnDealloc fails on 10.13

Project Member Reported by rsesek@chromium.org, Jul 26 2017 
Chrome Version: 5f9df04869c13d09182e36ad8f1c7192e0389214
OS: macOS 10.13 High Sierra

What steps will reproduce the problem?
(1) Run unit_tests on 10.13
(2) Several tests fail with the following message:

../../ui/gfx/test/ui_cocoa_test_helper.mm:189: Failure
      Expected: 0U
      Which is: 0
To be equal to: windows_left.size()
      Which is: 1
[72029:775:0725/223415.074090:23385524366801:WARNING:ui_cocoa_test_helper.mm(193)] Didn't close window <NSWindow: 0x7fec4616d470>

The tests that fail this way are:
BaseBubbleControllerTest.MouseDownInChildWindow
BaseBubbleControllerTest.ResignKeyCloses
BookmarkBarControllerTest.EventToExitCheck
BookmarkBarFolderControllerTest.ChildFolderWidth
BookmarkBarFolderControllerTest.MenuPlacementWhileScrollingDeleting
BookmarkBarFolderControllerTest.ScrollingBehaviorAndMouseMovement
ConstrainedWindowAlertTest.AccessoryView
ConstrainedWindowAlertTest.LinkView
ConstrainedWindowAlertTest.NoButtons
ConstrainedWindowAlertTest.Show
ScreenCaptureNotificationUICocoaTest.ClickStop
ScreenCaptureNotificationUICocoaTest.CreateAndStart
ScreenCaptureNotificationUICocoaTest.LongTitle
ScreenCaptureNotificationUICocoaTest.MinimizeWindow
ScreenCaptureNotificationUICocoaTest.ShortTitle

This may be similar to  issue 748518  since it deals with windows and autorelease pools.

What is the expected result?
Test passes

What happens instead?
Test fails

Please use labels and text to provide additional information.

Job: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/6
Logs: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/6


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by spqc...@chromium.org, Jul 26 2017

Cc: -tapted@chromium.org
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
[mac triage] Assigning to tapted@ since he's also looking at  Issue 748518 , which may be related. Feel free to reassign or toss this back to the untriage queue

Comment 2 by tapted@chromium.org, Aug 10 2017

Blockedon: 749196
Cc: shrike@chromium.org
Summary: BookmarkBarControllerTest.TestClearOnDealloc fails on 10.13 (was: unit_tests fail with "Didn't close window" error from cocoa_test_helper.mm on 10.13)
This seems improved in beta 4 and beta 5 (macOS 10.13 (17A330h))

beta 4 - https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/57

beta 5 - ninja -C out/gn_os1013 unit_tests && out/gn_os1013/unit_tests --gtest_filter=ScreenCaptureNotificationUICocoaTest.*:ConstrainedWindowAlertTest.*:BookmarkBarFolderControllerTest.*:BookmarkBarControllerTest.*:BaseBubbleControllerTest.*

results in just one failure:

[ RUN      ] BookmarkBarControllerTest.TestClearOnDealloc
../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1446: Failure
Value of: [button delegate]
  Actual: true
Expected: false
../../chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:1447: Failure
Value of: [button target]
  Actual: true
Expected: false
(repeats)

Likely this is the same as  Issue 749196 . This test case might give a nicer thing for diagnosis though.

Comment 3 by tapted@chromium.org, Aug 23 2017

Mergedinto: 749179
Status: Duplicate (was: Assigned)
►

Sign in to add a comment