New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749172 link

Starred by 1 user
Status: Started
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Cc:
tbansal@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UKM effective connection type metric uses wrong EffectiveConnectionType

Project Member Reported by bmcquade@chromium.org, Jul 26 2017 
The UKM page load metrics observer records the effective connection type at navigation start, for each tracked page load.

However, it records a net::EffectiveConnectionType enum, when we really want to record the EffectiveConnectionType in SystemProfileProto.

We should deprecate the existing metric, and add a new one that records the proper enum.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e

commit a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e
Author: Bryan McQuade <bmcquade@chromium.org>
Date: Tue Aug 01 16:41:29 2017

Log EffectiveConnectionType from SystemProfileProto in UKM.

Previously, we logged the net::EffectiveConnectionType when a
new page load was started, however this enum is not intended
to be persisted. This change moves to logging the
SystemProfileProto version instead.

Bug: 749172
Change-Id: I1a7ab46fea6adedf5bf7d5ecae904ce796da83cd
Reviewed-on: https://chromium-review.googlesource.com/587467
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491014}
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/components/metrics/net/network_metrics_provider.cc
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/components/metrics/net/network_metrics_provider.h
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/components/metrics/proto/system_profile.proto
[modify] https://crrev.com/a4aa9d6cdc875cd4d4f97e62b63eb3ac494ed25e/tools/metrics/ukm/ukm.xml
►

Sign in to add a comment