New issue
Advanced search Search tips

Issue 749164 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

git cl upload fails on command line but patch is still uploaded.

Project Member Reported by karandeepb@chromium.org, Jul 26 2017

Issue description

This happened with the following CL - https://chromium-review.googlesource.com/c/576468.

I ran git cl upload (the branch was tracking a change which had already been submitted). The upload failed and recommended to do git cl creds-check. However on checking the codereview site, I found that the patch had been uploaded.

 

Comment 1 by aga...@chromium.org, Jul 26 2017

Can you make sure that your ~/.gitcookies file contains lines for chromium.googlesource and chromium-review.googlesource, and that both reference your chromium.org address?

Comment 2 by aga...@chromium.org, Jul 26 2017

Oh, and that you don't have a plain "googlesource.com" entry in the file -- those wildcard entries mess things up.
I had a single line entry starting from-

.googlesource.com	TRUE	/	TRUE 

Can you point me to how should I go about correcting this?

Comment 4 by aga...@chromium.org, Jul 26 2017

Remove that entry, navigate to chromium.googlesource.com/new-password, sign in with your @chromium account, and follow the instructions there.
Thanks, still keeping the issue open since don't think that "git cl upload" should upload the patch with the command failing on the command line.

Comment 6 by aga...@chromium.org, Jul 26 2017

The problem is that it has to do many consecutive operations: some api calls at the beginning, then an actual git push, then some more API calls at the end. It ensures that you have credentials at the start, but that doesn't mean that all of the API calls will succeed (if authenticating with the wrong account, especially, some of the post-push API calls might fail because they change state rather than just reading it). And if one of the post-push calls fails, well, the change has already been pushed. We can't un-upload the change, obviously.
Status: Archived (was: Untriaged)

Sign in to add a comment