New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749161 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Switch shill APIs for MAC address randomization and remove old constants

Project Member Reported by ejcaruso@chromium.org, Jul 26 2017

Issue description

After implementing the new MAC address randomization properties in shill, we should switch the Chrome API to use the new properties. After a week or so we can remove the old properties.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/ddbebf528829258e048e85fb1d57a9b8b3be45d7

commit ddbebf528829258e048e85fb1d57a9b8b3be45d7
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Sep 25 22:52:42 2017

wifi: remove old MAC address randomization property

This property is deprecated and Chrome has been using the new one
for over a month so this should be fine to remove.

BUG= chromium:749161 
TEST=emerge

Change-Id: Ibfddff8d04f4e0757e1a4eb83de58655194621f3
Reviewed-on: https://chromium-review.googlesource.com/679234
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/ddbebf528829258e048e85fb1d57a9b8b3be45d7/wifi/wifi.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/982cf9d3cbbd81df8201ae8ca7901d101574c0e6

commit 982cf9d3cbbd81df8201ae8ca7901d101574c0e6
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Sep 25 22:52:43 2017

dbus-constants: remove old MAC address randomization constant

We switched to having one property for support and one for
whether or not it's enabled, and it's been in for over a month,
so it should be OK to remove the old property now.

CQ-DEPEND=CL:679234
BUG= chromium:749161 
TEST=emerge

Change-Id: I09ba7da90e3f1ce1fe6419fa2aabec2554375ca0
Reviewed-on: https://chromium-review.googlesource.com/679096
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/982cf9d3cbbd81df8201ae8ca7901d101574c0e6/dbus/shill/dbus-constants.h

Status: Fixed (was: Assigned)
The next cros_system_api uprev will delete the constant in Chrome, at which point it's gone from everywhere. Marking as fixed.

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Status: Verified (was: Fixed)

Sign in to add a comment