Enable cast_graphics_unittests on Cast Linux builder |
||
Issue descriptioncast_graphics_unittests were broken by https://chromium-review.googlesource.com/c/549118/ [ RUN ] CastFocusClientAuraTest.ChildFocus cast_graphics_unittests: ../../mojo/public/c/system/thunks.cc:35: MojoResult MojoCreateMessagePipe(const MojoCreateMessagePipeOptions *, MojoHandle *, MojoHandle *): Assertion `g_thunks.CreateMessagePipe' failed. Received signal 6 #0 0x0000011ad6ad base::debug::StackTrace::StackTrace() #1 0x0000011abeac base::debug::StackTrace::StackTrace() #2 0x0000011ad16f base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fdfdb798330 <unknown> #4 0x7fdfda982c37 gsignal #5 0x7fdfda986028 abort #6 0x7fdfda97bbf6 <unknown> #7 0x7fdfda97bca2 __assert_fail #8 0x0000024ec846 MojoCreateMessagePipe #9 0x000000d96c19 mojo::CreateMessagePipe() #10 0x000000d96806 mojo::MessagePipe::MessagePipe() #11 0x0000030482e7 mojo::MakeRequest<>() #12 0x000003047fd8 (anonymous namespace)::ConnectFrameSinkManager() #13 0x000003047f2f ui::InitializeContextFactoryForTests() #14 0x000001012634 aura::test::AuraTestBase::SetUp() #15 0x000000f30e0e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #16 0x000000f24bf2 testing::internal::HandleExceptionsInMethodIfSupported<>() #17 0x000000f0f064 testing::Test::Run() #18 0x000000f0fc0d testing::TestInfo::Run() #19 0x000000f1066c testing::TestCase::Run() #20 0x000000f1c29c testing::internal::UnitTestImpl::RunAllTests() #21 0x000000f3182e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #22 0x000000f26232 testing::internal::HandleExceptionsInMethodIfSupported<>() #23 0x000000f1beda testing::UnitTest::Run() #24 0x000000f35341 RUN_ALL_TESTS() #25 0x000000f32ece base::TestSuite::Run() #26 0x00000042356d _ZN4base8internal13FunctorTraitsIMNS_9TestSuiteEFivEvE6InvokeIP27ChromecastGraphicsTestSuiteJEEEiS4_OT_DpOT0_ #27 0x0000004234b4 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMNS_9TestSuiteEFivEJP27ChromecastGraphicsTestSuiteEEEiOT_DpOT0_ #28 0x000000423465 _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperI27ChromecastGraphicsTestSuiteEEEEEFivEE7RunImplIRKS5_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #29 0x00000042337c _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperI27ChromecastGraphicsTestSuiteEEEEEFivEE3RunEPNS0_13BindStateBaseE #30 0x0000007cdf8d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #31 0x000000f37587 base::(anonymous namespace)::LaunchUnitTestsInternal() #32 0x000000f373f5 base::LaunchUnitTests() #33 0x000000422a3a main #34 0x7fdfda96df45 __libc_start_main #35 0x000000415e74 <unknown> r8: 00005171cb32f3e8 r9: 00005171cb32f3d8 r10: 0000000000000008 r11: 0000000000000206 r12: 000000000395d763 r13: 000000000395d77e r14: 0000000000000000 r15: 0000000000000000 di: 0000000000005ea6 si: 0000000000005ea6 bp: 00007fdfdaad0018 bx: 00007fdfdbbc2000 dx: 0000000000000006 ax: 0000000000000000 cx: 00007fdfda982c37 sp: 00007ffcba804368 ip: 00007fdfda982c37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. [32/32] CastFocusClientAuraTest.ChildFocus (CRASHED) 8 tests crashed: CastFocusClientAuraTest.ChildFocus (../../chromecast/graphics/cast_focus_client_aura_test.cc:69) CastFocusClientAuraTest.FocusableWindows (../../chromecast/graphics/cast_focus_client_aura_test.cc:35) CastFocusClientAuraTest.ZOrder (../../chromecast/graphics/cast_focus_client_aura_test.cc:105) CastFocusClientAuraTest.ZOrderWithChildWindows (../../chromecast/graphics/cast_focus_client_aura_test.cc:158) CastViewsTest.ProgressBar (../../chromecast/graphics/cast_views_test.cc:16) CastWindowManagerAuraTest.InitialWindowId (../../chromecast/graphics/cast_window_manager_aura_test.cc:38) CastWindowManagerAuraTest.WindowInput (../../chromecast/graphics/cast_window_manager_aura_test.cc:48) CastWindowManagerAuraTest.WindowInputDisabled (../../chromecast/graphics/cast_window_manager_aura_test.cc:76) Add the cast_graphics_unittests to the Cast Linux builder so these breakages are caught earlier
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5aded5a46e516b5bc2f8a0daea3c3fbbd0bee066 commit 5aded5a46e516b5bc2f8a0daea3c3fbbd0bee066 Author: Mike Bjorge <mbjorge@chromium.org> Date: Wed Jul 26 23:13:09 2017 [Chromecast] Init Mojo in cast_graphics_unittests https://chromium-review.googlesource.com/c/549118/ added a requirement that test targets using ui::InitializeContextFactoryForTests() initialize the mojo::edk. Bug: 657959, 749144 Test: cast_graphics_unittests Change-Id: Ibdd7ff732eed4c74a9e5f2160b1b42b34cae75d6 Reviewed-on: https://chromium-review.googlesource.com/587127 Reviewed-by: Alok Priyadarshi <alokp@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#489792} [modify] https://crrev.com/5aded5a46e516b5bc2f8a0daea3c3fbbd0bee066/chromecast/graphics/BUILD.gn [modify] https://crrev.com/5aded5a46e516b5bc2f8a0daea3c3fbbd0bee066/chromecast/graphics/DEPS [modify] https://crrev.com/5aded5a46e516b5bc2f8a0daea3c3fbbd0bee066/chromecast/graphics/run_all_unittests.cc
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d479891e1d93bf7785dba2443e94a009b96c6303 commit d479891e1d93bf7785dba2443e94a009b96c6303 Author: Mike Bjorge <mbjorge@chromium.org> Date: Thu Jul 27 23:12:16 2017 [Chromecast] Run cast_graphics_unittests on Cast Linux. cast_graphics_unittests didn't get updated in https://chromium-review.googlesource.com/c/549118/ because the tests didn't get run, so the breakage was invisible. BUG= 749144 TEST=cast_graphics_unittests Change-Id: Ib6d62550187b29a6adab7021bda62f0a9ddd2338 Reviewed-on: https://chromium-review.googlesource.com/587351 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#490072} [modify] https://crrev.com/d479891e1d93bf7785dba2443e94a009b96c6303/testing/buildbot/chromium.linux.json [modify] https://crrev.com/d479891e1d93bf7785dba2443e94a009b96c6303/testing/buildbot/gn_isolate_map.pyl
,
Jul 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mbjorge@chromium.org
, Jul 26 2017