New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749142 link

Starred by 1 user
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Mac] Bookmark bar item focus ring 1pt too high on macOS 10.12

Project Member Reported by shrike@chromium.org, Jul 26 2017 
Chrome Version: 61.0.3137.0 (it's been broken for awhile)
OS: macOS 10.12

What steps will reproduce the problem?
(1) Turn on keyboard focus for all controls
(2) Tab into items in the bookmarks bar

What is the expected result?
The focus ring should be centered around each item.

What happens instead?
The focus ring is 1pt too high.
Screen Shot 2017-07-26 at 9.32.08 AM.png
6.8 KB View Download
Screen Shot 2017-07-26 at 9.32.13 AM.png
7.6 KB View Download
Screen Shot 2017-07-26 at 9.38.26 AM.png
6.1 KB View Download
Screen Shot 2017-07-26 at 9.38.30 AM.png
4.6 KB View Download

Comment 1 by shrike@chromium.org, Jul 26 2017 

After the fix.
Screen Shot 2017-07-26 at 9.40.27 AM.png
5.1 KB View Download
Screen Shot 2017-07-26 at 9.40.35 AM.png
5.7 KB View Download
Screen Shot 2017-07-26 at 9.40.42 AM.png
5.2 KB View Download
Screen Shot 2017-07-26 at 9.40.46 AM.png
4.6 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d31acb63af369e644def7ec5392b35de345c5e5

commit 6d31acb63af369e644def7ec5392b35de345c5e5
Author: Jayson Adams <shrike@chromium.org>
Date: Wed Jul 26 17:49:08 2017

[Mac] Center bookmark bar item focus rings on 10.12 and up.

On Sierra and higher the bookmark bar item focus rings are 1pt higher
than they should be. This cl adjusts them down by 1 pt.

R=avi@chromium.org

Bug:  749142 
Change-Id: I92c7f00be540bdcaf55c872018b20464ef05bd5b
Reviewed-on: https://chromium-review.googlesource.com/587036
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489687}
[modify] https://crrev.com/6d31acb63af369e644def7ec5392b35de345c5e5/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Comment 3 by shrike@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment