In UI Devtools, show distances when a pinned UIElement contains or is contained by a hovered UIElement while in inspection mode |
|||||||||
Issue descriptionIn Chrome UI Devtools, when users enter the inspection mode and pin an element by left-clicking on a window/widget or view on the Chrome UI, when user moves the cursor outside of the current UIElement, if the pinned UIElement contains or is contained by the hovered UIElement, the layout will display the 4 distances between the pinned UIElement and the UIElement under cursor as shown in picture below. If users click on another UIElement, this UIElement will become pinned instead. This bug refers to case R1_CONTAINS_R2.
,
Jul 26 2017
Since your design document isn't linked in this bug (and also it is not visible by everyone who is able to view this bug), then mentioning "R1_CONTAINS_R2" in your bug description might be a bit confusing. Consider re-wording the description and attaching a diagram/picture/screenshot to clarify your intended scope of this bug.
,
Jul 26 2017
Good call, I added an illustrative picture.
,
Jul 26 2017
,
Jul 26 2017
,
Jul 26 2017
,
Jul 26 2017
,
Jul 27 2017
,
Jul 31 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c commit a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c Author: Thanh Pham <thanhph@chromium.org> Date: Wed Aug 30 20:36:57 2017 Show distances when a pinned UIElement contains or is contained by a hovered UIElement while in inspection mode. In Chrome UI Devtools, when users enter the inspection mode and pin an element by left-clicking on a window/widget or view on the Chrome UI, when user moves the cursor outside of the current UIElement, if the pinned UIElement contains or is contained by the hovered UIElement, the layout will display the 4 distances between the pinned UIElement and the UIElement under cursor as shown in picture below. If users click on another UIElement, this UIElement will become pinned instead. This bug refers to case R1_CONTAINS_R2. Bug: 749133 Change-Id: I8c1e831eff9783b91ae4beca96cccfc92185ccff Reviewed-on: https://chromium-review.googlesource.com/586575 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#498595} [modify] https://crrev.com/a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c/components/ui_devtools/views/ui_devtools_dom_agent.cc [modify] https://crrev.com/a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c/components/ui_devtools/views/ui_devtools_dom_agent.h [modify] https://crrev.com/a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c/components/ui_devtools/views/ui_devtools_overlay_agent.cc [modify] https://crrev.com/a2b2cc65e81bc2ed6219b240bb5338bf7aacfe7c/components/ui_devtools/views/ui_devtools_unittest.cc
,
Aug 30 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by thanhph@chromium.org
, Jul 26 2017Summary: Show distances when a pinned UIElement contains or is contained by a hovered UIElement while in inspection mode (was: Show distances when a pinned UIElement contains a hovered UIElement while in inspection mode)