New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749131 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add accessibility custom actions for ContentSuggestions item

Project Member Reported by gambard@chromium.org, Jul 26 2017 
The cells displayed in ContentSuggestions should have quick actions accessible from voice over. As all actions are accessible through gestures, we need to add a way to have them accessible.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7405f12a6a7d3a897a4660c83cf7dea538bf18a6

commit 7405f12a6a7d3a897a4660c83cf7dea538bf18a6
Author: gambard <gambard@chromium.org>
Date: Tue Aug 01 09:55:00 2017

Add AccessibilityCustomAction to ContentSuggestions

In order to have the feature accessible, all the actions using gestures
(long press, swipe to dismiss) must have custom accessibility actions.
Also adds action sheet to Read Later cells.

Bug:  749131 
Change-Id: I2c81f6443a49bdf0cdccc3ec747b0ffd42513ef1
Reviewed-on: https://chromium-review.googlesource.com/593652
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490930}
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/BUILD.gn
[delete] https://crrev.com/12af72412d3a767b6d2ce5ab607ca05f30afb011/ios/chrome/browser/content_suggestions/content_suggestions_alert_commands.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_alert_egtest.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_gesture_commands.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/7405f12a6a7d3a897a4660c83cf7dea538bf18a6/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by gambard@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)
Summary: Add accessibility custom actions for ContentSuggestions item (was: Add quick actions for ContentSuggestions item)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28cefc4bbf5691f312540a8d50097b9be8079639

commit 28cefc4bbf5691f312540a8d50097b9be8079639
Author: Menglu Huang <huangml@chromium.org>
Date: Tue Aug 01 20:04:04 2017

Revert "Add AccessibilityCustomAction to ContentSuggestions"

This reverts commit 7405f12a6a7d3a897a4660c83cf7dea538bf18a6.

Reason for revert: <INSERT REASONING HERE>
This CL breaks ios_showcase_tests.
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/30194

Original change's description:
> Add AccessibilityCustomAction to ContentSuggestions
> 
> In order to have the feature accessible, all the actions using gestures
> (long press, swipe to dismiss) must have custom accessibility actions.
> Also adds action sheet to Read Later cells.
> 
> Bug:  749131 
> Change-Id: I2c81f6443a49bdf0cdccc3ec747b0ffd42513ef1
> Reviewed-on: https://chromium-review.googlesource.com/593652
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Jean-François Geyelin <jif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490930}

TBR=jif@chromium.org,gambard@chromium.org

Change-Id: I805e907403106623dc9c67cc89ccbbc5546d0ee1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  749131 
Reviewed-on: https://chromium-review.googlesource.com/596591
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491088}
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/BUILD.gn
[add] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_alert_commands.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_alert_egtest.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[delete] https://crrev.com/dba6bbe475138e8636d03d342d86eb0d973401a9/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_gesture_commands.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/28cefc4bbf5691f312540a8d50097b9be8079639/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 4 by gambard@chromium.org, Aug 2 2017

Status: Assigned (was: Fixed)

Comment 5 by mvanouwe...@chromium.org, Aug 2 2017

Labels: zine-triaged
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3919f617774c3af14c01de83bd4bd0d46e0de6

commit fb3919f617774c3af14c01de83bd4bd0d46e0de6
Author: gambard <gambard@chromium.org>
Date: Wed Aug 02 13:40:14 2017

Relad of "Add AccessibilityCustomAction to ContentSuggestions"

In order to have the feature accessible, all the actions using gestures
(long press, swipe to dismiss) must have custom accessibility actions.
Also adds action sheet to Read Later cells.

Bug:  749131 
Change-Id: I49171acf34b897035c998b8f0f8186bc6484d878
Reviewed-on: https://chromium-review.googlesource.com/597600
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491358}
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/BUILD.gn
[delete] https://crrev.com/361a25f627548bfcda8a75ef95eb23de083a489a/ios/chrome/browser/content_suggestions/content_suggestions_alert_commands.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_alert_egtest.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_gesture_commands.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/fb3919f617774c3af14c01de83bd4bd0d46e0de6/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm

Comment 7 by gambard@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)

Comment 8 by rakurati@chromium.org, Aug 8 2017

Status: Verified (was: Fixed)
Verified on canary build 62.0.3179.0 in iPad Air(iOS 11 beta5), iPhone 6plus(iOS 11 beta5) and iPad (iOS 10.3.3)

Voice over and other accessible actions like dismiss and long press is working good for reading list and content suggestions in NTP.
►

Sign in to add a comment