New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749125 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

The title of the ContentSuggestions sections should be display only if there is more than one section

Project Member Reported by gambard@chromium.org, Jul 26 2017

Issue description

See summary
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e037be1c4dcb0903bd7ec14844e66af79c8afe7

commit 7e037be1c4dcb0903bd7ec14844e66af79c8afe7
Author: gambard <gambard@chromium.org>
Date: Wed Aug 02 14:43:40 2017

Don't show section title if there is one section

The titles should be shown only if there are more than two sections.
This applies only to the section from ContentSuggestionsService.

Bug:  749125 
Change-Id: If9d8320baa9f5cad287d47b70202cbe203f06727
Reviewed-on: https://chromium-review.googlesource.com/596050
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491370}
[modify] https://crrev.com/7e037be1c4dcb0903bd7ec14844e66af79c8afe7/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

Status: Fixed (was: Assigned)
To test:
Open NTP
If there are Reading List and Articles for You suggestions, both should have a title.
If there is only one (Articles for You), no title should be displayed.
An empty but displayed section is the same as a non-empty displayed section.
Status: Verified (was: Fixed)
Verified in 62.0.3179.0 canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11

When there are Reading List and Articles for You suggestions, both have a title.
When there is only one (Articles for You), no title is displayed.

Looks good.

Sign in to add a comment