The title of the ContentSuggestions sections should be display only if there is more than one section |
|||
Issue descriptionSee summary
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e037be1c4dcb0903bd7ec14844e66af79c8afe7 commit 7e037be1c4dcb0903bd7ec14844e66af79c8afe7 Author: gambard <gambard@chromium.org> Date: Wed Aug 02 14:43:40 2017 Don't show section title if there is one section The titles should be shown only if there are more than two sections. This applies only to the section from ContentSuggestionsService. Bug: 749125 Change-Id: If9d8320baa9f5cad287d47b70202cbe203f06727 Reviewed-on: https://chromium-review.googlesource.com/596050 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#491370} [modify] https://crrev.com/7e037be1c4dcb0903bd7ec14844e66af79c8afe7/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
,
Aug 2 2017
,
Aug 2 2017
To test: Open NTP If there are Reading List and Articles for You suggestions, both should have a title. If there is only one (Articles for You), no title should be displayed. An empty but displayed section is the same as a non-empty displayed section.
,
Aug 8 2017
Verified in 62.0.3179.0 canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 When there are Reading List and Articles for You suggestions, both have a title. When there is only one (Articles for You), no title is displayed. Looks good. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mvanouwe...@chromium.org
, Aug 2 2017