Potential memory leak with DiscardableSharedMemoryManager |
||||
Issue descriptionI ran the extension provided in: https://bugs.chromium.org/p/chromium/issues/detail?id=707136 which basically 1) open tab 2) navigate to google.com 3) close tab 4) repeat After a day, the browser process was using 1.3G of memory. The browser is running with native heap profiling activated. By looking to a memory dump, we can determine that there is 11M objects still alive allocated with the stackframe provided as attachment.
,
Jul 26 2017
The bug was introduced here: https://codereview.chromium.org/809603004
,
Jul 27 2017
,
Aug 3 2017
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ae3ea1c2efcf9d2786cb1af66315b08f0a95051 commit 8ae3ea1c2efcf9d2786cb1af66315b08f0a95051 Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Aug 07 18:50:33 2017 Fix memory leak with shared discardable memory tracking. The set |locked_pages_| is improperly updated on a Unmap. Locked pages are released and should not be kept in the set. The counter |locked_page_count_| was also incorrectly updated. But, it was in-sync with the size of |locked_pages_|. The bug was introduced here: https://codereview.chromium.org/809603004 See crbug/749115 for more details. R=danakj@chromium.org Bug: 749115 Change-Id: I825ef3b03ca6fd4b91588fcb882013baac51a1db Reviewed-on: https://chromium-review.googlesource.com/587970 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#492372} [modify] https://crrev.com/8ae3ea1c2efcf9d2786cb1af66315b08f0a95051/base/memory/discardable_shared_memory.cc [modify] https://crrev.com/8ae3ea1c2efcf9d2786cb1af66315b08f0a95051/base/memory/discardable_shared_memory.h
,
Sep 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by etienneb@chromium.org
, Jul 26 2017