New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749113 link

Starred by 1 user
Status: WontFix
Owner:
█ rlanday@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
twelling...@chromium.org
█ aelias@chromium.org
█ zpeng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

30.3KB regression in resource_sizes (MonochromePublic.apk) at 489505:489505

Project Member Reported by zpeng@chromium.org, Jul 26 2017 
Caused by “Add support for Android spellcheck menu in Chrome/WebViews”

Commit: e4a6ec83ec32b4f139794f39bf2cbb0b25617b56

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=489505

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 26 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=749113

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3310aa3dba78b13a1f247cfbed0e92be51711334d5ca2aebd6cc627f021ec6f6


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by zpeng@chromium.org, Jul 26 2017

diff_results.txt
70.1 KB View Download

Comment 3 by rlanday@chromium.org, Jul 26 2017

Cc: twelling...@chromium.org aelias@chromium.org
We did add about 2000 lines of code in this CL to implement a new feature, so I'm not surprised it's making the APK bigger (although admittedly I hadn't measured the difference).

The breakdown (from diff_results.txt) is as follows:

MonochromePublic.apk_Uncompressed (+30,394 bytes)
      +160 bytes Native resources (no l10n) size
        +0 bytes ICU (i18n library) data size
        +0 bytes Unknown files size
    +3,560 bytes Non-compiled Android resources size
        +0 bytes V8 Snapshots size
        +0 bytes Native resources (l10n) size
   +16,384 bytes Native code size
        +0 bytes PNG drawables size
      +978 bytes Package metadata size
        +0 bytes licenses.notice file size
        +0 bytes Native resources stored (l10n) size
    +5,508 bytes Java code size
    +3,804 bytes Compiled Android resources size

Seems like Mojo generates quite a bit of code, doubt there's much we can do about that.

Comment 4 by rlanday@chromium.org, Jul 26 2017

Status: WontFix (was: Assigned)
I think this is expected

Comment 5 by aelias@chromium.org, Jul 26 2017 

FWIW, http://crbug.com/689690 is filed on making Mojo less bloated in general.
►

Sign in to add a comment