New issue
Advanced search Search tips

Issue 749108 link

Starred by 3 users
Status: Fixed
Owner:
tapted@chromium.org
Closed: Jun 2018
Cc:
phanindra.mandapaka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

On macOS, Ctrl+F5 should move to the window's toolbar.

Project Member Reported by dmazz...@chromium.org, Jul 26 2017 
You can find this in System Preferences > Keyboard > Shortcuts > Keyboard.

I think this did work a long, long time ago, not sure what changed. Try it in Safari, it moves focus to the first toolbar button.

To @tapted to triage or delegate. Would be nice to fix for Cocoa now but also possibly for MacViews later.

Comment 1 by tapted@chromium.org, May 31 2018 

Ctrl+f5 is one of a class of commands configurable in System Preferences under Keyboard -> Shortcuts -> Keyboard.

Ctrl+F7 we already handle via com.apple.KeyboardUIModeDidChange and [[NSDistributedNotificationCenter defaultCenter] (it changes [NSApp isFullKeyboardAccessEnabled]).

Ctrl+f1 also sends com.apple.KeyboardUIModeDidChange - it has the effect of disabling Ctrl+F2 through to Ctrl+F6
Ctrl+f2,f3,f4,f8 are handled by the system

That leaves f5 and f6.

After doing some tracing, I discovered _handleFocusToolbarHotKey:, which is being sent to the key window. For the browser, this is BrowserNativeWidgetWindow
Screen Shot 2018-05-31 at 2.50.57 pm.png
135 KB View Download

Comment 2 by tapted@chromium.org, May 31 2018

Status: Started (was: Assigned)
seems simple enough https://chromium-review.googlesource.com/#/c/1080439/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3ad388678248130cec2cf8f75bc6af93343241

commit 9d3ad388678248130cec2cf8f75bc6af93343241
Author: Trent Apted <tapted@chromium.org>
Date: Fri Jun 01 03:08:03 2018

MacViews: Handle Ctrl+F5 "Move focus to toolbar".

This is configured in System Preferences -> Keyboard -> Shortcuts ->
Keyboard. Turns out AppKit dispatches -_handleFocusToolbarHotKey: for it.

TEST=With chrome://flags/#views-browser-windows on Mac, have focus in
web contents. Press Ctrl+F5. Focus should move to the omnibox or a toolbar
button (Ctrl+F7 toggles this).

Bug:  749108 
Change-Id: I9f207112ede2eb250644fb4353557ac7d216bd91
Reviewed-on: https://chromium-review.googlesource.com/1080439
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563511}
[modify] https://crrev.com/9d3ad388678248130cec2cf8f75bc6af93343241/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm

Comment 4 by tapted@chromium.org, Jun 1 2018

Status: Fixed (was: Started)

Comment 5 by phanindra.mandapaka@chromium.org, Jun 4 2018

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M69 TE-Verified-69.0.3449.0
Able to reproduce the issue on chrome version M-50 (build without fix)
Verified the fix on Mac 10.13.3 using Chrome version #69.0.3449.0 as per the comment #3.
Attaching screecast for reference.
Observed that "focus moved to omnibox."
The fix is working as expected, adding Verified labels

Thanks...!
749108.mp4
697 KB View Download
►

Sign in to add a comment