The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d686a0dafd10e4a523e0cd7e2443ef5cd6edcb4

commit 9d686a0dafd10e4a523e0cd7e2443ef5cd6edcb4
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Jul 26 15:22:56 2017

Disable TestBeforeUnloadAndDownloads on ChromeOS

StreamsPrivateApiTest.DirectDownload is flaky on Win 10:

BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 is flaky (mostly failing) on Linux ChromiumOS Tests (dbg):

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28508
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserCloseManagerWithDownloadsBrowserTest%2FBrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads%2F1

This CL disables the test for now.

TBR=sky@chromium.org
NOTRY=true

Bug: 749098
Change-Id: Ida5fef85fa05f935cc1df19accb06d23f8d4b71f
Reviewed-on: https://chromium-review.googlesource.com/586919
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489650}
[modify] https://crrev.com/9d686a0dafd10e4a523e0cd7e2443ef5cd6edcb4/chrome/browser/lifetime/browser_close_manager_browsertest.cc

Looks like resource_coordinator::TabManager::GRCTabSignalObserver::OnEventReceived is doing something on a thread it shouldn't be.

The test times out on Win7 Tests (dbg)(1)

[ RUN      ] BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1
[4160:6612:0804/021037.502:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\ioxv64kw\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5920_12221\d5920_20151" --disable-offline-auto-reload --enable-fast-unload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5356:2648:0804/021038.327:ERROR:direct_composition_surface_win.cc(1073)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[5356:2648:0804/021038.361:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported.
[4160:4124:0804/021041.996:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[6464:3988:0804/021043.322:ERROR:render_process_impl.cc(176)] WebFrame LEAKED 1 TIMES
[280/297] BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 (TIMED OUT)

And quite flaky on Linux (e.g. Linux Tests (dbg)(1)(32)). See the flakiness dashboard.

[ RUN      ] BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1
Xlib:  extension "RANDR" missing on display ":99".
[16084:16084:0804/022346.227923:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[16084:16365:0804/022347.751092:WARNING:simple_synchronous_entry.cc(1101)] Could not open platform files for entry.
[16084:16395:0804/022347.937642:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[16084:16084:0804/022349.234077:FATAL:lock_impl_posix.cc(63)] Check failed: rv == 0 (22 vs. 0). Invalid argument
#0 0x0000f7234397 base::debug::StackTrace::StackTrace()
#1 0x0000f723239c base::debug::StackTrace::StackTrace()
#2 0x0000f72d35ee logging::LogMessage::~LogMessage()
#3 0x0000f7432fde base::internal::LockImpl::Lock()
#4 0x0000f71cfd38 base::Lock::Acquire()
#5 0x0000f71cf40a base::AutoLock::AutoLock()
#6 0x0000f73d303e base::SequenceCheckerImpl::CalledOnValidSequence()
#7 0x0000f742bf63 base::SupportsUserData::GetUserData()
#8 0x00000ca7bf45 content::WebContentsUserData<>::FromWebContents()
#9 0x00000ca8688f resource_coordinator::TabManager::GRCTabSignalObserver::OnEventReceived()
#10 0x0000e6503939 resource_coordinator::mojom::TabSignalObserverStubDispatch::Accept()
#11 0x00000ca8745b resource_coordinator::mojom::TabSignalObserverStub<>::Accept()
#12 0x0000f1fc57ff mojo::InterfaceEndpointClient::HandleValidatedMessage()
#13 0x0000f1fc41bd mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#14 0x0000f1fc250c mojo::FilterChain::Accept()
#15 0x0000f1fc89ea mojo::InterfaceEndpointClient::HandleIncomingMessage()
#16 0x0000f1fe4813 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#17 0x0000f1fe3cf8 mojo::internal::MultiplexRouter::Accept()
#18 0x0000f1fc250c mojo::FilterChain::Accept()
#19 0x0000f1fb227c mojo::Connector::ReadSingleMessage()
#20 0x0000f1fb3534 mojo::Connector::ReadAllAvailableMessages()
#21 0x0000f1fb32e6 mojo::Connector::OnHandleReadyInternal()
#22 0x0000f1fb317a mojo::Connector::OnWatcherHandleReady()
#23 0x0000f1fb75e2 _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIPS3_JjEEEvS5_OT_DpOT0_
#24 0x0000f1fb74f0 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_
#25 0x0000f1fb7450 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOj
#26 0x0000f1fb7328 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEOj
#27 0x0000f1faade5 _ZNKR4base8CallbackIFvjELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEj
#28 0x0000f1fb61a1 mojo::SimpleWatcher::DiscardReadyState()
#29 0x0000f1fb6571 _ZN4base8internal13FunctorTraitsIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIJS8_jSC_EEEvSE_DpOT_
#30 0x0000f1fb64ce _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJSA_jSE_EEEvOT_DpOT0_
#31 0x0000f1fb6432 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE7RunImplIRKSF_RKNSt3__15tupleIJS7_EEEJLj0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOjSD_
#32 0x0000f1fb62ec _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE3RunEPNS0_13BindStateBaseEOjSD_
#33 0x0000f1f63deb _ZNKR4base8CallbackIFvjRKN4mojo18HandleSignalsStateEELNS_8internal8CopyModeE1ELNS6_10RepeatModeE1EE3RunEjS4_
#34 0x0000f1f6300e mojo::SimpleWatcher::OnHandleReady()
#35 0x0000f1f64fdb _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvS8_OT_DpOT0_
#36 0x0000f1f64eb2 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_
#37 0x0000f1f64dd4 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLj0ELj1ELj2ELj3EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#38 0x0000f1f64bb1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE
#39 0x0000f71d8978 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#40 0x0000f7238fa2 base::debug::TaskAnnotator::RunTask()
#41 0x0000f7305c1f base::MessageLoop::RunTask()
#42 0x0000f7305fa0 base::MessageLoop::DeferOrRunPendingTask()
#43 0x0000f7306d42 base::MessageLoop::DoWork()
#44 0x0000f730f160 base::MessagePumpGlib::HandleDispatch()
#45 0x0000f730fa1d base::(anonymous namespace)::WorkSourceDispatch()
#46 0x0000de8dd1e3 g_main_context_dispatch
#47 0x0000de8dd468 <unknown>
#48 0x0000de8dd528 g_main_context_iteration
#49 0x0000f730f288 base::MessagePumpGlib::Run()
#50 0x0000f73053d0 base::MessageLoop::Run()
#51 0x0000f730540f base::MessageLoop::Run()
#52 0x0000f73ce75e base::RunLoop::Run()
#53 0x000008926c2e (anonymous namespace)::RepeatedNotificationObserver::Wait()
#54 0x00000894ba26 BrowserCloseManagerWithDownloadsBrowserTest_TestBeforeUnloadAndDownloads_Test::RunTestOnMainThread()
#55 0x00000d587c3d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#56 0x00000853196a _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_
#57 0x00000853188a _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#58 0x00000d58a88a _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#59 0x00000d58a771 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#60 0x000008512c8e _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#61 0x00000d0641d9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
[546/606] BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 (10543 ms)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a65b860ee9fe70fb0b1d97bb846ebf971143551

commit 4a65b860ee9fe70fb0b1d97bb846ebf971143551
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Aug 04 10:01:37 2017

Disable BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1

TBR=chrisha@chromium.org

Bug: 749098
Change-Id: Ia814e450c72b65017025bb3eb11db49c31b1498e
Reviewed-on: https://chromium-review.googlesource.com/601968
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491980}
[modify] https://crrev.com/4a65b860ee9fe70fb0b1d97bb846ebf971143551/chrome/browser/lifetime/browser_close_manager_browsertest.cc

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Added the appropriate component. That code has been completely refactored since this was filed, so re-enabling the test is likely the easiest way forward (to see if it's still flaky).