Parse ranges for font-stretch, font-style and font-weight in @font-face rules.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e31835530dff647d03dedd68186bd6f9cfc80ed commit 3e31835530dff647d03dedd68186bd6f9cfc80ed Author: Dominik Röttsches <drott@chromium.org> Date: Wed Aug 02 15:13:39 2017 Parse ranges for weight in @font-face Allow ranges for font-weight in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc Bug: 749091 Change-Id: I7e3fffe6f71d95ad5bc0703d4e01edbbb108cfd0 Reviewed-on: https://chromium-review.googlesource.com/581149 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491375} [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/LayoutTests/css3/calc/number-parsing.html [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/LayoutTests/external/wpt/css-fonts/variations/font-parse-numeric-stretch-style-weight.html [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontWeight.cpp [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h [modify] https://crrev.com/3e31835530dff647d03dedd68186bd6f9cfc80ed/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/422919943172f17b5b682cf65cbdde348ddd1c6a commit 422919943172f17b5b682cf65cbdde348ddd1c6a Author: Dominik Röttsches <drott@chromium.org> Date: Thu Aug 03 11:19:53 2017 Parse ranges for stretch in @font-face Allow ranges for font-stretch in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc Bug: 749091 Change-Id: I79cafc1f7c496617bfb4eca21e28b4b451bdfae5 Reviewed-on: https://chromium-review.googlesource.com/582862 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#491697} [modify] https://crrev.com/422919943172f17b5b682cf65cbdde348ddd1c6a/third_party/WebKit/LayoutTests/external/wpt/css-fonts/variations/font-parse-numeric-stretch-style-weight.html [modify] https://crrev.com/422919943172f17b5b682cf65cbdde348ddd1c6a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/422919943172f17b5b682cf65cbdde348ddd1c6a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStretch.cpp [modify] https://crrev.com/422919943172f17b5b682cf65cbdde348ddd1c6a/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp [modify] https://crrev.com/422919943172f17b5b682cf65cbdde348ddd1c6a/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7edd4217dbf66d1aad9ef33612d874c9b5ba1e44 commit 7edd4217dbf66d1aad9ef33612d874c9b5ba1e44 Author: Dominik Röttsches <drott@chromium.org> Date: Thu Aug 03 11:27:59 2017 Cleanup font-weight range parsing code Incorporate review feedback for font-stretch range parsing code analogously for font-weight. Bug: 749091 Change-Id: Ibd83d6e55fc2e025a57fc78fa1c8273eabc2445e Reviewed-on: https://chromium-review.googlesource.com/599812 Reviewed-by: Rune Lillesveen <rune@opera.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491699} [modify] https://crrev.com/7edd4217dbf66d1aad9ef33612d874c9b5ba1e44/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b0a54a2b22866bc2099eec608c625d603710c00 commit 5b0a54a2b22866bc2099eec608c625d603710c00 Author: Dominik Röttsches <drott@chromium.org> Date: Thu Aug 03 13:59:19 2017 Add comment and two more edge cases in test for font-weight Addressing remaining feedback from https://chromium-review.googlesource.com/c/581149 Bug: 749091 TBR: rune, eae Change-Id: I734d8115b021ea6f996a2d62064208326c8032df Reviewed-on: https://chromium-review.googlesource.com/598948 Reviewed-by: Rune Lillesveen <rune@opera.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491728} [modify] https://crrev.com/5b0a54a2b22866bc2099eec608c625d603710c00/third_party/WebKit/LayoutTests/external/wpt/css-fonts/variations/font-parse-numeric-stretch-style-weight.html [modify] https://crrev.com/5b0a54a2b22866bc2099eec608c625d603710c00/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b4edde07ca4d4cad93b5e37e17758a73cc2a143 commit 8b4edde07ca4d4cad93b5e37e17758a73cc2a143 Author: Dominik Röttsches <drott@chromium.org> Date: Fri Aug 04 09:51:35 2017 Parse ranges for font-style in @font-face Allow ranges for font-style in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc and support the oblique <angle> style property of CSS Fonts Level 4. Bug: 749091 Change-Id: I7888f2f01f3cda8ec1b8d5c13b884f75b1790e50 Reviewed-on: https://chromium-review.googlesource.com/600228 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Reviewed-by: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#491978} [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/LayoutTests/external/wpt/css-fonts/variations/font-parse-numeric-stretch-style-weight.html [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFilter.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStyle.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetRotateUtils.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSPropertyTransformUtils.cpp [modify] https://crrev.com/8b4edde07ca4d4cad93b5e37e17758a73cc2a143/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
Comment 1 by bugdroid1@chromium.org
, Aug 2 2017