chrome://bookmark puts NTP in a strange state |
|||||||||
Issue descriptionChrome Version: (copy from chrome://version) 62.0.3167.0 canary OS: (e.g. Win7, OSX 10.9.5, etc...) 10.3.2 What steps will reproduce the problem? (1) Open a New Tab (2) Tap on search box and type "chrome://bookmarks" into omnibox and tap Go. What is the expected result? It's possible that chrome://bookmarks should be rejected as a valid URL since Chrome iOS Bookmarks UI has gone native. What happens instead? User now has a toolbar at the top of NTP. (see attachment) There shouldn't be one. Pull-to-action animation appears behind this toolbar (that shouldn't have been there in the first place. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 26 2017
,
Aug 3 2017
Hi Rohit, we still need some feedback here. Are there any news?
,
Aug 11 2017
On Android phone we just get an INVALID_URL error page. This is broken enough that we should just stop supporting chrome://bookmarks on phone for now. Longer-term, it seems unfortunate for that URL to work on every platform but iOS phone, so we should consider finding a way for it invoke the native ui? chrome://history is another example that is broken, but again only on iOS phone.
,
Aug 11 2017
OK, I'll disable bookmarks on iPhone only: https://chromium-review.googlesource.com/c/612152
,
Aug 14 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8679e85d3b70d07fa9f318c66c350542726890a1 commit 8679e85d3b70d07fa9f318c66c350542726890a1 Author: Justin Cohen <justincohen@google.com> Date: Mon Aug 14 16:35:25 2017 Only allow navigations to chrome://bookmarks on iPad. Bug: 749082 Change-Id: I87902aff94bb328517b7846dc1512b3a3b01919b Reviewed-on: https://chromium-review.googlesource.com/612152 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#494070} [modify] https://crrev.com/8679e85d3b70d07fa9f318c66c350542726890a1/ios/chrome/browser/ui/browser_view_controller.mm
,
Aug 14 2017
,
Aug 16 2017
This is still reproduced in M62.0.3187.0 canary Navigating to chrome://bookmarks showing Toolbar at the top of the NTP. (Same as the screenshot attached in the bug report) Version: 62.0.3187.0 canary iOS: 10.3.3, 11.0 Device: iPhone6s, iPhone7 plus
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497159595a57a1f210a30b9b170945b76232ac93 commit 497159595a57a1f210a30b9b170945b76232ac93 Author: Justin Cohen <justincohen@google.com> Date: Tue Aug 22 14:12:19 2017 Only allow navigations to chrome://bookmarks on iPad. Followup to crrev.com/494070 with unit tests and fix. Bug: 749082 Change-Id: I4b2f2db2093daa1266651c4451cfc49328492dcf Reviewed-on: https://chromium-review.googlesource.com/624576 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#496300} [modify] https://crrev.com/497159595a57a1f210a30b9b170945b76232ac93/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/497159595a57a1f210a30b9b170945b76232ac93/ios/chrome/browser/ui/browser_view_controller_unittest.mm
,
Aug 22 2017
,
Sep 27 2017
Verified in 62.0.3202.38 Beta, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 For iPhone: This site can't be reached is shown. For iPad: chrome://bookmarks is redirecting to bookmarks Looks good |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by justincohen@chromium.org
, Jul 26 2017