New issue
Advanced search Search tips

Issue 749070 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

legacy-mb-tchinese layout tests timeout on Win 7 (dbg)

Project Member Reported by zakerinasab@chromium.org, Jul 26 2017

Issue description

* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html
* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBb.html

time out on Win 7 (dbg) trybot:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10386

The only related change in past few runs seems to be:

https://chromium.googlesource.com/chromium/src/+/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94

@jshin: Would you please take a look and see if this is related to your change?



 
Labels: -Pri-3 Pri-1
This is also failing and might be related:

* external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han.html

Description: Show this description
Summary: legacy-mb-tchinese layout tests timeout on Win 7 (dbg) (was: legacy-mb-tchinese layout tests failing on Win 7 (dbg))
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0477e0f4bfa0221248a2751e07dfb1eb56163dc5

commit 0477e0f4bfa0221248a2751e07dfb1eb56163dc5
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Jul 26 13:59:26 2017

Allows legacy-mb-tchinese external layout tests to timeout on Win 7 (dbg)

* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html
* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBb.html
* external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han.html

TBR=jshin@chromium.org
NOTRY=true

Bug:  749070 
Change-Id: Ib3c82a862fa48e7546041ca760f4e183078df234
Reviewed-on: https://chromium-review.googlesource.com/586635
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489628}
[modify] https://crrev.com/0477e0f4bfa0221248a2751e07dfb1eb56163dc5/third_party/WebKit/LayoutTests/TestExpectations

Cc: js...@chromium.org
Owner: ----
Not related to jshin@ change. This is happening in builds as old as https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10284. Tracking back to see if the source can be found.

@sky: would you see if you can assign this to a related owner?
Status: Available (was: Assigned)
Labels: -Pri-1 Pri-2

Comment 9 by meade@chromium.org, Jul 28 2017

Cc: sky@chromium.org
I'm guessing zakerinasab@ was meaning to loop in sky@ to see if they can find a related owner?

Comment 10 by drott@chromium.org, Jul 31 2017

Cc: e...@chromium.org drott@chromium.org japhet@chromium.org fmalita@chromium.org
 Issue 749069  has been merged into this issue.

Comment 11 by drott@chromium.org, Jul 31 2017

Same slowness on Mac.
Labels: -Sheriff-Chromium
Removing from sheriff queue

Comment 14 by kbr@chromium.org, Jan 10 2018

Components: Tests>Flaky Blink>Layout
Labels: -Pri-2 Sheriff-Chromium OS-Windows Pri-1
This is causing failures on the commit queue and causing patches to be retried:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/77832

Please disable this test on Windows until it's de-flaked. Thanks.

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11432c40bdf4823c43e682374d3d6b7541629b99

commit 11432c40bdf4823c43e682374d3d6b7541629b99
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Jan 15 07:15:54 2018

Skip legacy-mb-tchinese external layout tests on all platforms

* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html
* external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBb.html
* external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han.html

TBR=kbr@chromium.org
NOTRY=true

Bug:  749070 
Change-Id: I7cf38679af51e1b885d8133053b9f2bda26bd18a
Reviewed-on: https://chromium-review.googlesource.com/866284
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529215}
[modify] https://crrev.com/11432c40bdf4823c43e682374d3d6b7541629b99/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Disabled these tests on all platforms.
Components: -Tests>Flaky -Blink>Layout Blink>TextEncoding
Status: Fixed (was: Available)
Marking as "fixed" since disabling the tests resolved the CQ issues, although the fundamental issue - these tests are big and slow - remains. That's  issue 736056 
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0866e5a8e7fe0450699c18b73c8be109f01bd119

commit 0866e5a8e7fe0450699c18b73c8be109f01bd119
Author: Joshua Bell <jsbell@chromium.org>
Date: Mon Jan 29 18:48:12 2018

Timeout expectations for wpt/encoding/legacy-mb-* tests

Consolidate expectations for the imported Web Platform Tests for
legacy multibyte encodings (Chinese, Japanese, Korean) which exercise
tens of thousands of code points and often time out (>30s) even when
marked as slow.

TBR=kbr@chromium.org

Bug:  805725 , 736056 , 749070 
Change-Id: I12051e3c3a20730783aabb39376b55e9788450f4
Reviewed-on: https://chromium-review.googlesource.com/889538
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532512}
[modify] https://crrev.com/0866e5a8e7fe0450699c18b73c8be109f01bd119/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment