[Dice] Fix auth errors based on SigninErrorController instead of Sync |
|||||||
Issue descriptionDice is fixing auth error when the Sync service is in auth error state. The related code was introduced in CL: https://chromium-review.googlesource.com/c/584527 However, a sync service error does not match exactly the error UI. Typically, after revoking a token, the sync service detects the authentication error after a delay (a couple hours maybe, and even a Chrome restart does not necesssarily put Sync in error state), whereas the SigninErrorController (and the UI in Chrome) shows the error UI earlier than that (almost instantly, and definitely on Chrome restart). It would by slightly better to use the same signal as the UI in Dice: - more consistent with the UI - easier to test (having a delay of a couple hours makes the feature harder to test) - fixing errors earlier is generally a good thing This is filed as a blocking bug for the feature, but it is probably actually optional.
,
Aug 28 2017
Keeping this assigned as this is still relevant.
,
Sep 6 2017
Just noticed this. I don't think it's blocking (so I'm going to remove the blocking bug), but definitely seems like a nice-to-have improvement.
,
Oct 9 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9 2017
,
Nov 9 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2018
Not worth doing at this point, DiceFixAuthErrors will be superseded by Dice soon. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Aug 25 2017