New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749037 link

Starred by 2 users
Status: Verified
Owner:
olivierrobin@chromium.org
Closed: Aug 2017
Cc:
justincohen@chromium.org
█ lod@chromium.org
pkl@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[iOS11] Today extension does not work on iOS11 if Chrome is already running.

Project Member Reported by olivierrobin@chromium.org, Jul 26 2017 
App Version (from "Chrome Settings > About Chrome"): M61
iOS Version: iOS11 (15A5327g)
Device: All

Steps to reproduce: 
1. Open Chrome
2. Open Notification center
3. Tap an action on Chrome 

Observed behavior: 
Chrome is launched. No action is done.

Expected behavior: 
Action should be done.

Frequency: 
<number of times you were able to reproduce> 

Additional comments: 
This is due to the fact that openURL is now called after applicationDidBecomeActive when returning to application from notification center.

Comment 1 by justincohen@chromium.org, Jul 26 2017

Labels: ReleaseBlock-Stable Hotlist-iOS11 M-61

Comment 2 by pkl@chromium.org, Jul 26 2017

Cc: pkl@chromium.org

Comment 3 by lod@chromium.org, Jul 27 2017 

 Issue 749028  has been merged into this issue.

Comment 4 by cma...@chromium.org, Jul 31 2017 

Any update here?
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3666256d04b5aed015558924bc14d36c57eec42a

commit 3666256d04b5aed015558924bc14d36c57eec42a
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Aug 02 08:21:07 2017

Fix OpenURL handling on iOS 11.

On iOS11, |UIApplicationDelegate application:openURL:options:| is always
called on active app.
It means that if launching Chrome from inactive state by opening a
chrome:// URL, applicationDidBecomeActive will be called before openURL.
It was the opposite before iOS10.

Fix the handling of openURL to open correctly the tab.

Note: A lot of the code handling openURL on inactive state can be
removed once iOS10 is deprecated.

Bug:  749037 
Change-Id: I29e8e1fb17ea02a0d28dee43382a35d9d1b01377
Reviewed-on: https://chromium-review.googlesource.com/586593
Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491309}
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/mock_tab_opener.h
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/mock_tab_opener.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/tab_opening.h
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/url_opener.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/user_activity_handler.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/chrome_app_startup_parameters.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/chrome_app_startup_parameters_unittest.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/app/spotlight/actions_spotlight_manager.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/browser/app_startup_parameters.h
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/browser/chrome_url_util.h
[modify] https://crrev.com/3666256d04b5aed015558924bc14d36c57eec42a/ios/chrome/browser/chrome_url_util.mm

Comment 7 by cma...@chromium.org, Aug 2 2017 

Is the CL above fixing this bug?

Comment 8 by olivierrobin@chromium.org, Aug 3 2017

Labels: Merge-Request-61
Status: Fixed (was: Started)
Yes
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 4 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 7 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bac5da78566ce17886a12d09b64aed763c797e7

commit 9bac5da78566ce17886a12d09b64aed763c797e7
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Aug 08 11:20:53 2017

Fix OpenURL handling on iOS 11.

On iOS11, |UIApplicationDelegate application:openURL:options:| is always
called on active app.
It means that if launching Chrome from inactive state by opening a
chrome:// URL, applicationDidBecomeActive will be called before openURL.
It was the opposite before iOS10.

Fix the handling of openURL to open correctly the tab.

Note: A lot of the code handling openURL on inactive state can be
removed once iOS10 is deprecated.

TBR=olivierrobin@chromium.org

(cherry picked from commit 3666256d04b5aed015558924bc14d36c57eec42a)

Bug:  749037 
Change-Id: I29e8e1fb17ea02a0d28dee43382a35d9d1b01377
Reviewed-on: https://chromium-review.googlesource.com/586593
Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491309}
Reviewed-on: https://chromium-review.googlesource.com/604796
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#378}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/mock_tab_opener.h
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/mock_tab_opener.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/tab_opening.h
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/url_opener.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/user_activity_handler.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/chrome_app_startup_parameters.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/chrome_app_startup_parameters_unittest.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/app/spotlight/actions_spotlight_manager.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/browser/app_startup_parameters.h
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/browser/chrome_url_util.h
[modify] https://crrev.com/9bac5da78566ce17886a12d09b64aed763c797e7/ios/chrome/browser/chrome_url_util.mm

Comment 12 by vbarig...@chromium.org, Aug 9 2017

Status: Verified (was: Fixed)
Verified on chrome beta version 61.0.6163.40 on iPhone 6 plus and iPad Air with iOS 11 beta 5, following steps mentioned in comment #0. Today's View actions on chrome beta take place.  Looks good.
►

Sign in to add a comment