New issue
Advanced search Search tips

Issue 749024 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

FirstRunUIBrowserTest.FirstRunFlow in browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by yukishiino@chromium.org, Jul 26 2017

Issue description

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

--------
[ RUN      ] FirstRunUIBrowserTest.FirstRunFlow
[28563:28563:0725/180526.522075:WARNING:chrome_browser_main_chromeos.cc(544)] Running as stub user with profile dir: test-user
[28563:28853:0725/180527.285594:ERROR:logging_chrome.cc(180)] Unable to create symlink /b/s/w/ite9I6f1/.org.chromium.Chromium.PqKkf3/dZnn5Hk/test-user/chrome_debug.log pointing at /b/s/w/ite9I6f1/.org.chromium.Chromium.PqKkf3/dZnn5Hk/test-user/chrome_debug_20170725-180527.log: No such file or directory (2)
[28563:28875:0725/180528.331791:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[28563:28563:0725/180530.060427:FATAL:l10n_util.cc(729)] Check failed: std::string::npos != pos (18446744073709551615 vs. 18446744073709551615) Didn't find a $1 placeholder in Discover more features or get answers. Select ??? for help.
#0 0x7fac62bdcd5b base::debug::StackTrace::StackTrace()
#1 0x7fac62bdb91c base::debug::StackTrace::StackTrace()
#2 0x7fac62c47667 logging::LogMessage::~LogMessage()
#3 0x7fac5e5da2bd l10n_util::GetStringFUTF16()
#4 0x7fac5e5da4cf l10n_util::GetStringFUTF16()
#5 0x000007b44a11 (anonymous namespace)::SetLocalizedStrings()
#6 0x000007b446fd (anonymous namespace)::CreateDataSource()
#7 0x000007b4457c chromeos::FirstRunUI::FirstRunUI()
#8 0x000007b2e2cf (anonymous namespace)::NewWebUI<>()
#9 0x000007b2cb22 ChromeWebUIControllerFactory::CreateWebUIControllerForURL()
#10 0x7fac5ada5047 content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL()
#11 0x7fac5ad390bf content::WebContentsImpl::CreateWebUI()
#12 0x7fac5ad4cb6c content::WebContentsImpl::CreateWebUIForRenderFrameHost()
#13 0x7fac5ad4cbb6 content::WebContentsImpl::CreateWebUIForRenderFrameHost()
#14 0x7fac5a42395b content::RenderFrameHostImpl::UpdatePendingWebUI()
#15 0x7fac5a46f836 content::RenderFrameHostManager::UpdateStateForNavigate()
#16 0x7fac5a46ed0d content::RenderFrameHostManager::Navigate()
#17 0x7fac5a4064fd content::NavigatorImpl::NavigateToEntry()
#18 0x7fac5a407808 content::NavigatorImpl::NavigateToPendingEntry()
#19 0x7fac5a3d47d8 content::NavigationControllerImpl::NavigateToPendingEntryInternal()
#20 0x7fac5a3cbc72 content::NavigationControllerImpl::NavigateToPendingEntry()
#21 0x7fac5a3cc18a content::NavigationControllerImpl::LoadEntry()
#22 0x7fac5a3ce08d content::NavigationControllerImpl::LoadURLWithParams()
#23 0x7fac5a3cd54f content::NavigationControllerImpl::LoadURL()
#24 0x7fac508d4064 views::WebView::LoadInitialURL()
#25 0x0000020b38f5 chromeos::FirstRunView::Init()
#26 0x0000020b1461 chromeos::FirstRunController::Init()
#27 0x0000020b1383 chromeos::FirstRunController::Start()
#28 0x0000020b0aaa chromeos::first_run::LaunchTutorial()
#29 0x0000018d46a9 chromeos::FirstRunUIBrowserTest::LaunchTutorial()
#30 0x0000018d3f35 chromeos::FirstRunUIBrowserTest_FirstRunFlow_Test::RunTestOnMainThread()
#31 0x0000051bd4b7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#32 0x0000008feced _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_
#33 0x0000008fec01 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#34 0x0000051bf107 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#35 0x0000051bf04c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#36 0x0000008e61fd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#37 0x0000041f4ad2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#38 0x0000041f3860 ChromeBrowserMainParts::PreMainMessageLoopRun()
#39 0x000001f14bae chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#40 0x7fac5a02fcc1 content::BrowserMainLoop::PreMainMessageLoopRun()
#41 0x7fac59259b5d _ZN4base8internal13FunctorTraitsIMN7content14NetworkContextEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#42 0x7fac5a038c11 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_
#43 0x7fac5a038bb7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#44 0x7fac5a038afc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#45 0x7fac5923a3fd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#46 0x7fac5acc188b content::StartupTaskRunner::RunAllTasksNow()
#47 0x7fac5a02d860 content::BrowserMainLoop::CreateStartupTasks()
#48 0x7fac5a03bc47 content::BrowserMainRunnerImpl::Initialize()
#49 0x7fac5a02a0cf content::BrowserMain()
#50 0x7fac5ba6b586 content::RunNamedProcessTypeMain()
#51 0x7fac5ba6d6fe content::ContentMainRunnerImpl::Run()
#52 0x7fac5ba6a1da content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#53 0x7fac5676b6af service_manager::Main()
#54 0x7fac5ba6b0ab content::ContentMain()
#55 0x0000051bd1dc content::BrowserTestBase::SetUp()
#56 0x00000413d00b InProcessBrowserTest::SetUp()
#57 0x00000088512e _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_
#58 0x000002671be2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#59 0x000002666e04 testing::Test::Run()
#60 0x00000266758d testing::TestInfo::Run()
#61 0x000002667b2f testing::TestCase::Run()

 
wzang@, your CL seems dropping a "$1" place holder in a message, and it seems causing a test failure.
Will revert your CL: https://chromium-review.googlesource.com/c/584859/

Comment 2 by wzang@chromium.org, Jul 27 2017

yukishiino@, I will land a new CL https://chromium-review.googlesource.com/c/587289/. In case there were some tests failing again (which should be unlikely), would you please let me know right away and please do not revert it directly, because additional time will be needed for another round of code review if it's reverted. Our team is depending on the CL to land by this Friday in order for the string to be properly translated for M61. Thanks for understanding!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d

commit 2651d426c8c8fd0b85d9c7a8a85883b0579daf5d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jul 27 08:46:32 2017

Update Welcome App texts and remove $1 placeholder

A reland of 584859 after updating first_run_ui.cc

Bug:  748698 ,  749024 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic62094e0965d534c8b528e5801182d7febe7ad7d
Reviewed-on: https://chromium-review.googlesource.com/587289
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489885}
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 4 by meade@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
Seems fixed.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c86ad30d94d466286595bfa2257ddcb82f93f873

commit c86ad30d94d466286595bfa2257ddcb82f93f873
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 28 22:40:49 2017

Update Welcome App texts and remove $1 placeholder

A reland of 584859 after updating first_run_ui.cc

TBR=wzang@chromium.org

(cherry picked from commit 2651d426c8c8fd0b85d9c7a8a85883b0579daf5d)

Bug:  748698 ,  749024 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic62094e0965d534c8b528e5801182d7febe7ad7d
Reviewed-on: https://chromium-review.googlesource.com/587289
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489885}
Reviewed-on: https://chromium-review.googlesource.com/592423
Cr-Commit-Position: refs/branch-heads/3163@{#119}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment