New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749014 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Radio button doesn't get selected even if focus is present in permission bubble.

Reported by vku...@etouch.net, Jul 26 2017

Issue description

Chrome Version:61.0.3163.13 (Official Build)6b33a795b0ff8c8938a640dbb7e8520f91572d3c-refs/branch-heads/3163@{#44} (32/64-Bit). 
OS:Win(7,8,10), Mac(10.12.3, 10.11.6).

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://permission.site/
(2)Click 'Auto download' , click on block button such that bubble appears in omnibox.
(3)Click on bubble and press tab key then up/down arrow key to select radio button and observe.

Actual: Radio button doesn't get selected even if focus is present.

Expected: Radio button should get selected once focus appears after pressing up/down arrow key.

This is a regression issue broken in 'M61' and below is the manual regression range
Good Build: 61.0.3142.0
Bad Build:  61.0.3143.0

Note: Issue not seen on Mac OS



 
Actual_Radio.mp4
391 KB View Download
Expected_Radio.mp4
285 KB View Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 61.0.3142.0,  Revision Range- 482491
Bad build  : 61.0.3143.0,  Revision Range- 482834

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/28347e73895e16a6eb7b512d1b7e96f39bab9a75..a3fb693eb7384259d24c3f5f3835c428860aa6f6


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a3fb693eb7384259d24c3f5f3835c428860aa6f6


bsep@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.


Thank You...

Comment 2 by bsep@chromium.org, Jul 27 2017

Yes, that looks related to my change. I'll take a look.
Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Thank You!
 bsep@ do we have any update on the issue, Please let us know.

Comment 5 by bsep@chromium.org, Jul 31 2017

I haven't investigated yet. It's next on my list.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b173f861a75fa70a39515bcca7d323684d1cfe0

commit 9b173f861a75fa70a39515bcca7d323684d1cfe0
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Aug 01 22:23:47 2017

Fix not being able to select radio buttons with the arrow keys.

Restores the OnFocus > SetChecked line in RadioButton removed in
https://chromium-review.googlesource.com/c/547075, which is required
to let the user move the radio selection with the arrow keys.

Bug:  749014 
Change-Id: I861f64b3abbcaac2ec762c7014e5b5e6bee8965b
Reviewed-on: https://chromium-review.googlesource.com/595231
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491132}
[modify] https://crrev.com/9b173f861a75fa70a39515bcca7d323684d1cfe0/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/9b173f861a75fa70a39515bcca7d323684d1cfe0/ui/views/controls/button/radio_button.h

Comment 7 by bsep@chromium.org, Aug 1 2017

Labels: Merge-Request-61
Not marking as fixed yet because I'd like to add a test for this.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 2 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1e339091beed5679920504a7208726f68e69f14

commit f1e339091beed5679920504a7208726f68e69f14
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Aug 02 23:09:28 2017

Fix not being able to select radio buttons with the arrow keys.

Restores the OnFocus > SetChecked line in RadioButton removed in
https://chromium-review.googlesource.com/c/547075, which is required
to let the user move the radio selection with the arrow keys.

TBR=bsep@chromium.org

(cherry picked from commit 9b173f861a75fa70a39515bcca7d323684d1cfe0)

Bug:  749014 
Change-Id: I861f64b3abbcaac2ec762c7014e5b5e6bee8965b
Reviewed-on: https://chromium-review.googlesource.com/595231
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491132}
Reviewed-on: https://chromium-review.googlesource.com/599188
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#250}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/f1e339091beed5679920504a7208726f68e69f14/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/f1e339091beed5679920504a7208726f68e69f14/ui/views/controls/button/radio_button.h

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7687d9be707990b4352d3a400d27c52c400e4eea

commit 7687d9be707990b4352d3a400d27c52c400e4eea
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Aug 03 01:39:12 2017

Add test for radio button focus behavior.

Bug:  749014 
Change-Id: Idfb6407a11af4307e68e6e6ebae7b21d1cf1958d
Reviewed-on: https://chromium-review.googlesource.com/599025
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491600}
[modify] https://crrev.com/7687d9be707990b4352d3a400d27c52c400e4eea/ui/views/BUILD.gn
[add] https://crrev.com/7687d9be707990b4352d3a400d27c52c400e4eea/ui/views/controls/button/radio_button_unittest.cc

Cc: pbomm...@chromium.org
Rechecked this issue on Ubuntu 14.04 using build 61.0.3163.31 and fix is working as intended. 

Not adding TE-verified labels as, could not verify on Windows OS as builds are not yet available (till 6:35 PM IST)

Request @pbomanna to take a look into it.

Thanks.!
Labels: TE-Verified-61.0.3163.31
verified the issue on Windows 7 and 10 with Chrome version 61.0.3163.31.

Note : The permission bubble now pop's up at the left side of browser and has "Allow" and "Block" submit buttons instead of radio buttons as mentioned in bug report.

Comment 13 by bsep@chromium.org, Aug 3 2017

Status: Verified (was: Assigned)

Sign in to add a comment